Re: [PATCH v5] fetch/gitsm: avoid live submodule fetching during unpack()

From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Matt Hoosier <matt.hoosier@gmail.com>,
	bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH v5] fetch/gitsm: avoid live submodule fetching during unpack()
Date: Wed, 06 Jun 2018 11:19:12 +0100	[thread overview]
Message-ID: <03bb3ecd46e56bc21799d56f723bc01d966230c8.camel@linuxfoundation.org> (raw)
In-Reply-To: <20180525134537.27659-1-matt.hoosier@gmail.com>

On Fri, 2018-05-25 at 08:45 -0500, Matt Hoosier wrote:
> Although the submodules' histories have been fetched during the
> do_fetch() phase, the mechanics used to clone the workdir copy
> of the repo haven't been transferring the actual .git/modules
> directory from the repo fetched into downloads/ during the
> fetch task.
> 
> Fix that, and for good measure also explicitly tell Git to avoid
> hitting the network during do_unpack() of the submodules.
> 
> [YOCTO #12739]
> 
> Signed-off-by: Matt Hoosier <matt.hoosier@gmail.com>
> ---
>  lib/bb/fetch2/gitsm.py | 84
> +++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 76 insertions(+), 8 deletions(-)

I hate to say this but we saw another failure from this :(

https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/1099/steps/Running%20oe-selftest/logs/stdio

(the second one, grep for submodule deinit)

This was running on the centos 7 worker so I suspect older git versions
don't have the options you're using.

Cheers,

Richard