[U-Boot] [PATCH] ARM: kirkwood: add spi0 alias for dreamplug

From: Leigh Brown <leigh@solinno.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: kirkwood: add spi0 alias for dreamplug
Date: Thu, 28 Feb 2019 09:13:48 +0000	[thread overview]
Message-ID: <03bf8d1aca49d0337b820b6efa88e5c6@solinno.co.uk> (raw)
In-Reply-To: <20190228075322.17316-1-judge.packham@gmail.com>

Hi Chris,

I tested together with my own patch. It fixes the issue, thanks very 
much!

Tested-by: Leigh Brown <leigh@solinno.co.uk>

Output:

U-Boot 2019.04-rc2-00134-g783e66816d-dirty (Feb 28 2019 - 08:27:16 
+0000)
Marvell-DreamPlug

SoC:   Kirkwood 88F6281_A1
DRAM:  512 MiB
Loading Environment from SPI Flash... SF: Detected mx25l1606e with page 
size 256 Bytes, erase size 4 KiB, total 2 MiB
OK
In:    serial
Out:   serial
Err:   serial
Net:   egiga0, egiga1
88E1116 Initialized on egiga0
88E1116 Initialized on egiga1
IDE:   ide_preinit failed
Hit any key to stop autoboot:  0
starting USB...
USB0:   USB EHCI 1.00
scanning bus 0 for devices... 4 USB Device(s) found
        scanning usb for storage devices... Device NOT ready
    Request Sense returned 02 3A 00
1 Storage Device(s) found
1879928 bytes read in 130 ms (13.8 MiB/s)
9949 bytes read in 40 ms (242.2 KiB/s)
2746404 bytes read in 163 ms (16.1 MiB/s)
## Booting kernel from Legacy Image at 06000000 ...
    Image Name:   uImage-4.19.7+
    Created:      2018-12-06  14:10:50 UTC
    Image Type:   ARM Linux Kernel Image (uncompressed)
    Data Size:    1879864 Bytes = 1.8 MiB
    Load Address: 00008000
    Entry Point:  00008000
    Verifying Checksum ... OK
## Loading init Ramdisk from Legacy Image at 06600000 ...
    Image Name:   uInitrd-4.19.7+
    Created:      2018-12-06  14:10:50 UTC
    Image Type:   ARM Linux RAMDisk Image (uncompressed)
    Data Size:    2746340 Bytes = 2.6 MiB
    Load Address: 00000000
    Entry Point:  00000000
    Verifying Checksum ... OK
## Flattened Device Tree blob at 06400000
    Booting using the fdt blob at 0x6400000
    Loading Kernel Image ... OK
    Loading Ramdisk to 0fd61000, end 0ffff7e4 ... OK
    Loading Device Tree to 0fd5b000, end 0fd606dc ... OK

Starting kernel ...

On 2019-02-28 07:53, Chris Packham wrote:
> The conversion to DM_SPI managed to break accessing the environment on
> dreamplug. This is because the environment code relies on being to able
> to select the SPI device based on the sequence number. Add an alias so
> that the spi0 bus gets sequence number 0.
> 
> Reported-by: Leigh Brown <leigh@solinno.co.uk>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> Leigh,
> 
> Could you test this on your system for me. I'm only able to compile 
> test
> this myself.
> 
>  arch/arm/dts/kirkwood-dreamplug.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/kirkwood-dreamplug.dts
> b/arch/arm/dts/kirkwood-dreamplug.dts
> index a647a65c20a0..ccd74dd7fb33 100644
> --- a/arch/arm/dts/kirkwood-dreamplug.dts
> +++ b/arch/arm/dts/kirkwood-dreamplug.dts
> @@ -18,6 +18,10 @@
>  		stdout-path = &uart0;
>  	};
> 
> +	aliases {
> +		spi0 = &spi0;
> +	};
> +
>  	ocp at f1000000 {
>  		pinctrl: pin-controller at 10000 {
>  			pmx_led_bluetooth: pmx-led-bluetooth {

Regards,

Leigh.