From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 10/12] net/mvpp2: align documentation with
 MUSDK 18.09
Date: Mon, 24 Sep 2018 12:36:50 +0100
Message-ID: <03d2129a-2ceb-a483-cc22-ed354751a13f@intel.com>
References: <1536045016-32008-1-git-send-email-tdu@semihalf.com>
 <1536068953-9352-11-git-send-email-tdu@semihalf.com>
 <c466cc06-6e9a-510f-515f-fc743ecb20b8@intel.com> <10679582.IxOl8a41ax@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, mw@semihalf.com
To: Thomas Monjalon <thomas@monjalon.net>, Tomasz Duszynski
 <tdu@semihalf.com>, nsamsono@marvell.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 7572F2B8C
 for <dev@dpdk.org>; Mon, 24 Sep 2018 13:38:24 +0200 (CEST)
In-Reply-To: <10679582.IxOl8a41ax@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
> 19/09/2018 19:15, Ferruh Yigit:
>> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote:
>>> From: Natalie Samsonov <nsamsono@marvell.com>
>>> --- a/doc/guides/nics/mvpp2.rst
>>> +++ b/doc/guides/nics/mvpp2.rst
>>> -     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10
>>> +     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09
>>
>> There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older
>> versions. It is hard to trace this dependency, what do you think having a matrix
>> in DPDK documentation showing which DPDK version supports which MUSDK?
> 
> It does not compile even with MUSDK 18.09.
> 
> With MUSDK 18.09, the error is:
> 	drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_NUM' undeclared

I confirm same error. I wasn't building with crypto PMD enabled so not caught it.

> 
> The explanation is in MUSDK:
> commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce
> Author: Dmitri Epshtein <dima@marvell.com>
> Date:   Mon Nov 20 10:38:31 2017 +0200
> 
>     sam: remove SAM_HW_RING_NUM from APIs
>     
>     Use function:
>     u32 sam_get_num_cios(u32 inst);
> 
> As a consequence, next-net cannot be pulled!

Got it, should I drop the patchset from tree?