From: Michael Walle <michael@walle.cc>
To: Peng Fan <peng.fan@nxp.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
linux-arm-kernel@lists.infradead.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
aisheng.dong@nxp.com, linux-arm-kernel@lists.infradead.org,
srinivas.kandagatla@linaro.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>
Subject: Re: issue: could not get #nvmem-cell-cells
Date: Tue, 10 Jan 2023 15:45:28 +0100 [thread overview]
Message-ID: <03db256d8cb68344d9e42ae8ee694ec7@walle.cc> (raw)
In-Reply-To: <DU0PR04MB94174EC5A35480EFBAC895BD88FF9@DU0PR04MB9417.eurprd04.prod.outlook.com>
Hi Peng,
Am 2023-01-10 09:07, schrieb Peng Fan:
> I see you have added nvmem-cell-cells support, but with linux-next, I
> see error on i.MX8MP-EVK:
> [ 0.027518] OF: /soc@0: could not get #nvmem-cell-cells for
> /soc@0/bus@30000000/efuse@30350000/unique-id@8
> [ 0.027868] OF: /soc@0/bus@30000000/tmu@30260000: could not get
> #nvmem-cell-cells for /soc@0/bus@30000000/efuse@30350000/calib@264
> [ 0.030338] OF: /soc@0/bus@30800000/ethernet@30be0000: could not
> get #nvmem-cell-cells for
> /soc@0/bus@30000000/efuse@30350000/mac-address@90
> [ 0.030511] OF: /soc@0/bus@30800000/ethernet@30bf0000: could not
> get #nvmem-cell-cells for
> /soc@0/bus@30000000/efuse@30350000/mac-address@96
>
> Do you have ideas?
Could you try the following patch:
---snip---
commit 83f1bd351a2194844599ffc08050f5bc61a06086 (HEAD -> master)
Author: Michael Walle <michael@walle.cc>
Date: Tue Jan 10 15:16:48 2023 +0100
of: property: fix #nvmem-cell-cells parsing
Commit 67b8497f005 ("of: property: make #.*-cells optional for
simple
props") claims to make the cells-name property optional for simple
properties, but changed the code for the wrong property, i.e. for
DEFINE_SUFFIX_PROP(). Fix that.
Fixes: 67b8497f005 ("of: property: make #.*-cells optional for
simple props")
Reported-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Michael Walle <michael@walle.cc>
diff --git a/drivers/of/property.c b/drivers/of/property.c
index 8d9ba20a8f90..95b838185b2f 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1202,8 +1202,8 @@ static struct device_node *parse_prop_cells(struct
device_node *np,
if (strcmp(prop_name, list_name))
return NULL;
- if (of_parse_phandle_with_args(np, list_name, cells_name, index,
- &sup_args))
+ if (__of_parse_phandle_with_args(np, list_name, cells_name, 0,
index,
+ &sup_args))
return NULL;
return sup_args.np;
@@ -1256,8 +1256,8 @@ static struct device_node
*parse_suffix_prop_cells(struct device_node *np,
if (strcmp_suffix(prop_name, suffix))
return NULL;
- if (__of_parse_phandle_with_args(np, prop_name, cells_name, 0,
index,
- &sup_args))
+ if (of_parse_phandle_with_args(np, prop_name, cells_name, index,
+ &sup_args))
return NULL;
return sup_args.np;
---snip---
-
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-10 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 8:07 issue: could not get #nvmem-cell-cells Peng Fan
2023-01-10 8:12 ` Michael Walle
2023-01-10 8:14 ` Peng Fan
2023-01-10 10:32 ` Alexander Stein
2023-01-10 10:47 ` Michael Walle
2023-01-10 14:45 ` Michael Walle [this message]
2023-01-10 15:52 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03db256d8cb68344d9e42ae8ee694ec7@walle.cc \
--to=michael@walle.cc \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.