From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A902C433F5 for ; Mon, 16 May 2022 07:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238225AbiEPHKT (ORCPT ); Mon, 16 May 2022 03:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231247AbiEPHKP (ORCPT ); Mon, 16 May 2022 03:10:15 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B4AE035 for ; Mon, 16 May 2022 00:10:04 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id v4so16960204ljd.10 for ; Mon, 16 May 2022 00:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sxWW7nN1MX4qR5x7vYWxWhZdhe/dlQM1wOVqJQxUPUw=; b=xfgSJvvTfpB3bhvG57n8DdOASbQWiiD0aJbEx2q9VQiFwTMWieLv+76CkJZ+U2n5nd SeLg+QQPZ6V0nSyPBqobwtFuUOpjjzJSoROqSiq2V7Lj9xLXR9XI2j8rJYfID1yZzMj8 XYC4vFiYINn/Pu0Kw38I6/ttfnhseJChXYkyHSKswuerj7YUKcUcoGx6WrX3zTuWbAFj BTqaz6IRcnWwUweLAZORhNAjK8LbQDIP25u3i0mgFmyuV3xVI+3yddr0b/HTBSLyGUff JthW+Y2HVfZJFRs03mpTS0HA5Y3waFMYbEb0YtBrM8ENx2y/t+3UVmH84hiaV9lxEk+f 7xOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sxWW7nN1MX4qR5x7vYWxWhZdhe/dlQM1wOVqJQxUPUw=; b=VB17xMWNHzcmTvFgJsvwcD1ySFyd6KZHk8rUihCvTcJPs0d1eXjV+Dbp/4vWU4QJMc J4sw2EBZzz7DlSoR28z5stpZ08YS4rJIodLPxZ+kj8TH5mfvVrLB8WWJMzXEkfvF4MYq kmENaSeezt2BQtRIDD3DPitZhmeISb24PfGx8fNOz9B+1ZNImbOixWWV1FI4uIc80lUi Q9vCEV63/hgCLfTbN+L84lBg2AsfPPjgfStZ2CSFNLZy2PP7OlWyWk9Q8GFyXuZyh/mS m82rQXMLJdMd3+9G7lXZ/203Tc3Dn61ehb9pGyqEVS5fWkGILdzZpQMRw1JVEfq41IRQ aF7Q== X-Gm-Message-State: AOAM531HR6gDaGG0PYnaAFdNivGzqvCafLyPulKn71Weoy6AaDumZu6k 1I+JDsa6zzvrkzy2/4BHmEIgcw== X-Google-Smtp-Source: ABdhPJzxRNYsZvOCN6MRG+JxA+WtxP3xo+m55ow/RQL6xD2LzouYeDYYoKb2Omp9nqb+r+aHW9F1iA== X-Received: by 2002:a2e:bc14:0:b0:24f:5060:1dc3 with SMTP id b20-20020a2ebc14000000b0024f50601dc3mr10335364ljf.432.1652685003164; Mon, 16 May 2022 00:10:03 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o5-20020a05651205c500b004758e4e6a96sm1222932lfo.245.2022.05.16.00.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 00:10:02 -0700 (PDT) Message-ID: <03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org> Date: Mon, 16 May 2022 09:10:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs Content-Language: en-US To: AngeloGioacchino Del Regno , robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, paul.bouchara@somainline.org, kernel@collabora.com References: <20220513171617.504430-1-angelogioacchino.delregno@collabora.com> <20220513171617.504430-6-angelogioacchino.delregno@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220513171617.504430-6-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On 13/05/2022 19:16, AngeloGioacchino Del Regno wrote: > Add the 32kHz and 26MHz oscillators as fixed clocks in devicetree to > provide a good initial clock spec, since this SoC features two always I don't understand that part with actual patch. You claim here you add clocks, but in DTS they were already before. Additionally, these clocks do not belong to DTSI because, AFAIU, these are properties of boards. At least their frequencies should be moved to the board DTS. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6321C433EF for ; Mon, 16 May 2022 07:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uXeAHtIPBI6FocXOQagBGFl/yytyY6yTn9MNzyEhCyk=; b=XQLymHhWcq6tj8 tZscAggXaCVmABVVGyVOBhgQ43tU2r21LVdYc5vXk+0huZN0cuzmZiC9S79/ktjDRzSkcWN/LJwt9 ms8lPtvds3uwDernClFGXAov69OTiNv/vigR/ehv9l21I7C+e1jh60k6+ZjYT6eA5+3xKo7hnpAGl WcVTyb1qs5LpymcJKEjLMVRUYKhGaXZgoLukw8HQ6SO1GzkpDNFz0Ajw29tuqWkOxyvTF2ANUAoRD b9pTEzYRPRG4nZI1HFxVfSGV/9UfByGLzH1r9U3xIqECizQRi5EavqsGbPDyYRC5Q+eAxyirQ6pYD QMQQXvtcVeVVwh8vJlYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUu0-006MUu-4s; Mon, 16 May 2022 07:12:24 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUrm-006LNJ-LE for linux-mediatek@lists.infradead.org; Mon, 16 May 2022 07:10:08 +0000 Received: by mail-lj1-x22a.google.com with SMTP id bx33so16950620ljb.12 for ; Mon, 16 May 2022 00:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sxWW7nN1MX4qR5x7vYWxWhZdhe/dlQM1wOVqJQxUPUw=; b=xfgSJvvTfpB3bhvG57n8DdOASbQWiiD0aJbEx2q9VQiFwTMWieLv+76CkJZ+U2n5nd SeLg+QQPZ6V0nSyPBqobwtFuUOpjjzJSoROqSiq2V7Lj9xLXR9XI2j8rJYfID1yZzMj8 XYC4vFiYINn/Pu0Kw38I6/ttfnhseJChXYkyHSKswuerj7YUKcUcoGx6WrX3zTuWbAFj BTqaz6IRcnWwUweLAZORhNAjK8LbQDIP25u3i0mgFmyuV3xVI+3yddr0b/HTBSLyGUff JthW+Y2HVfZJFRs03mpTS0HA5Y3waFMYbEb0YtBrM8ENx2y/t+3UVmH84hiaV9lxEk+f 7xOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sxWW7nN1MX4qR5x7vYWxWhZdhe/dlQM1wOVqJQxUPUw=; b=yWFuytxntgc4YAnOwgXYafJo3PZ3loiUXHirK9T6VrC0RkkCAzsy9kc4mXxfw8ouMD oEg/fNmIps+tuW0kxaa5yvfk234RN/JZEUK7zS9Ejev3ALGl2ts/3osUXKuYdu2jf7hj m9uAZIFMUQDOcMzz7My60pTuSYzPzW7AdtSCTRrnETq+vgGwhvP2qqddsjt5vmBUP+A0 +PMU/axAiJ2IMYc7cY+0PEeAAhRO2f2p5IZfQ4eQn+ekhvJDBkuaOQlC3Z8R+5D1e5WE STrc5Y2Dam4TpRvB0HXBX4HVbDB6DeNSaBSRyQdqX5AghT0W6LO+OtG5FZgB2KY9TSNu Ur/Q== X-Gm-Message-State: AOAM531IKvfXs+pEnvqioGHJXm7H9PLQT6kjGyfUzybnFQntRmvkNIMw kwGkYRfLLs+IFAdBB2HWYrQ6/g== X-Google-Smtp-Source: ABdhPJzxRNYsZvOCN6MRG+JxA+WtxP3xo+m55ow/RQL6xD2LzouYeDYYoKb2Omp9nqb+r+aHW9F1iA== X-Received: by 2002:a2e:bc14:0:b0:24f:5060:1dc3 with SMTP id b20-20020a2ebc14000000b0024f50601dc3mr10335364ljf.432.1652685003164; Mon, 16 May 2022 00:10:03 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o5-20020a05651205c500b004758e4e6a96sm1222932lfo.245.2022.05.16.00.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 00:10:02 -0700 (PDT) Message-ID: <03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org> Date: Mon, 16 May 2022 09:10:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs Content-Language: en-US To: AngeloGioacchino Del Regno , robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, paul.bouchara@somainline.org, kernel@collabora.com References: <20220513171617.504430-1-angelogioacchino.delregno@collabora.com> <20220513171617.504430-6-angelogioacchino.delregno@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220513171617.504430-6-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_001006_751344_DAEE1542 X-CRM114-Status: UNSURE ( 7.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 13/05/2022 19:16, AngeloGioacchino Del Regno wrote: > Add the 32kHz and 26MHz oscillators as fixed clocks in devicetree to > provide a good initial clock spec, since this SoC features two always I don't understand that part with actual patch. You claim here you add clocks, but in DTS they were already before. Additionally, these clocks do not belong to DTSI because, AFAIU, these are properties of boards. At least their frequencies should be moved to the board DTS. Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73FB8C433F5 for ; Mon, 16 May 2022 07:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hwMYBn4zeLCeDtGZ95V80v4RlLUnKxhW2KKVk0aSOig=; b=I57NXyQBrBXqbK cadDkWaJolhTA5aFhTTvVauyXDqprOJPl4znjWwP38MpL7KHOkGEjMXTEu3XgD6lSV9OJNTNKvhr+ 4iNLMJ+zXSLkJLPiMxnWNAcc8whvxqBgOTcuwvkheCXcqQJSSi4u0Y4TA6YUgFWd6a4BikvXkmB5+ KckUIMPAsrw4W0nmYxUzMr64CURAh2wvGMHRRDYmte3hk258CIygDbdLcgJ0TXtv5KOAeEiAr24G4 nJnXWtnOdAwV7gxEWuOTQAaiU/vdh60C1mAFX+LCXkadzqOZzqMQiyIDeoJNoOoc0FS3oUxj82Ojn X9L6VbVqPuQk/J2TGCAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUu5-006MVl-1g; Mon, 16 May 2022 07:12:29 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUrm-006LNM-L9 for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 07:10:08 +0000 Received: by mail-lj1-x231.google.com with SMTP id l19so16966655ljb.7 for ; Mon, 16 May 2022 00:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sxWW7nN1MX4qR5x7vYWxWhZdhe/dlQM1wOVqJQxUPUw=; b=xfgSJvvTfpB3bhvG57n8DdOASbQWiiD0aJbEx2q9VQiFwTMWieLv+76CkJZ+U2n5nd SeLg+QQPZ6V0nSyPBqobwtFuUOpjjzJSoROqSiq2V7Lj9xLXR9XI2j8rJYfID1yZzMj8 XYC4vFiYINn/Pu0Kw38I6/ttfnhseJChXYkyHSKswuerj7YUKcUcoGx6WrX3zTuWbAFj BTqaz6IRcnWwUweLAZORhNAjK8LbQDIP25u3i0mgFmyuV3xVI+3yddr0b/HTBSLyGUff JthW+Y2HVfZJFRs03mpTS0HA5Y3waFMYbEb0YtBrM8ENx2y/t+3UVmH84hiaV9lxEk+f 7xOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sxWW7nN1MX4qR5x7vYWxWhZdhe/dlQM1wOVqJQxUPUw=; b=VTuk6QMgA2KeI4dsRpZMMbHepHZvd9dFAbOHGcRYUQK1S0rzhuef26REaWRuHBzxPQ JoMJkCwawvSDkGC5D7o0HE15eukHswgaNmInsr5Q4nti/qM3aJW56VxuXsL/4PTlh68/ cCE/y0+6hgDg8tRFBkd465+MuINFoxFCEQPHQeJDRAjdCMOH/2rDCPxnAkdS82L7eAMS jTrqylcCkOid2sY04PqcdPnE/r6MsRuDNfKkbnewzyVKnsSnu1ZQXYKNuPlzhEGlnFZE cWBo7+i3jHoVDkTndySJrZtWBYHG+9Okp/SfBiizEV76zhkNfps4nk5Wqn69zAQRTnTc BWZg== X-Gm-Message-State: AOAM5334RvsO4a7RmUUgkx6dFsY9dZeBAkWNGhxFPj78Z13U2hLD0sTz J81fX7kt8gh7wiM609EDmv9huw== X-Google-Smtp-Source: ABdhPJzxRNYsZvOCN6MRG+JxA+WtxP3xo+m55ow/RQL6xD2LzouYeDYYoKb2Omp9nqb+r+aHW9F1iA== X-Received: by 2002:a2e:bc14:0:b0:24f:5060:1dc3 with SMTP id b20-20020a2ebc14000000b0024f50601dc3mr10335364ljf.432.1652685003164; Mon, 16 May 2022 00:10:03 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o5-20020a05651205c500b004758e4e6a96sm1222932lfo.245.2022.05.16.00.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 00:10:02 -0700 (PDT) Message-ID: <03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org> Date: Mon, 16 May 2022 09:10:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs Content-Language: en-US To: AngeloGioacchino Del Regno , robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, paul.bouchara@somainline.org, kernel@collabora.com References: <20220513171617.504430-1-angelogioacchino.delregno@collabora.com> <20220513171617.504430-6-angelogioacchino.delregno@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220513171617.504430-6-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_001006_766242_4F4DE0A7 X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/05/2022 19:16, AngeloGioacchino Del Regno wrote: > Add the 32kHz and 26MHz oscillators as fixed clocks in devicetree to > provide a good initial clock spec, since this SoC features two always I don't understand that part with actual patch. You claim here you add clocks, but in DTS they were already before. Additionally, these clocks do not belong to DTSI because, AFAIU, these are properties of boards. At least their frequencies should be moved to the board DTS. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel