From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4669AC636D6 for ; Fri, 3 Feb 2023 09:14:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232559AbjBCJOe (ORCPT ); Fri, 3 Feb 2023 04:14:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232234AbjBCJOb (ORCPT ); Fri, 3 Feb 2023 04:14:31 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAA5B8E493 for ; Fri, 3 Feb 2023 01:14:29 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id t7so4040719wrp.5 for ; Fri, 03 Feb 2023 01:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zELjtTV++XT/mjyQzI4eKCIMRauhqYz1Nswt+m/xsqA=; b=mmPR3kx7UEfHJC//Zhap+s1dXSy6OV3TOeDHh94XUTQQmu4a6MifB/hHb3+B8e+w4+ FSQ+OaXhK35emD0S85DCCQNyOnCLXlh/SA2IfHg6e3i3Gm8gdWaf1URBGcNqcEpe1j0u RDNJ9N7srAEF3HAS7Q1E24mFyiuvLNQz2rZo98Z0nYFOwo4WZWCRbjM/T2Rwj7xPv8GP 7DMWL0hDOTs4pP9wYyvAlZ+r67eCt6+gluq+FHQ10g93KsCnJq5nKKBnie7uLrd9EWl4 LgkqktVSRK1hL/HmanJa0vVcUtiKy7rVFEaPbY+KhD9WOEOBJ749Q94G2Ln/ErGF0NKW CcKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zELjtTV++XT/mjyQzI4eKCIMRauhqYz1Nswt+m/xsqA=; b=3xquRNMeWDHiaa255eE0cBrTjwgH7BIonQIp+YhyX82RHbvf4jVEH3g7xr8BUG8EqW d8rz9Qo0fxUyaTpO9rlbjB4t1x+ExPGgVGpVDfRyRDm5Fmr68Xh86daxwAr2XroIdypM TrIosNMtuAl9KTi9BMxTpSZGQccsHhVgXRWRlp6BhdwQ8GZFGLFbrqWqDA2q39W2xYXx /1bt5+88BpsQPIjOKqcmRCzVxYO2hk5CzSixd4O2n2rRxOhF4X0Fgxx+ilC3ThhG9j2q yNWrwNP77dflC0/yyJu1ZUnRTbRALFWeE+RWE1fZN7148fEg84R/YgEq0qn1vmH/1emn dbZg== X-Gm-Message-State: AO0yUKWMTmkpB+YWgvaZ+PGQZ0zz+4e/xl9g5+ifBEX20Pfx5cePu1JJ sl6Oo7qUM/YCO9AoAfGhjdIiSQ== X-Google-Smtp-Source: AK7set87oB2xxUxR9AcQ7XrTUysuuK4UHjaKNMwCvPHLV1g1gyq7Z417h5UXoUYnn80RIACYH+l6Iw== X-Received: by 2002:adf:fc88:0:b0:2bf:d940:29b6 with SMTP id g8-20020adffc88000000b002bfd94029b6mr8415191wrr.54.1675415668346; Fri, 03 Feb 2023 01:14:28 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d8-20020adfe2c8000000b002bfe08c566fsm1510325wrj.106.2023.02.03.01.14.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 01:14:27 -0800 (PST) Message-ID: <03eeacfb-22ff-8224-30d7-6c187b179fd7@linaro.org> Date: Fri, 3 Feb 2023 10:14:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 5/6] clk: samsung: Extract parent clock enabling to common function Content-Language: en-US To: Sam Protsenko , Marek Szyprowski , Sylwester Nawrocki , Chanwoo Choi Cc: Tomasz Figa , Alim Akhtar , Chanho Park , David Virag , Sumit Semwal , Michael Turquette , Stephen Boyd , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230203060924.8257-1-semen.protsenko@linaro.org> <20230203060924.8257-6-semen.protsenko@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230203060924.8257-6-semen.protsenko@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2023 07:09, Sam Protsenko wrote: > Extract parent clock enabling from exynos_arm64_register_cmu() to > dedicated function. No functional change. > > No functional change. > > Signed-off-by: Sam Protsenko > --- > drivers/clk/samsung/clk-exynos-arm64.c | 53 +++++++++++++++++--------- > 1 file changed, 36 insertions(+), 17 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos-arm64.c b/drivers/clk/samsung/clk-exynos-arm64.c > index b921b9a1134a..361663223a24 100644 > --- a/drivers/clk/samsung/clk-exynos-arm64.c > +++ b/drivers/clk/samsung/clk-exynos-arm64.c > @@ -56,6 +56,41 @@ static void __init exynos_arm64_init_clocks(struct device_node *np, > iounmap(reg_base); > } > > +/** > + * exynos_arm64_enable_bus_clk - Enable parent clock of specified CMU > + * > + * @dev: Device object; may be NULL if this function is not being > + * called from platform driver probe function > + * @np: CMU device tree node > + * @cmu: CMU data > + * > + * Keep CMU parent clock running (needed for CMU registers access). > + * > + * Return: 0 on success or negative error code on failure. > + */ > +static int __init exynos_arm64_enable_bus_clk(struct device *dev, > + struct device_node *np, const struct samsung_cmu_info *cmu) Align the arguments. > +{ > + struct clk *parent_clk; > + > + if (!cmu->clk_name) > + return 0; > + > + if (dev) > + parent_clk = clk_get(dev, cmu->clk_name); > + else > + parent_clk = of_clk_get_by_name(np, cmu->clk_name); > + > + if (IS_ERR(parent_clk)) { > + pr_err("%s: could not find bus clock %s; err = %ld\n", > + __func__, cmu->clk_name, PTR_ERR(parent_clk)); > + return PTR_ERR(parent_clk); > + } > + > + clk_prepare_enable(parent_clk); > + return 0; You do not check the return value in exynos_arm64_register_cmu() below, so either make it a void or add the check. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EDEEC636CC for ; Fri, 3 Feb 2023 09:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=43ceuOGvFT+EJYsJsCkzZLa55hjmozwvUrNLT2uNYas=; b=PB4zKYA7U6zh0M gDQIYqMVok3ey6iT3Z9Xbix/o6zIIQLV+FMLuZnyD7bbvNxGoxLosngD5WrzYezi7zAu0PW/qSrc1 9Ggwk465GdDnw1CX6tWhyUPvifbLQmW3zz4S/LsrXrt6UOJ+q1+l6uOBAkuHUNUqOFxPm4+gq4mbp 1//4BvddduYXQLeAtIjQqlVdDdwOVoz3RK6iV+ztPMoZ+wuR1yiu5/ZGXqcYFku3cEvo+kVD8KnD3 cK6XcQcxl0VsacEKtH+oEvtVhOInCRi4Kt7HOXTTjJJe4Du3ow5v6avGKcORXOv5TJij7b1xX5waJ Yveg6bUmv7D9Q2eHA88w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNs9U-0017Ex-C9; Fri, 03 Feb 2023 09:14:36 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNs9Q-0017Dz-Em for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 09:14:33 +0000 Received: by mail-wr1-x42c.google.com with SMTP id a2so3755159wrd.6 for ; Fri, 03 Feb 2023 01:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zELjtTV++XT/mjyQzI4eKCIMRauhqYz1Nswt+m/xsqA=; b=mmPR3kx7UEfHJC//Zhap+s1dXSy6OV3TOeDHh94XUTQQmu4a6MifB/hHb3+B8e+w4+ FSQ+OaXhK35emD0S85DCCQNyOnCLXlh/SA2IfHg6e3i3Gm8gdWaf1URBGcNqcEpe1j0u RDNJ9N7srAEF3HAS7Q1E24mFyiuvLNQz2rZo98Z0nYFOwo4WZWCRbjM/T2Rwj7xPv8GP 7DMWL0hDOTs4pP9wYyvAlZ+r67eCt6+gluq+FHQ10g93KsCnJq5nKKBnie7uLrd9EWl4 LgkqktVSRK1hL/HmanJa0vVcUtiKy7rVFEaPbY+KhD9WOEOBJ749Q94G2Ln/ErGF0NKW CcKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zELjtTV++XT/mjyQzI4eKCIMRauhqYz1Nswt+m/xsqA=; b=LQKQ4Q7/lYIZA9L8S5p7Z+QHMAtFac8whpTABmz1Lu+jD8KuNGB2zyVC4g3E3eK0Qb uePb8UFygoe86ZAmKkM8It5+t2+2A8fCpfwyI6FPRoT0YdZeY4lhiiFJlxhM/j2sbpjv RzCTgWMBBXJSe769gbnyu5GrfkI2bSi1KuVsga/9dkXiJ5suc4qVNo+0cxShB6fUBVd4 Kb/phkxfspAbPNbpG1CoP9KUko0r72CIi6srwubCTNtNa4gPKPJi4DzvJh/pVMOAb+Xq sg5tA7PXXPI8f4GsXmbi85apTdzjzQdcOEux4t7QU9S6TWnZPoTRZCgz+Y4wKuDHA+YI aSUA== X-Gm-Message-State: AO0yUKV3iEPtoyGtTvORIKPhFyBO2tCjt7HP4OpGIcxkd1ldTE6UVZH2 nDvkXOMCZMc8liOS31W2dDVZYQ== X-Google-Smtp-Source: AK7set87oB2xxUxR9AcQ7XrTUysuuK4UHjaKNMwCvPHLV1g1gyq7Z417h5UXoUYnn80RIACYH+l6Iw== X-Received: by 2002:adf:fc88:0:b0:2bf:d940:29b6 with SMTP id g8-20020adffc88000000b002bfd94029b6mr8415191wrr.54.1675415668346; Fri, 03 Feb 2023 01:14:28 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d8-20020adfe2c8000000b002bfe08c566fsm1510325wrj.106.2023.02.03.01.14.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 01:14:27 -0800 (PST) Message-ID: <03eeacfb-22ff-8224-30d7-6c187b179fd7@linaro.org> Date: Fri, 3 Feb 2023 10:14:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 5/6] clk: samsung: Extract parent clock enabling to common function Content-Language: en-US To: Sam Protsenko , Marek Szyprowski , Sylwester Nawrocki , Chanwoo Choi Cc: Tomasz Figa , Alim Akhtar , Chanho Park , David Virag , Sumit Semwal , Michael Turquette , Stephen Boyd , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230203060924.8257-1-semen.protsenko@linaro.org> <20230203060924.8257-6-semen.protsenko@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230203060924.8257-6-semen.protsenko@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_011432_548962_97B70F17 X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/02/2023 07:09, Sam Protsenko wrote: > Extract parent clock enabling from exynos_arm64_register_cmu() to > dedicated function. No functional change. > > No functional change. > > Signed-off-by: Sam Protsenko > --- > drivers/clk/samsung/clk-exynos-arm64.c | 53 +++++++++++++++++--------- > 1 file changed, 36 insertions(+), 17 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos-arm64.c b/drivers/clk/samsung/clk-exynos-arm64.c > index b921b9a1134a..361663223a24 100644 > --- a/drivers/clk/samsung/clk-exynos-arm64.c > +++ b/drivers/clk/samsung/clk-exynos-arm64.c > @@ -56,6 +56,41 @@ static void __init exynos_arm64_init_clocks(struct device_node *np, > iounmap(reg_base); > } > > +/** > + * exynos_arm64_enable_bus_clk - Enable parent clock of specified CMU > + * > + * @dev: Device object; may be NULL if this function is not being > + * called from platform driver probe function > + * @np: CMU device tree node > + * @cmu: CMU data > + * > + * Keep CMU parent clock running (needed for CMU registers access). > + * > + * Return: 0 on success or negative error code on failure. > + */ > +static int __init exynos_arm64_enable_bus_clk(struct device *dev, > + struct device_node *np, const struct samsung_cmu_info *cmu) Align the arguments. > +{ > + struct clk *parent_clk; > + > + if (!cmu->clk_name) > + return 0; > + > + if (dev) > + parent_clk = clk_get(dev, cmu->clk_name); > + else > + parent_clk = of_clk_get_by_name(np, cmu->clk_name); > + > + if (IS_ERR(parent_clk)) { > + pr_err("%s: could not find bus clock %s; err = %ld\n", > + __func__, cmu->clk_name, PTR_ERR(parent_clk)); > + return PTR_ERR(parent_clk); > + } > + > + clk_prepare_enable(parent_clk); > + return 0; You do not check the return value in exynos_arm64_register_cmu() below, so either make it a void or add the check. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel