From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8418FC2B9F4 for ; Thu, 17 Jun 2021 07:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5569160724 for ; Thu, 17 Jun 2021 07:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbhFQHpb (ORCPT ); Thu, 17 Jun 2021 03:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbhFQHp3 (ORCPT ); Thu, 17 Jun 2021 03:45:29 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E091AC061574 for ; Thu, 17 Jun 2021 00:43:21 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1ltmgB-007xZi-EJ; Thu, 17 Jun 2021 09:43:11 +0200 Message-ID: <03ef297b35b87ed8f3c111cf7e67592b1c8e29a9.camel@sipsolutions.net> Subject: Re: [PATCH 11/12] iwlwifi: pcie: remove TR/CR tail allocations From: Johannes Berg To: Luca Coelho , kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Thu, 17 Jun 2021 09:43:09 +0200 In-Reply-To: (sfid-20210617_091102_610763_E92F4BD5) References: <20210617070852.496985-1-luca@coelho.fi> (sfid-20210617_091102_610763_E92F4BD5) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2021-06-17 at 10:08 +0300, Luca Coelho wrote: > From: Johannes Berg > > The TR/CR tail data are meant to be per-queue-arrays, however, > we allocate them completely wrong (we have a separate allocation > per queue). > > Looking at this more closely, it turns out that the hardware > never uses these - we have a separate free list per RX queue > and maintain a write pointer for that in a register, and the > RX itself is indicated in the RB status (rb_stts) DMA region. > > Therefore, remove the TR/CR tail allocations completely. I guess you should've updated the commit message when squashing in the fix here - we do need to give it dummy pointers, and the hardware *does* use them, just for no relevant purpose :) johannes