From: Stefan Metzmacher <metze@samba.org>
To: Paulo Alcantara <pc@cjr.nz>,
linux-cifs@vger.kernel.org, smfrench@gmail.com
Subject: Re: [PATCH 1/7] cifs: merge __{cifs,smb2}_reconnect[_tcon]() into cifs_tree_connect()
Date: Mon, 6 Jul 2020 17:36:27 +0200 [thread overview]
Message-ID: <03f472c0-3c36-a28d-41bc-5b064b4ea16f@samba.org> (raw)
In-Reply-To: <20200706152402.5721-2-pc@cjr.nz>
[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]
Hi Paulo,
> + if (tcon->ipc) {
> + scnprintf(tree, MAX_TREE_SIZE, "\\\\%s\\IPC$", share);
> + rc = ops->tree_connect(xid, tcon->ses, tree, tcon, nlsc);
> + } else {
> + scnprintf(tree, MAX_TREE_SIZE, "\\%s", share);
> + rc = ops->tree_connect(xid, tcon->ses, tree, tcon, nlsc);
> + if (!rc) {
> + rc = update_super_prepath(tcon, prefix, prefix_len);
> + break;
> + }
> + }
The original code used:
- scnprintf(tree, MAX_TREE_SIZE, "\\%.*s", (int)share_len,
- share);
So it's no longer identical.
Was the share_len code added after my initial patch?
metze
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-06 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 15:23 [PATCH 0/7] DFS fixes Paulo Alcantara
2020-07-06 15:23 ` [PATCH 1/7] cifs: merge __{cifs,smb2}_reconnect[_tcon]() into cifs_tree_connect() Paulo Alcantara
2020-07-06 15:36 ` Stefan Metzmacher [this message]
2020-07-06 15:47 ` Paulo Alcantara
2020-07-06 16:45 ` Paulo Alcantara
2020-07-06 15:23 ` [PATCH 2/7] cifs: reduce number of referral requests in DFS link lookups Paulo Alcantara
2020-07-06 15:23 ` [PATCH 3/7] cifs: rename reconn_inval_dfs_target() Paulo Alcantara
2020-07-06 15:23 ` [PATCH 4/7] cifs: handle empty list of targets in cifs_reconnect() Paulo Alcantara
2020-07-06 15:24 ` [PATCH 5/7] cifs: handle RESP_GET_DFS_REFERRAL.PathConsumed in reconnect Paulo Alcantara
2020-07-06 15:24 ` [PATCH 6/7] cifs: only update prefix path of DFS links in cifs_tree_connect() Paulo Alcantara
2020-07-06 15:24 ` [PATCH 7/7] cifs: document and cleanup dfs mount Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03f472c0-3c36-a28d-41bc-5b064b4ea16f@samba.org \
--to=metze@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.