From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA490C433EF for ; Mon, 31 Jan 2022 23:26:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbiAaX0b (ORCPT ); Mon, 31 Jan 2022 18:26:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55609 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiAaX01 (ORCPT ); Mon, 31 Jan 2022 18:26:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643671587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YoObquMC1Y099gjHiKrPd1NW4/MPXx5uArpEcPqAfgo=; b=VVr29UUdx1lqKW/nLDNwf+jjbd38eWgo/+pSACB28biIvM/Qz5waoH8xr74g3QCEStRN+Y ma8ErgoqQphvJMDz18uyi0aHz05kCBDWjvlwEgbNcdJcUaWqmXkxZtDr58wMYDCGRXP8Bi Jy0rh6D43AJ15rcnvyvUSe4+GvPn+tk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-_z7Y6qOTPQarSeqrXQ7q5Q-1; Mon, 31 Jan 2022 18:26:24 -0500 X-MC-Unique: _z7Y6qOTPQarSeqrXQ7q5Q-1 Received: by mail-wm1-f69.google.com with SMTP id o194-20020a1ca5cb000000b00350b177fb22so436027wme.3 for ; Mon, 31 Jan 2022 15:26:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YoObquMC1Y099gjHiKrPd1NW4/MPXx5uArpEcPqAfgo=; b=qYSkVVZz6fyXaSTyHJKOZuLJEN/WNZbxAdcZ1r0Z0677HB3rivcdLit9wGUt0Xa+7M DxBJSBg4cSeAj/+mjwfZsr5DN2+tAg5yqNGwEQHE/qbOcFZQbu01E1NefV+/srFXnF1g W0wjCXoroT2XrAWouSd+rJ8vcuxjb99POi+gTXC9Xnvz8SdHMcAhQn/jV/h7TO93VBMO mRDsrqnWTYVXkZUqQI1EwhHWX++24zLDI8JX53RVnFxnn8S0LeB+pJPpndVAvnXw6CbU Y2XCGm9fKQ/dFy+T1rEUID0OpPG5XLwrJ8fJZVnDDo8l5/T/uoLw2WHManZzpCovc3Z+ rfMQ== X-Gm-Message-State: AOAM530vwlNMKd14HlHrGOAXXuVcyOQpJY1tGWHG4uhzr6Dsx5DcNUXR A1H3igr3g24mChhBIVeFWfhmiBMWwAylstuWsSMi/C+3HqsGlslvKuFnomJ+QgrpIP0RuATOlBo 8gxebrZNQOgflwvR3z1uhkHXj X-Received: by 2002:a1c:440a:: with SMTP id r10mr20863796wma.142.1643671583665; Mon, 31 Jan 2022 15:26:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvDyBUYLTU/L1b51CS4uxvaGJqLeLCo2c7D1CjSfutkqldhTLTiY2yHFXAdgxPYSuz6ErDnQ== X-Received: by 2002:a1c:440a:: with SMTP id r10mr20863790wma.142.1643671583508; Mon, 31 Jan 2022 15:26:23 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id h4sm15500586wre.0.2022.01.31.15.26.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 15:26:23 -0800 (PST) Message-ID: <03ffaaa6-1a8c-68fa-dd17-1e6d0e1e4868@redhat.com> Date: Tue, 1 Feb 2022 00:26:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/4] drm: Add I2C connector type Content-Language: en-US To: Sam Ravnborg Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Geert Uytterhoeven , Maxime Ripard , Andy Shevchenko References: <20220131201225.2324984-1-javierm@redhat.com> <20220131201225.2324984-2-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/22 21:52, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >> There isn't a connector type for display controllers accesed through I2C, >> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL. >> >> Add an I2C connector type to match the actual connector. >> >> As Noralf Trønnes mentions in commit fc06bf1d76d6 ("drm: Add SPI connector >> type"), user-space should be able to cope with a connector type that does >> not yet understand. >> >> Tested with `modetest -M ssd1307 -c` and shows the connector as unknown-1. > I had expected unknown-21?? > As you pointed out in patch 3/4, I forgot to change DRM_MODE_CONNECTOR_Unknown to DRM_MODE_CONNECTOR_I2C after adding this patch... >> >> Signed-off-by: Javier Martinez Canillas > Reviewed-by: Sam Ravnborg >> --- Thanks! Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AC35C433FE for ; Mon, 31 Jan 2022 23:26:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DE6010E451; Mon, 31 Jan 2022 23:26:31 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 187B910E452 for ; Mon, 31 Jan 2022 23:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643671588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YoObquMC1Y099gjHiKrPd1NW4/MPXx5uArpEcPqAfgo=; b=SPVXVCFRbu3o/BAfrB9eB/IIHLwWnrBtM8ghgKXoWRx2qWbax/mDf4einrW/uWbzAzZTVD BaYC7XtxARL1BCviJFXzaDcm3xAALKODHhKN4P0xkgXhVT9ihtHTUW0YE58qb2/HT0vwo4 jX7dvSrTmpnLl9fHi/74lJ4HpJsBxZ0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-_fDyQPbsORKwumD5BIoivA-1; Mon, 31 Jan 2022 18:26:24 -0500 X-MC-Unique: _fDyQPbsORKwumD5BIoivA-1 Received: by mail-wm1-f71.google.com with SMTP id n7-20020a1c7207000000b0034ec3d8ce0aso275714wmc.8 for ; Mon, 31 Jan 2022 15:26:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YoObquMC1Y099gjHiKrPd1NW4/MPXx5uArpEcPqAfgo=; b=xspUdDRUC0c7HCdd79PM0a1kqTeF/LRGzabvTheECkQP17bY//xbt2pMCXWa0KelK6 c5DyX4HUBHZayG68XX3rkKMspUkWmZJzhblerOF7R5TgtW4g7StVmx3qjlSa43QZXUcf hZURaM3YtmkcQclcvnH03NaZf73ZPX2oeqXHiYMgCTUjtXVORKNhmCtHVaVRjVYhXvX7 sm6qEFy9wmvomd+2fBhhqrm8oQI2t4QUUlC9sEr+cEnrt4I+u9mzO2xJe020ClALSMiL RyDCTnIDahlpiPkdMRL+tXTqTESHHJ3HAlvIFn53LNB2qqhJCaC6Uur6JPDjTAlj1lGy n1ZA== X-Gm-Message-State: AOAM530KJ4oMnjfTB4TlvRIl169+bAgttrJOlrUc15LJEUNQEO0XQ68F rLNcg1rErlTE6kdlIgS6qTrdXor4gGrupscTpcoQRzXQ8VqAMT+K9+xM5KLuiZR+JJT0e1VdYUF hp8eLYJGNqiF1uve9yZ7W8tZw51zW X-Received: by 2002:a1c:440a:: with SMTP id r10mr20863798wma.142.1643671583666; Mon, 31 Jan 2022 15:26:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvDyBUYLTU/L1b51CS4uxvaGJqLeLCo2c7D1CjSfutkqldhTLTiY2yHFXAdgxPYSuz6ErDnQ== X-Received: by 2002:a1c:440a:: with SMTP id r10mr20863790wma.142.1643671583508; Mon, 31 Jan 2022 15:26:23 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id h4sm15500586wre.0.2022.01.31.15.26.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 15:26:23 -0800 (PST) Message-ID: <03ffaaa6-1a8c-68fa-dd17-1e6d0e1e4868@redhat.com> Date: Tue, 1 Feb 2022 00:26:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/4] drm: Add I2C connector type To: Sam Ravnborg References: <20220131201225.2324984-1-javierm@redhat.com> <20220131201225.2324984-2-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Geert Uytterhoeven , Maxime Ripard , Thomas Zimmermann , Andy Shevchenko Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/31/22 21:52, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >> There isn't a connector type for display controllers accesed through I2C, >> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL. >> >> Add an I2C connector type to match the actual connector. >> >> As Noralf Trønnes mentions in commit fc06bf1d76d6 ("drm: Add SPI connector >> type"), user-space should be able to cope with a connector type that does >> not yet understand. >> >> Tested with `modetest -M ssd1307 -c` and shows the connector as unknown-1. > I had expected unknown-21?? > As you pointed out in patch 3/4, I forgot to change DRM_MODE_CONNECTOR_Unknown to DRM_MODE_CONNECTOR_I2C after adding this patch... >> >> Signed-off-by: Javier Martinez Canillas > Reviewed-by: Sam Ravnborg >> --- Thanks! Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat