From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13438C11F68 for ; Fri, 2 Jul 2021 13:12:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE33161413 for ; Fri, 2 Jul 2021 13:12:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE33161413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A64F6E17E; Fri, 2 Jul 2021 13:12:37 +0000 (UTC) Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [IPv6:2a01:e0c:1:1599::14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70CC26E17C; Fri, 2 Jul 2021 13:12:35 +0000 (UTC) Received: from [192.168.1.190] (unknown [91.155.165.229]) (Authenticated sender: martin.peres@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 9332E5FF3F; Fri, 2 Jul 2021 15:12:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1625231554; bh=vKUM2f1Cw/W/uNwyZOwCq0u1SM1S7vnk+jenXPOPh3c=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MA3M9rghZtdIeCSraQN7EgQdKLPUoH0cqhwwEDs5p4+hDQjPV+fhIafFJzPvohke5 /KCriOnAzznOlrkGjkl0Eo1cjVRvCu5TntcPu3HOxNUlQ2AGvW5nfDx+KQSp7f8idA Q9wJiEc+yoi0G7EbIrr8k7corACi+PYNP48l+05k5/F6a0Zqc6A9ApCHO4nt3wRneC 3dkWX6e8QEItoCJ91zvvk+b13SOYs50s6VnsX4THWVbf5x/dhQIfosnq2cRM8etbqd WZja12cglcWEoqHcSRf6f7qw+tDUwcxSbnOLQRTjFtXQ8j+L6Q/kMDn/19N3Oork29 YIT/lPYcGPd7A== Subject: Re: [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+ To: Michal Wajdeczko , Matthew Brost References: <20210624070516.21893-1-matthew.brost@intel.com> <20210624070516.21893-48-matthew.brost@intel.com> <88cbe963-7188-f4ae-5acf-01a80bd2fe25@free.fr> <20210630180052.GA8283@sdutt-i7> <7c3e1d46-74eb-6f2d-53ca-d73ce9e61c03@free.fr> <2d649c1a-82fc-cced-4020-f7d9d96c3bc4@intel.com> From: Martin Peres Message-ID: <040272cf-cbd5-73ef-c763-71948474be82@free.fr> Date: Fri, 2 Jul 2021 16:12:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <2d649c1a-82fc-cced-4020-f7d9d96c3bc4@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, daniele.ceraolospurio@intel.com, john.c.harrison@intel.com, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 02/07/2021 16:06, Michal Wajdeczko wrote: > > > On 02.07.2021 10:13, Martin Peres wrote: >> On 01/07/2021 21:24, Martin Peres wrote: >> [...] >>>> >>>>> >>>>>> +        i915->params.enable_guc = ENABLE_GUC_LOAD_HUC; >>>>>> +        return; >>>>>> +    } >>>>>> + >>>>>> +    /* Default: enable HuC authentication and GuC submission */ >>>>>> +    i915->params.enable_guc = ENABLE_GUC_LOAD_HUC | >>>>>> ENABLE_GUC_SUBMISSION; >>>>> >>>>> This seems to be in contradiction with the GuC submission plan which >>>>> states: >>>>> >>>>> "Not enabled by default on any current platforms but can be enabled via >>>>> modparam enable_guc". >>>>> >>>> >>>> I don't believe any current platform gets this point where GuC >>>> submission would be enabled by default. The first would be ADL-P which >>>> isn't out yet. >>> >>> Isn't that exactly what the line above does? >> >> In case you missed this crucial part of the review. Please answer the >> above question. > > I guess there is some misunderstanding here, and I must admit I had > similar doubt, but if you look beyond patch diff and check function code > you will find that the very condition is: > > /* Don't enable GuC/HuC on pre-Gen12 */ > if (GRAPHICS_VER(i915) < 12) { > i915->params.enable_guc = 0; > return; > } > > so all pre-Gen12 platforms will continue to have GuC/HuC disabled. Thanks Michal, but then the problem is the other way: how can one enable it on gen11? I like what Daniele was going for here: separating the capability from the user-requested value, but then it seems the patch stopped half way. How about never touching the parameter, and having a AND between the two values to get the effective enable_guc? Right now, the code is really confusing :s Thanks, Martin > > Thanks, > Michal > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90EE8C11F68 for ; Fri, 2 Jul 2021 13:12:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3082761413 for ; Fri, 2 Jul 2021 13:12:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3082761413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D58206E17C; Fri, 2 Jul 2021 13:12:36 +0000 (UTC) Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [IPv6:2a01:e0c:1:1599::14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70CC26E17C; Fri, 2 Jul 2021 13:12:35 +0000 (UTC) Received: from [192.168.1.190] (unknown [91.155.165.229]) (Authenticated sender: martin.peres@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 9332E5FF3F; Fri, 2 Jul 2021 15:12:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1625231554; bh=vKUM2f1Cw/W/uNwyZOwCq0u1SM1S7vnk+jenXPOPh3c=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MA3M9rghZtdIeCSraQN7EgQdKLPUoH0cqhwwEDs5p4+hDQjPV+fhIafFJzPvohke5 /KCriOnAzznOlrkGjkl0Eo1cjVRvCu5TntcPu3HOxNUlQ2AGvW5nfDx+KQSp7f8idA Q9wJiEc+yoi0G7EbIrr8k7corACi+PYNP48l+05k5/F6a0Zqc6A9ApCHO4nt3wRneC 3dkWX6e8QEItoCJ91zvvk+b13SOYs50s6VnsX4THWVbf5x/dhQIfosnq2cRM8etbqd WZja12cglcWEoqHcSRf6f7qw+tDUwcxSbnOLQRTjFtXQ8j+L6Q/kMDn/19N3Oork29 YIT/lPYcGPd7A== To: Michal Wajdeczko , Matthew Brost References: <20210624070516.21893-1-matthew.brost@intel.com> <20210624070516.21893-48-matthew.brost@intel.com> <88cbe963-7188-f4ae-5acf-01a80bd2fe25@free.fr> <20210630180052.GA8283@sdutt-i7> <7c3e1d46-74eb-6f2d-53ca-d73ce9e61c03@free.fr> <2d649c1a-82fc-cced-4020-f7d9d96c3bc4@intel.com> From: Martin Peres Message-ID: <040272cf-cbd5-73ef-c763-71948474be82@free.fr> Date: Fri, 2 Jul 2021 16:12:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <2d649c1a-82fc-cced-4020-f7d9d96c3bc4@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gMDIvMDcvMjAyMSAxNjowNiwgTWljaGFsIFdhamRlY3prbyB3cm90ZToKPiAKPiAKPiBPbiAw Mi4wNy4yMDIxIDEwOjEzLCBNYXJ0aW4gUGVyZXMgd3JvdGU6Cj4+IE9uIDAxLzA3LzIwMjEgMjE6 MjQsIE1hcnRpbiBQZXJlcyB3cm90ZToKPj4gWy4uLl0KPj4+Pgo+Pj4+Pgo+Pj4+Pj4gK8KgwqDC oMKgwqDCoMKgIGk5MTUtPnBhcmFtcy5lbmFibGVfZ3VjID0gRU5BQkxFX0dVQ19MT0FEX0hVQzsK Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm47Cj4+Pj4+PiArwqDCoMKgIH0KPj4+Pj4+ICsK Pj4+Pj4+ICvCoMKgwqAgLyogRGVmYXVsdDogZW5hYmxlIEh1QyBhdXRoZW50aWNhdGlvbiBhbmQg R3VDIHN1Ym1pc3Npb24gKi8KPj4+Pj4+ICvCoMKgwqAgaTkxNS0+cGFyYW1zLmVuYWJsZV9ndWMg PSBFTkFCTEVfR1VDX0xPQURfSFVDIHwKPj4+Pj4+IEVOQUJMRV9HVUNfU1VCTUlTU0lPTjsKPj4+ Pj4KPj4+Pj4gVGhpcyBzZWVtcyB0byBiZSBpbiBjb250cmFkaWN0aW9uIHdpdGggdGhlIEd1QyBz dWJtaXNzaW9uIHBsYW4gd2hpY2gKPj4+Pj4gc3RhdGVzOgo+Pj4+Pgo+Pj4+PiAiTm90IGVuYWJs ZWQgYnkgZGVmYXVsdCBvbiBhbnkgY3VycmVudCBwbGF0Zm9ybXMgYnV0IGNhbiBiZSBlbmFibGVk IHZpYQo+Pj4+PiBtb2RwYXJhbSBlbmFibGVfZ3VjIi4KPj4+Pj4KPj4+Pgo+Pj4+IEkgZG9uJ3Qg YmVsaWV2ZSBhbnkgY3VycmVudCBwbGF0Zm9ybSBnZXRzIHRoaXMgcG9pbnQgd2hlcmUgR3VDCj4+ Pj4gc3VibWlzc2lvbiB3b3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQuIFRoZSBmaXJzdCB3b3Vs ZCBiZSBBREwtUCB3aGljaAo+Pj4+IGlzbid0IG91dCB5ZXQuCj4+Pgo+Pj4gSXNuJ3QgdGhhdCBl eGFjdGx5IHdoYXQgdGhlIGxpbmUgYWJvdmUgZG9lcz8KPj4KPj4gSW4gY2FzZSB5b3UgbWlzc2Vk IHRoaXMgY3J1Y2lhbCBwYXJ0IG9mIHRoZSByZXZpZXcuIFBsZWFzZSBhbnN3ZXIgdGhlCj4+IGFi b3ZlIHF1ZXN0aW9uLgo+IAo+IEkgZ3Vlc3MgdGhlcmUgaXMgc29tZSBtaXN1bmRlcnN0YW5kaW5n IGhlcmUsIGFuZCBJIG11c3QgYWRtaXQgSSBoYWQKPiBzaW1pbGFyIGRvdWJ0LCBidXQgaWYgeW91 IGxvb2sgYmV5b25kIHBhdGNoIGRpZmYgYW5kIGNoZWNrIGZ1bmN0aW9uIGNvZGUKPiB5b3Ugd2ls bCBmaW5kIHRoYXQgdGhlIHZlcnkgY29uZGl0aW9uIGlzOgo+IAo+IAkvKiBEb24ndCBlbmFibGUg R3VDL0h1QyBvbiBwcmUtR2VuMTIgKi8KPiAJaWYgKEdSQVBISUNTX1ZFUihpOTE1KSA8IDEyKSB7 Cj4gCQlpOTE1LT5wYXJhbXMuZW5hYmxlX2d1YyA9IDA7Cj4gCQlyZXR1cm47Cj4gCX0KPiAKPiBz byBhbGwgcHJlLUdlbjEyIHBsYXRmb3JtcyB3aWxsIGNvbnRpbnVlIHRvIGhhdmUgR3VDL0h1QyBk aXNhYmxlZC4KClRoYW5rcyBNaWNoYWwsIGJ1dCB0aGVuIHRoZSBwcm9ibGVtIGlzIHRoZSBvdGhl ciB3YXk6IGhvdyBjYW4gb25lIGVuYWJsZSAKaXQgb24gZ2VuMTE/CgpJIGxpa2Ugd2hhdCBEYW5p ZWxlIHdhcyBnb2luZyBmb3IgaGVyZTogc2VwYXJhdGluZyB0aGUgY2FwYWJpbGl0eSBmcm9tIAp0 aGUgdXNlci1yZXF1ZXN0ZWQgdmFsdWUsIGJ1dCB0aGVuIGl0IHNlZW1zIHRoZSBwYXRjaCBzdG9w cGVkIGhhbGYgd2F5LiAKSG93IGFib3V0IG5ldmVyIHRvdWNoaW5nIHRoZSBwYXJhbWV0ZXIsIGFu ZCBoYXZpbmcgYSBBTkQgYmV0d2VlbiB0aGUgdHdvIAp2YWx1ZXMgdG8gZ2V0IHRoZSBlZmZlY3Rp dmUgZW5hYmxlX2d1Yz8KClJpZ2h0IG5vdywgdGhlIGNvZGUgaXMgcmVhbGx5IGNvbmZ1c2luZyA6 cwoKVGhhbmtzLApNYXJ0aW4KCj4gCj4gVGhhbmtzLAo+IE1pY2hhbAo+IApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK