From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 085B4C282DA for ; Fri, 19 Apr 2019 19:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF05F20693 for ; Fri, 19 Apr 2019 19:23:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dWrkmgQO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727818AbfDSTXv (ORCPT ); Fri, 19 Apr 2019 15:23:51 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46822 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbfDSTXv (ORCPT ); Fri, 19 Apr 2019 15:23:51 -0400 Received: by mail-pf1-f195.google.com with SMTP id 9so2919295pfj.13 for ; Fri, 19 Apr 2019 12:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+ZJAfgpmspc/IbA2GWTmuoa4sF7Gk0ivH/wq1l6Kkjc=; b=dWrkmgQOXbB1kA0OmvDBB32XbHG1mk03jLcGPFtL4h0if2J1Tg+3N9TNAzoUTAr35A AxHVk8mIyvdhWIaZWIsKM8Vl7YY8wMACyzYnPkYyxcOowe7ACy+zp6szukgjnTHL2lAB osZkQpK4MCLweD7eX/kDmY6sUjecUK9emoT3sIMVv+ITz4TPZr4MNmw/XRH4TafSuuAJ P5e5dKZyhoKi0YK3NNxpYqbaof3yCgp1t8ee9MKMHTmeQqDKp3oGvEHJEptB3s+/b/3S mWx1l6fIPuy7k6aHYnfRm33BCklxZuFw06+4jamuewkNvAsABalKTK8CM8xWCTBZGR/m WLEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+ZJAfgpmspc/IbA2GWTmuoa4sF7Gk0ivH/wq1l6Kkjc=; b=RG2PXFnG0mMr8Xl1ZqoVWZNp41w91iGMJ27gUOYCOzEiFi0tsv9lBx+ue5FJ1PpYQU 0FecOmIFdYxC2LPrVPUQI5bOgHlPGNtVUcbewt+SdvF2x5XKfKtgQGZJ7ERcVOMAb7I6 j9c6Pm7BOpchQOhIIeVDlDoqz3H8REtsd9BOYbPLX4+IpPMUrIxlWByQy0yemfoVJmvT RW5xLDo5A6PJQiHHDqcS/iMY6QyBNGHjzVP58MpX3KNjh9Z0C43sUTKWKojOQOXbbH6E FSMkJ9c3V9zPvEY26MW2qFpH6b20uHEWLhGnb9+8ws4RYZIJxoHAsee6EgSMVTyUEjem apuQ== X-Gm-Message-State: APjAAAUhUHnNid4IJ/LViDU+u0azOZ6ZkDvW8x6jLeBxB+EpdbhUIK6D v0fqxdOxk6/pyv51PYMaU0/6vIwx X-Google-Smtp-Source: APXvYqypWCbiH2qnU3T7cfStYx/lK7bKBm7UIg/YCKQrZ/Rj9ZWSBh0E2txeGUGzhFWs2MPHPBqQ2w== X-Received: by 2002:aa7:8589:: with SMTP id w9mr4554251pfn.97.1555687859451; Fri, 19 Apr 2019 08:30:59 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id i2sm7853467pfo.9.2019.04.19.08.30.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 08:30:58 -0700 (PDT) Subject: Re: [PATCH net-next 08/15] dsa: Keep link list of tag drivers To: Andrew Lunn , David Miller Cc: netdev , Vivien Didelot References: <20190418023120.17067-1-andrew@lunn.ch> <20190418023120.17067-9-andrew@lunn.ch> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <041a9797-422a-a67a-55e9-692e9c166065@gmail.com> Date: Fri, 19 Apr 2019 08:30:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418023120.17067-9-andrew@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/17/2019 7:31 PM, Andrew Lunn wrote: > Let the tag drivers register themselves with the DSA core, keeping > them in a linked list. > > Signed-off-by: Andrew Lunn > --- [snip] > int dsa_tag_drivers_register(struct dsa_device_ops *ops[], > unsigned int count, struct module *owner) > { > - return 0; > + int err, i; > + > + for (i = 0; i < count; i++) { count is unsigned, so i should also be unsigned. > + err = dsa_tag_driver_register(ops[i], owner); > + if (err) > + break; > + } > + > + return err; > +} > + > +static void dsa_tag_driver_unregister(struct dsa_device_ops *ops) > +{ > + mutex_lock(&dsa_tag_drivers_lock); > + list_del(&ops->list); > + mutex_unlock(&dsa_tag_drivers_lock); > } > EXPORT_SYMBOL_GPL(dsa_tag_drivers_register); > > void dsa_tag_drivers_unregister(struct dsa_device_ops *ops[], > unsigned int count) > { > + int i; > + > + for (i = 0; i < count; i++) > + dsa_tag_driver_unregister(ops[i]); Likewise. -- Florian