From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEJkU-0002Gm-7F for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:28:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEJkO-0002ur-7c for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:28:14 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) From: Alexander Graf In-Reply-To: <29955D3C-89BD-4C74-92BF-788A5B9CD327@suse.de> Date: Fri, 14 Feb 2014 15:28:03 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <04230209-AD69-43B7-9E70-89FCF6CC72A6@suse.de> References: <1390896003-3195-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1392260368-24016-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20140213114029.6587ee8d@bahia.local> <71AA6BC5-3F77-43A4-A902-B2F724B688D3@suse.de> <65865B05-B9F6-46D9-9CB7-7F5AB4B32015@suse.de> <29955D3C-89BD-4C74-92BF-788A5B9CD327@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Paul Mackerras , "list@suse.de:PowerPC" , "Aneesh Kumar K.V" , QEMU Developers On 14.02.2014, at 14:54, Alexander Graf wrote: >=20 > On 14.02.2014, at 14:06, Alexander Graf wrote: >=20 >>=20 >> On 13.02.2014, at 15:51, Alexander Graf wrote: >>=20 >>>=20 >>> On 13.02.2014, at 11:40, Greg Kurz wrote: >>>=20 >>>> On Thu, 13 Feb 2014 08:29:28 +0530 >>>> "Aneesh Kumar K.V" wrote: >>>>=20 >>>>> From: "Aneesh Kumar K.V" >>>>>=20 >>>>> Correctly update the htab_mask using the return value of >>>>> KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 >>>>> on GET_SREGS for HV. We check for external htab and if >>>>> found true, we don't need to update sdr1 >>>>>=20 >>>>> Signed-off-by: Aneesh Kumar K.V >>>>=20 >>>> Reviewed-by: Greg Kurz >>>>=20 >>>>> --- >>>>> Changes from V9: >>>>> * Fix TCG breakage >>>>>=20 >>>>=20 >>>> Alex, >>>>=20 >>>> This patch is a complete replacement for commit 1df2d6d900a9 in = your >>>> ppc-next branch. >>>>=20 >>>> Please apply so that TCG works again ! :) >>>=20 >>> Thanks, applied to ppc-next. >>=20 >> With this patch applied -M pseries fails to boot a kernel for me. >=20 > -M mac99 also fails miserably. It almost looks as if the mask cuts off = some bits, but please investigate this yourself. I'll remove the patch = from the queue meanwhile. Sigh, this whole series is just way too broken. I'll remove everything = as of this patch from my queue. Aneesh, please rework the HTAB = load/store patches and make sure that - TCG works - -M mac99 works - 32bit guest works - 32bit host works (casts!) Then we can talk about applying them again. Alex