From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE8CC352A2 for ; Fri, 7 Feb 2020 13:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8785620720 for ; Fri, 7 Feb 2020 13:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbgBGNQR (ORCPT ); Fri, 7 Feb 2020 08:16:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:58010 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbgBGNQR (ORCPT ); Fri, 7 Feb 2020 08:16:17 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 55727AD55; Fri, 7 Feb 2020 13:16:15 +0000 (UTC) Subject: Re: [PATCH] drm/cirrus: add drm_driver.release callback. To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Dave Airlie References: <20200207121345.25639-1-kraxel@redhat.com> From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= mQENBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAG0J1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPokBVAQTAQgAPhYh BHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEGgNwR1TC3ojR80H/jH+vYavwQ+TvO8ksXL9JQWc3IFSiGpuSVXLCdg62AmR irxW+qCwNncNQyb9rd30gzdectSkPWL3KSqEResBe24IbA5/jSkPweJasgXtfhuyoeCJ6PXo clQQGKIoFIAEv1s8l0ggPZswvCinegl1diyJXUXmdEJRTWYAtxn/atut1o6Giv6D2qmYbXN7 mneMC5MzlLaJKUtoH7U/IjVw1sx2qtxAZGKVm4RZxPnMCp9E1MAr5t4dP5gJCIiqsdrVqI6i KupZstMxstPU//azmz7ZWWxT0JzgJqZSvPYx/SATeexTYBP47YFyri4jnsty2ErS91E6H8os Bv6pnSn7eAq5AQ0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRH UE9eosYbT6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgT RjP+qbU63Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+R dhgATnWWGKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zb ehDda8lvhFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r 12+lqdsAEQEAAYkBPAQYAQgAJhYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsMBQkD wmcAAAoJEGgNwR1TC3ojpfcIAInwP5OlcEKokTnHCiDTz4Ony4GnHRP2fXATQZCKxmu4AJY2 h9ifw9Nf2TjCZ6AMvC3thAN0rFDj55N9l4s1CpaDo4J+0fkrHuyNacnT206CeJV1E7NYntxU n+LSiRrOdywn6erjxRi9EYTVLCHcDhBEjKmFZfg4AM4GZMWX1lg0+eHbd5oL1as28WvvI/uI aMyV8RbyXot1r/8QLlWldU3NrTF5p7TMU2y3ZH2mf5suSKHAMtbE4jKJ8ZHFOo3GhLgjVrBW HE9JXO08xKkgD+w6v83+nomsEuf6C6LYrqY/tsZvyEX6zN8CtirPdPWu/VXNRYAl/lat7lSI 3H26qrE= Message-ID: <04253f60-c374-6eb1-53e9-fff2299658cd@suse.de> Date: Fri, 7 Feb 2020 14:16:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200207121345.25639-1-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k Content-Type: multipart/mixed; boundary="0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Dave Airlie Message-ID: <04253f60-c374-6eb1-53e9-fff2299658cd@suse.de> Subject: Re: [PATCH] drm/cirrus: add drm_driver.release callback. References: <20200207121345.25639-1-kraxel@redhat.com> In-Reply-To: <20200207121345.25639-1-kraxel@redhat.com> --0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 07.02.20 um 13:13 schrieb Gerd Hoffmann: > Move final cleanups from cirrus_pci_remove() to the new callback. > Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). >=20 > Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/cirrus/cirrus.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/cirrus/cirrus.c b/drivers/gpu/drm/cirrus/c= irrus.c > index a91fb0d7282c..39a9e964aac9 100644 > --- a/drivers/gpu/drm/cirrus/cirrus.c > +++ b/drivers/gpu/drm/cirrus/cirrus.c > @@ -502,6 +502,16 @@ static void cirrus_mode_config_init(struct cirrus_= device *cirrus) > =20 > /* ------------------------------------------------------------------ = */ > =20 > +static void cirrus_release(struct drm_device *dev) > +{ > + struct cirrus_device *cirrus =3D dev->dev_private; > + > + drm_mode_config_cleanup(dev); > + iounmap(cirrus->mmio); > + iounmap(cirrus->vram); > + kfree(cirrus); > +} > + > DEFINE_DRM_GEM_FOPS(cirrus_fops); > =20 > static struct drm_driver cirrus_driver =3D { > @@ -515,6 +525,7 @@ static struct drm_driver cirrus_driver =3D { > =20 > .fops =3D &cirrus_fops, > DRM_GEM_SHMEM_DRIVER_OPS, > + .release =3D cirrus_release, > }; > =20 > static int cirrus_pci_probe(struct pci_dev *pdev, > @@ -596,14 +607,10 @@ static int cirrus_pci_probe(struct pci_dev *pdev,= > static void cirrus_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev =3D pci_get_drvdata(pdev); > - struct cirrus_device *cirrus =3D dev->dev_private; > =20 > drm_dev_unregister(dev); > - drm_mode_config_cleanup(dev); > - iounmap(cirrus->mmio); > - iounmap(cirrus->vram); > + drm_atomic_helper_shutdown(dev); > drm_dev_put(dev); > - kfree(cirrus); > pci_release_regions(pdev); > } > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc-- --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl49Yx4ACgkQaA3BHVML eiMtXAf/VzMYqgF7SypSGA1bMF0d9GIyj659fF5zNajxoPTbtaxZPtcPDXJCMwoW iivOqe6ST42//C280daFteKV7wCx7yCww0KnA+X1sPT/6+RQEwKEpLoQovQaa5fM SBPcS2hmeeq5CpXJch3ko+9cqagJD2H7zAzhOX+Sl7gLZSE7fQmtdBNoXbnbEUso SigkqoEwtgGsEDliJJqU8lb2kd43YBOhpBbyabtDGSGecl/brrEUl8hHF8xnAh3y Td0vqh5fHqMhg/2Y411eJDSrIDxi++mB/bJERF/hwfTkaUo1muMSM1QV3D8YWTGB iTAxce401tBAjl3mpGYxPtwznblneg== =McVl -----END PGP SIGNATURE----- --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH] drm/cirrus: add drm_driver.release callback. Date: Fri, 7 Feb 2020 14:16:14 +0100 Message-ID: <04253f60-c374-6eb1-53e9-fff2299658cd@suse.de> References: <20200207121345.25639-1-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k" Return-path: In-Reply-To: <20200207121345.25639-1-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Dave Airlie List-Id: virtualization@lists.linuxfoundation.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k Content-Type: multipart/mixed; boundary="0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Dave Airlie Message-ID: <04253f60-c374-6eb1-53e9-fff2299658cd@suse.de> Subject: Re: [PATCH] drm/cirrus: add drm_driver.release callback. References: <20200207121345.25639-1-kraxel@redhat.com> In-Reply-To: <20200207121345.25639-1-kraxel@redhat.com> --0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 07.02.20 um 13:13 schrieb Gerd Hoffmann: > Move final cleanups from cirrus_pci_remove() to the new callback. > Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). >=20 > Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/cirrus/cirrus.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/cirrus/cirrus.c b/drivers/gpu/drm/cirrus/c= irrus.c > index a91fb0d7282c..39a9e964aac9 100644 > --- a/drivers/gpu/drm/cirrus/cirrus.c > +++ b/drivers/gpu/drm/cirrus/cirrus.c > @@ -502,6 +502,16 @@ static void cirrus_mode_config_init(struct cirrus_= device *cirrus) > =20 > /* ------------------------------------------------------------------ = */ > =20 > +static void cirrus_release(struct drm_device *dev) > +{ > + struct cirrus_device *cirrus =3D dev->dev_private; > + > + drm_mode_config_cleanup(dev); > + iounmap(cirrus->mmio); > + iounmap(cirrus->vram); > + kfree(cirrus); > +} > + > DEFINE_DRM_GEM_FOPS(cirrus_fops); > =20 > static struct drm_driver cirrus_driver =3D { > @@ -515,6 +525,7 @@ static struct drm_driver cirrus_driver =3D { > =20 > .fops =3D &cirrus_fops, > DRM_GEM_SHMEM_DRIVER_OPS, > + .release =3D cirrus_release, > }; > =20 > static int cirrus_pci_probe(struct pci_dev *pdev, > @@ -596,14 +607,10 @@ static int cirrus_pci_probe(struct pci_dev *pdev,= > static void cirrus_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev =3D pci_get_drvdata(pdev); > - struct cirrus_device *cirrus =3D dev->dev_private; > =20 > drm_dev_unregister(dev); > - drm_mode_config_cleanup(dev); > - iounmap(cirrus->mmio); > - iounmap(cirrus->vram); > + drm_atomic_helper_shutdown(dev); > drm_dev_put(dev); > - kfree(cirrus); > pci_release_regions(pdev); > } > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc-- --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl49Yx4ACgkQaA3BHVML eiMtXAf/VzMYqgF7SypSGA1bMF0d9GIyj659fF5zNajxoPTbtaxZPtcPDXJCMwoW iivOqe6ST42//C280daFteKV7wCx7yCww0KnA+X1sPT/6+RQEwKEpLoQovQaa5fM SBPcS2hmeeq5CpXJch3ko+9cqagJD2H7zAzhOX+Sl7gLZSE7fQmtdBNoXbnbEUso SigkqoEwtgGsEDliJJqU8lb2kd43YBOhpBbyabtDGSGecl/brrEUl8hHF8xnAh3y Td0vqh5fHqMhg/2Y411eJDSrIDxi++mB/bJERF/hwfTkaUo1muMSM1QV3D8YWTGB iTAxce401tBAjl3mpGYxPtwznblneg== =McVl -----END PGP SIGNATURE----- --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19689C352A4 for ; Fri, 7 Feb 2020 13:16:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF0D421741 for ; Fri, 7 Feb 2020 13:16:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF0D421741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 497B96FC90; Fri, 7 Feb 2020 13:16:18 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DC086FC82 for ; Fri, 7 Feb 2020 13:16:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 55727AD55; Fri, 7 Feb 2020 13:16:15 +0000 (UTC) Subject: Re: [PATCH] drm/cirrus: add drm_driver.release callback. To: Gerd Hoffmann , dri-devel@lists.freedesktop.org References: <20200207121345.25639-1-kraxel@redhat.com> From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= mQENBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAG0J1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPokBVAQTAQgAPhYh BHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEGgNwR1TC3ojR80H/jH+vYavwQ+TvO8ksXL9JQWc3IFSiGpuSVXLCdg62AmR irxW+qCwNncNQyb9rd30gzdectSkPWL3KSqEResBe24IbA5/jSkPweJasgXtfhuyoeCJ6PXo clQQGKIoFIAEv1s8l0ggPZswvCinegl1diyJXUXmdEJRTWYAtxn/atut1o6Giv6D2qmYbXN7 mneMC5MzlLaJKUtoH7U/IjVw1sx2qtxAZGKVm4RZxPnMCp9E1MAr5t4dP5gJCIiqsdrVqI6i KupZstMxstPU//azmz7ZWWxT0JzgJqZSvPYx/SATeexTYBP47YFyri4jnsty2ErS91E6H8os Bv6pnSn7eAq5AQ0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRH UE9eosYbT6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgT RjP+qbU63Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+R dhgATnWWGKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zb ehDda8lvhFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r 12+lqdsAEQEAAYkBPAQYAQgAJhYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsMBQkD wmcAAAoJEGgNwR1TC3ojpfcIAInwP5OlcEKokTnHCiDTz4Ony4GnHRP2fXATQZCKxmu4AJY2 h9ifw9Nf2TjCZ6AMvC3thAN0rFDj55N9l4s1CpaDo4J+0fkrHuyNacnT206CeJV1E7NYntxU n+LSiRrOdywn6erjxRi9EYTVLCHcDhBEjKmFZfg4AM4GZMWX1lg0+eHbd5oL1as28WvvI/uI aMyV8RbyXot1r/8QLlWldU3NrTF5p7TMU2y3ZH2mf5suSKHAMtbE4jKJ8ZHFOo3GhLgjVrBW HE9JXO08xKkgD+w6v83+nomsEuf6C6LYrqY/tsZvyEX6zN8CtirPdPWu/VXNRYAl/lat7lSI 3H26qrE= Message-ID: <04253f60-c374-6eb1-53e9-fff2299658cd@suse.de> Date: Fri, 7 Feb 2020 14:16:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200207121345.25639-1-kraxel@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Dave Airlie , open list , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" Content-Type: multipart/mixed; boundary="===============1448747417==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1448747417== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k Content-Type: multipart/mixed; boundary="0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Dave Airlie Message-ID: <04253f60-c374-6eb1-53e9-fff2299658cd@suse.de> Subject: Re: [PATCH] drm/cirrus: add drm_driver.release callback. References: <20200207121345.25639-1-kraxel@redhat.com> In-Reply-To: <20200207121345.25639-1-kraxel@redhat.com> --0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 07.02.20 um 13:13 schrieb Gerd Hoffmann: > Move final cleanups from cirrus_pci_remove() to the new callback. > Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). >=20 > Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/cirrus/cirrus.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/cirrus/cirrus.c b/drivers/gpu/drm/cirrus/c= irrus.c > index a91fb0d7282c..39a9e964aac9 100644 > --- a/drivers/gpu/drm/cirrus/cirrus.c > +++ b/drivers/gpu/drm/cirrus/cirrus.c > @@ -502,6 +502,16 @@ static void cirrus_mode_config_init(struct cirrus_= device *cirrus) > =20 > /* ------------------------------------------------------------------ = */ > =20 > +static void cirrus_release(struct drm_device *dev) > +{ > + struct cirrus_device *cirrus =3D dev->dev_private; > + > + drm_mode_config_cleanup(dev); > + iounmap(cirrus->mmio); > + iounmap(cirrus->vram); > + kfree(cirrus); > +} > + > DEFINE_DRM_GEM_FOPS(cirrus_fops); > =20 > static struct drm_driver cirrus_driver =3D { > @@ -515,6 +525,7 @@ static struct drm_driver cirrus_driver =3D { > =20 > .fops =3D &cirrus_fops, > DRM_GEM_SHMEM_DRIVER_OPS, > + .release =3D cirrus_release, > }; > =20 > static int cirrus_pci_probe(struct pci_dev *pdev, > @@ -596,14 +607,10 @@ static int cirrus_pci_probe(struct pci_dev *pdev,= > static void cirrus_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev =3D pci_get_drvdata(pdev); > - struct cirrus_device *cirrus =3D dev->dev_private; > =20 > drm_dev_unregister(dev); > - drm_mode_config_cleanup(dev); > - iounmap(cirrus->mmio); > - iounmap(cirrus->vram); > + drm_atomic_helper_shutdown(dev); > drm_dev_put(dev); > - kfree(cirrus); > pci_release_regions(pdev); > } > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --0UNtBLvA4uOHbcc5wWuhUjblFlWPhipdc-- --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl49Yx4ACgkQaA3BHVML eiMtXAf/VzMYqgF7SypSGA1bMF0d9GIyj659fF5zNajxoPTbtaxZPtcPDXJCMwoW iivOqe6ST42//C280daFteKV7wCx7yCww0KnA+X1sPT/6+RQEwKEpLoQovQaa5fM SBPcS2hmeeq5CpXJch3ko+9cqagJD2H7zAzhOX+Sl7gLZSE7fQmtdBNoXbnbEUso SigkqoEwtgGsEDliJJqU8lb2kd43YBOhpBbyabtDGSGecl/brrEUl8hHF8xnAh3y Td0vqh5fHqMhg/2Y411eJDSrIDxi++mB/bJERF/hwfTkaUo1muMSM1QV3D8YWTGB iTAxce401tBAjl3mpGYxPtwznblneg== =McVl -----END PGP SIGNATURE----- --vWiAiFYFDSjXvdHMKsa0eatJA1wnAmM4k-- --===============1448747417== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1448747417==--