From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crUBJ-0005Qt-ND for qemu-devel@nongnu.org; Fri, 24 Mar 2017 14:43:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crUBG-0005tw-MS for qemu-devel@nongnu.org; Fri, 24 Mar 2017 14:43:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:41259) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crUBG-0005tn-DQ for qemu-devel@nongnu.org; Fri, 24 Mar 2017 14:43:22 -0400 References: <20170316141953.16161-1-jgross@suse.com> <20170316141953.16161-3-jgross@suse.com> <214bc24d-1c0c-16d6-9c33-e20962b150d2@suse.com> <2fb1da9d14c14eb4826a87657f7d0eb1@AMSPEX02CL03.citrite.net> <550ea61e-c9ba-5afc-12b5-438a2a57af6e@suse.com> <7208ddd9b76b4196be0a3d3cd12aee71@AMSPEX02CL03.citrite.net> <20f2b3ce-218b-4d61-6af1-8c70b751ed18@suse.com> <0103d60e-cd96-ab48-70fb-f75ba1273f39@suse.com> <1bd386167cff4ef9a281139afb9308dc@AMSPEX02CL03.citrite.net> From: Juergen Gross Message-ID: <0426b870-b23c-85f6-160c-f5df8db753d0@suse.com> Date: Fri, 24 Mar 2017 19:43:18 +0100 MIME-Version: 1.0 In-Reply-To: <1bd386167cff4ef9a281139afb9308dc@AMSPEX02CL03.citrite.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant , 'Stefano Stabellini' Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" , "kraxel@redhat.com" On 24/03/17 17:42, Paul Durrant wrote: >> -----Original Message----- > [snip] >>>> That's a change in behaviour that I, and probably others, have long been >> used to. What we really want, presumably, is to have pkg-config just look >> under tools/pkgconfig when querying for the version of xencontrol. Could >> that not be done by simply setting PKG_CONFIG_LIBDIR in QEMU's configure >> script, or would it still mean picking up installed libraries before ones just >> built? >>> >>> I guess this would break qemu's configure badly as it wouldn't find all >>> the other library informations it is looking for via pkg-config. >> >> Aah, wait, you mean just for the Xen query? >> >> This might complicate things for my qemu stubdom plans... >> > > How about this patch to QEMU configure? > > diff --git a/configure b/configure > index fdf47e4..6ef5980 100755 > --- a/configure > +++ b/configure > @@ -1974,6 +1974,10 @@ fi > ########################################## > # xen probe > > +xen_query_pkg_config() { > + PKG_CONFIG_LIBDIR= ${pkg_config_exe} "$@" > +} > + > if test "$xen" != "no" ; then > xen_libs="-lxenstore -lxenctrl -lxenguest" > xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn" > @@ -1997,9 +2001,9 @@ EOF > xen=no > > # Xen version via pkg-config (Xen 4.9.0 and newer) > - elif $pkg_config --exists xencontrol ; then > + elif xen_query_pkg_config --exists xencontrol; then > xen_ctrl_version="$(printf '%d%02d%02d' \ > - $($pkg_config --modversion xencontrol | sed 's/\./ /g') )" > + $(xen_query_pkg_config --modversion xencontrol | sed 's/\./ /g') )" > xen=yes > > elif > @@ -2216,8 +2220,8 @@ EOF > if test $xen_ctrl_version -ge 40900 ; then > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab xenevtchn" > xen_pc="$xen_pc xendevicemodel" > - xen_libs="$($pkg_config --libs $xen_pc)" > - QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)" > + xen_libs="$(xen_query_pkg_config --libs $xen_pc)" > + QEMU_CFLAGS="$QEMU_CFLAGS $(xen_query_pkg_config --cflags $xen_pc)" > elif test $xen_ctrl_version -ge 40701 ; then > libs_softmmu="$xen_stable_libs $libs_softmmu" > fi > > This appears to DTRT for me when switching between versions of Xen. But not for someone trying to build qemu outside of Xen trying to use the properly installed pkg-config files of Xen. They wouldn't be found any more. You are breaking a feature for the majority of users just to make live easier for a handful of developers unwilling to change their workflow. Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 2/2] configure: use pkg-config for obtaining xen version Date: Fri, 24 Mar 2017 19:43:18 +0100 Message-ID: <0426b870-b23c-85f6-160c-f5df8db753d0@suse.com> References: <20170316141953.16161-1-jgross@suse.com> <20170316141953.16161-3-jgross@suse.com> <214bc24d-1c0c-16d6-9c33-e20962b150d2@suse.com> <2fb1da9d14c14eb4826a87657f7d0eb1@AMSPEX02CL03.citrite.net> <550ea61e-c9ba-5afc-12b5-438a2a57af6e@suse.com> <7208ddd9b76b4196be0a3d3cd12aee71@AMSPEX02CL03.citrite.net> <20f2b3ce-218b-4d61-6af1-8c70b751ed18@suse.com> <0103d60e-cd96-ab48-70fb-f75ba1273f39@suse.com> <1bd386167cff4ef9a281139afb9308dc@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crUBJ-00072F-8T for xen-devel@lists.xenproject.org; Fri, 24 Mar 2017 18:43:25 +0000 In-Reply-To: <1bd386167cff4ef9a281139afb9308dc@AMSPEX02CL03.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paul Durrant , 'Stefano Stabellini' Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" , "kraxel@redhat.com" List-Id: xen-devel@lists.xenproject.org T24gMjQvMDMvMTcgMTc6NDIsIFBhdWwgRHVycmFudCB3cm90ZToKPj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0KPiBbc25pcF0KPj4+PiBUaGF0J3MgYSBjaGFuZ2UgaW4gYmVoYXZpb3VyIHRo YXQgSSwgYW5kIHByb2JhYmx5IG90aGVycywgaGF2ZSBsb25nIGJlZW4KPj4gdXNlZCB0by4gV2hh dCB3ZSByZWFsbHkgd2FudCwgcHJlc3VtYWJseSwgaXMgdG8gaGF2ZSBwa2ctY29uZmlnIGp1c3Qg bG9vawo+PiB1bmRlciB0b29scy9wa2djb25maWcgd2hlbiBxdWVyeWluZyBmb3IgdGhlIHZlcnNp b24gb2YgeGVuY29udHJvbC4gQ291bGQKPj4gdGhhdCBub3QgYmUgZG9uZSBieSBzaW1wbHkgc2V0 dGluZyBQS0dfQ09ORklHX0xJQkRJUiBpbiBRRU1VJ3MgY29uZmlndXJlCj4+IHNjcmlwdCwgb3Ig d291bGQgaXQgc3RpbGwgbWVhbiBwaWNraW5nIHVwIGluc3RhbGxlZCBsaWJyYXJpZXMgYmVmb3Jl IG9uZXMganVzdAo+PiBidWlsdD8KPj4+Cj4+PiBJIGd1ZXNzIHRoaXMgd291bGQgYnJlYWsgcWVt dSdzIGNvbmZpZ3VyZSBiYWRseSBhcyBpdCB3b3VsZG4ndCBmaW5kIGFsbAo+Pj4gdGhlIG90aGVy IGxpYnJhcnkgaW5mb3JtYXRpb25zIGl0IGlzIGxvb2tpbmcgZm9yIHZpYSBwa2ctY29uZmlnLgo+ Pgo+PiBBYWgsIHdhaXQsIHlvdSBtZWFuIGp1c3QgZm9yIHRoZSBYZW4gcXVlcnk/Cj4+Cj4+IFRo aXMgbWlnaHQgY29tcGxpY2F0ZSB0aGluZ3MgZm9yIG15IHFlbXUgc3R1YmRvbSBwbGFucy4uLgo+ Pgo+IAo+IEhvdyBhYm91dCB0aGlzIHBhdGNoIHRvIFFFTVUgY29uZmlndXJlPwo+IAo+IGRpZmYg LS1naXQgYS9jb25maWd1cmUgYi9jb25maWd1cmUKPiBpbmRleCBmZGY0N2U0Li42ZWY1OTgwIDEw MDc1NQo+IC0tLSBhL2NvbmZpZ3VyZQo+ICsrKyBiL2NvbmZpZ3VyZQo+IEBAIC0xOTc0LDYgKzE5 NzQsMTAgQEAgZmkKPiAgIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj Cj4gICMgeGVuIHByb2JlCj4gCj4gK3hlbl9xdWVyeV9wa2dfY29uZmlnKCkgewo+ICsgICAgUEtH X0NPTkZJR19MSUJESVI9ICR7cGtnX2NvbmZpZ19leGV9ICIkQCIKPiArfQo+ICsKPiAgaWYgdGVz dCAiJHhlbiIgIT0gIm5vIiA7IHRoZW4KPiAgICB4ZW5fbGlicz0iLWx4ZW5zdG9yZSAtbHhlbmN0 cmwgLWx4ZW5ndWVzdCIKPiAgICB4ZW5fc3RhYmxlX2xpYnM9Ii1seGVuZm9yZWlnbm1lbW9yeSAt bHhlbmdudHRhYiAtbHhlbmV2dGNobiIKPiBAQCAtMTk5Nyw5ICsyMDAxLDkgQEAgRU9GCj4gICAg ICB4ZW49bm8KPiAKPiAgICAjIFhlbiB2ZXJzaW9uIHZpYSBwa2ctY29uZmlnIChYZW4gNC45LjAg YW5kIG5ld2VyKQo+IC0gIGVsaWYgJHBrZ19jb25maWcgLS1leGlzdHMgeGVuY29udHJvbCA7IHRo ZW4KPiArICBlbGlmIHhlbl9xdWVyeV9wa2dfY29uZmlnIC0tZXhpc3RzIHhlbmNvbnRyb2w7IHRo ZW4KPiAgICAgIHhlbl9jdHJsX3ZlcnNpb249IiQocHJpbnRmICclZCUwMmQlMDJkJyBcCj4gLSAg ICAgICQoJHBrZ19jb25maWcgLS1tb2R2ZXJzaW9uIHhlbmNvbnRyb2wgfCBzZWQgJ3MvXC4vIC9n JykgKSIKPiArICAgICAgJCh4ZW5fcXVlcnlfcGtnX2NvbmZpZyAtLW1vZHZlcnNpb24geGVuY29u dHJvbCB8IHNlZCAncy9cLi8gL2cnKSApIgo+ICAgICAgeGVuPXllcwo+IAo+ICAgIGVsaWYKPiBA QCAtMjIxNiw4ICsyMjIwLDggQEAgRU9GCj4gICAgICBpZiB0ZXN0ICR4ZW5fY3RybF92ZXJzaW9u IC1nZSA0MDkwMCA7IHRoZW4KPiAgICAgICAgeGVuX3BjPSJ4ZW5jb250cm9sIHhlbnN0b3JlIHhl bmd1ZXN0IHhlbmZvcmVpZ25tZW1vcnkgeGVuZ250dGFiIHhlbmV2dGNobiIKPiAgICAgICAgeGVu X3BjPSIkeGVuX3BjIHhlbmRldmljZW1vZGVsIgo+IC0gICAgICB4ZW5fbGlicz0iJCgkcGtnX2Nv bmZpZyAtLWxpYnMgJHhlbl9wYykiCj4gLSAgICAgIFFFTVVfQ0ZMQUdTPSIkUUVNVV9DRkxBR1Mg JCgkcGtnX2NvbmZpZyAtLWNmbGFncyAkeGVuX3BjKSIKPiArICAgICAgeGVuX2xpYnM9IiQoeGVu X3F1ZXJ5X3BrZ19jb25maWcgLS1saWJzICR4ZW5fcGMpIgo+ICsgICAgICBRRU1VX0NGTEFHUz0i JFFFTVVfQ0ZMQUdTICQoeGVuX3F1ZXJ5X3BrZ19jb25maWcgLS1jZmxhZ3MgJHhlbl9wYykiCj4g ICAgICBlbGlmIHRlc3QgJHhlbl9jdHJsX3ZlcnNpb24gLWdlIDQwNzAxIDsgdGhlbgo+ICAgICAg ICBsaWJzX3NvZnRtbXU9IiR4ZW5fc3RhYmxlX2xpYnMgJGxpYnNfc29mdG1tdSIKPiAgICAgIGZp Cj4gCj4gVGhpcyBhcHBlYXJzIHRvIERUUlQgZm9yIG1lIHdoZW4gc3dpdGNoaW5nIGJldHdlZW4g dmVyc2lvbnMgb2YgWGVuLgoKQnV0IG5vdCBmb3Igc29tZW9uZSB0cnlpbmcgdG8gYnVpbGQgcWVt dSBvdXRzaWRlIG9mIFhlbiB0cnlpbmcgdG8gdXNlCnRoZSBwcm9wZXJseSBpbnN0YWxsZWQgcGtn LWNvbmZpZyBmaWxlcyBvZiBYZW4uIFRoZXkgd291bGRuJ3QgYmUKZm91bmQgYW55IG1vcmUuCgpZ b3UgYXJlIGJyZWFraW5nIGEgZmVhdHVyZSBmb3IgdGhlIG1ham9yaXR5IG9mIHVzZXJzIGp1c3Qg dG8gbWFrZQpsaXZlIGVhc2llciBmb3IgYSBoYW5kZnVsIG9mIGRldmVsb3BlcnMgdW53aWxsaW5n IHRvIGNoYW5nZSB0aGVpcgp3b3JrZmxvdy4KCgpKdWVyZ2VuCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1k ZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK