From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Greg Kurz" <groug@kaod.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Cédric Le Goater" <clg@kaod.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path
Date: Tue, 22 Feb 2022 13:56:01 +0100 [thread overview]
Message-ID: <043096b3-aadf-4f2a-b5e2-c219d2344821@gmail.com> (raw)
In-Reply-To: <87a6ejnm80.fsf@pond.sub.org>
Hi Markus,
On 22/2/22 13:02, Markus Armbruster wrote:
> Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and
> the RTC supports the event). What if there's more than one RTC?
w.r.t. RTC, a machine having multiple RTC devices is silly...
Assuming one wants to emulate that; shouldn't all QMP events have a
qom-path by default? Or have a generic "event-from-multiple-sources"
flag which automatically add this field?
> Which one changed? New @qom-path identifies it.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> RFC because it's compile-tested only. Worthwhile? Let me know what you
> think.
>
> qapi/misc.json | 4 +++-
> hw/ppc/spapr_rtc.c | 4 +++-
> hw/rtc/mc146818rtc.c | 3 ++-
> hw/rtc/pl031.c | 3 ++-
> 4 files changed, 10 insertions(+), 4 deletions(-)
next prev parent reply other threads:[~2022-02-22 13:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 19:21 [PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema Peter Maydell
2022-02-21 19:21 ` [PATCH v2 1/3] " Peter Maydell
2022-02-21 19:27 ` Philippe Mathieu-Daudé
2022-02-21 19:21 ` [PATCH v2 2/3] qapi: Document some missing details of RTC_CHANGE event Peter Maydell
2022-02-21 19:28 ` Philippe Mathieu-Daudé
2022-02-22 11:22 ` Markus Armbruster
2022-02-21 19:21 ` [PATCH v2 3/3] hw/rtc: Compile pl031 once-only Peter Maydell
2022-02-21 19:28 ` Philippe Mathieu-Daudé
2022-02-21 20:11 ` [PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema Eric Auger
2022-02-22 12:02 ` [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path Markus Armbruster
2022-02-22 12:56 ` Philippe Mathieu-Daudé [this message]
2022-02-22 13:06 ` Peter Maydell
2022-02-22 15:47 ` Philippe Mathieu-Daudé
2022-02-23 18:00 ` Cédric Le Goater
2022-02-22 15:04 ` Markus Armbruster
2022-02-22 15:47 ` Philippe Mathieu-Daudé
2022-02-23 13:46 ` Markus Armbruster
2022-02-25 8:38 ` [PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=043096b3-aadf-4f2a-b5e2-c219d2344821@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.