All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 04/26] recipetool: create: fix do_install handling for makefile-only software
Date: Tue, 22 Dec 2015 17:02:57 +1300	[thread overview]
Message-ID: <0443897aba52e93a3cc7cbf3a3c2d730c9ab75ae.1450756555.git.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <cover.1450756555.git.paul.eggleton@linux.intel.com>
In-Reply-To: <cover.1450756555.git.paul.eggleton@linux.intel.com>

In my testing here it appears make -qn returns an error (exit code 2)
whereas make -n doesn't; I can't immediately tell why based on the
documentation. We don't actually care for it to be quiet since we're
capturing the output, so let's just leave -q off and have this work
properly as a result.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 scripts/lib/recipetool/create_buildsys.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/recipetool/create_buildsys.py b/scripts/lib/recipetool/create_buildsys.py
index ed14a53..931ef3b 100644
--- a/scripts/lib/recipetool/create_buildsys.py
+++ b/scripts/lib/recipetool/create_buildsys.py
@@ -279,7 +279,7 @@ class MakefileRecipeHandler(RecipeHandler):
 
             installtarget = True
             try:
-                stdout, stderr = bb.process.run('make -qn install', cwd=srctree, shell=True)
+                stdout, stderr = bb.process.run('make -n install', cwd=srctree, shell=True)
             except bb.process.ExecutionError as e:
                 if e.exitcode != 1:
                     installtarget = False
-- 
2.5.0



  parent reply	other threads:[~2015-12-22  4:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22  4:02 [PATCH 00/26] devtool/recipetool improvements Paul Eggleton
2015-12-22  4:02 ` [PATCH 01/26] scripts: print usage in argparse-using scripts when a command-line error occurs Paul Eggleton
2015-12-22  4:02 ` [PATCH 02/26] recipetool: create: handle https://....git URLs Paul Eggleton
2015-12-22  4:02 ` [PATCH 03/26] recipetool: create: avoid traceback on fetch error Paul Eggleton
2015-12-22  4:02 ` Paul Eggleton [this message]
2015-12-22  4:02 ` [PATCH 05/26] recipetool: create: minor fix for potential issue in python handling Paul Eggleton
2015-12-22  4:02 ` [PATCH 06/26] recipetool: create: prevent attempting to unpack entire DL_DIR Paul Eggleton
2015-12-22  4:03 ` [PATCH 07/26] recipetool: create: detect when specified URL returns a web page Paul Eggleton
2015-12-22  4:03 ` [PATCH 08/26] recipetool: create: set up priority system for recipe handlers Paul Eggleton
2015-12-22  4:03 ` [PATCH 09/26] recipetool: create: support extracting name and version from build scripts Paul Eggleton
2015-12-22  4:03 ` [PATCH 10/26] recipetool: create: basic extraction of name/version from filename Paul Eggleton
2015-12-22  4:03 ` [PATCH 11/26] devtool: edit-recipe: add new subcommand Paul Eggleton
2015-12-22  4:03 ` [PATCH 12/26] devtool: add: tweak help text Paul Eggleton
2015-12-22  4:03 ` [PATCH 13/26] devtool: split out function for naming bbappend Paul Eggleton
2015-12-22  4:03 ` [PATCH 14/26] devtool: update-recipe: use correct method to get bbappend filename Paul Eggleton
2015-12-22  4:03 ` [PATCH 15/26] scripts/lib/argparse_oe: handle intermixing of optional positional arguments Paul Eggleton
2015-12-22  4:03 ` [PATCH 16/26] devtool: add: allow source tree to be omitted Paul Eggleton
2015-12-22  4:03 ` [PATCH 17/26] devtool: add: figure out recipe name from recipetool Paul Eggleton
2015-12-22  4:03 ` [PATCH 18/26] devtool: add: allow specifying URL as positional argument Paul Eggleton
2015-12-22  4:03 ` [PATCH 19/26] devtool: modify: default source tree path Paul Eggleton
2015-12-22  4:03 ` [PATCH 20/26] devtool: status: list recipe file within workspace if one exists Paul Eggleton
2015-12-22  4:03 ` [PATCH 21/26] devtool: reset: print message about leaving source tree behind Paul Eggleton
2015-12-22  4:03 ` [PATCH 22/26] devtool: sync: tweak help / messages Paul Eggleton
2015-12-22  4:03 ` [PATCH 23/26] recipetool: create: improve autotools support Paul Eggleton
2015-12-22  4:03 ` [PATCH 24/26] recipetool: create: fix error when extracting source to a specified directory Paul Eggleton
2015-12-22  4:03 ` [PATCH 25/26] oe-selftest: add tests for simple devtool add / recipetool create URL case Paul Eggleton
2015-12-22  4:03 ` [PATCH 26/26] oe-selftest: devtool: add more explicit check for ls output Paul Eggleton
2015-12-24  2:45 ` [PATCH 00/26] devtool/recipetool improvements Khem Raj
2015-12-28 19:03   ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0443897aba52e93a3cc7cbf3a3c2d730c9ab75ae.1450756555.git.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.