From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048BAC48BE5 for ; Fri, 11 Jun 2021 13:46:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2B09613C3 for ; Fri, 11 Jun 2021 13:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbhFKNsK (ORCPT ); Fri, 11 Jun 2021 09:48:10 -0400 Received: from 49-237-179-185.static.tentacle.fi ([185.179.237.49]:55322 "EHLO bitmer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbhFKNsJ (ORCPT ); Fri, 11 Jun 2021 09:48:09 -0400 Received: from 88-114-184-142.elisa-laajakaista.fi ([88.114.184.142] helo=[192.168.1.48]) by bitmer.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lrhU2-0005UL-Tt; Fri, 11 Jun 2021 16:46:02 +0300 Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status To: Tony Lindgren , linux-omap@vger.kernel.org Cc: Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Grygorii Strashko , Keerthy , Nishanth Menon , Suman Anna , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210611060224.36769-1-tony@atomide.com> From: Jarkko Nikula Message-ID: <0444bf45-2b6d-5200-6967-736263e75819@bitmer.com> Date: Fri, 11 Jun 2021 16:45:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210611060224.36769-1-tony@atomide.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.6.2021 9.02, Tony Lindgren wrote: > Jarkko Nikula reported that Beagleboard > revision c2 stopped booting. Jarkko bisected the issue down to > commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend > and resume for am3 and am4"). > > Let's fix the issue by tagging system timers as reserved rather than > ignoring them. And let's not probe any interconnect target module child > devices for reserved modules. > > This allows PM runtime to keep track of clocks and clockdomains for > the interconnect target module, and prevent the system timer from idling > as we already have SYSC_QUIRK_NO_IDLE and SYSC_QUIRK_NO_IDLE_ON_INIT > flags set for system timers. > > Fixes: 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4") > Reported-by: Jarkko Nikula > Signed-off-by: Tony Lindgren > --- > drivers/bus/ti-sysc.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > I tested this on top of 06af8679449d ("coredump: Limit what can interrupt coredumps"). I tested Tony's earlier test diff which does the same that this actual patch also on top of 6cfcd5563b4f. Tested-by: Jarkko Nikula From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A5C5C48BE0 for ; Fri, 11 Jun 2021 14:13:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D938361400 for ; Fri, 11 Jun 2021 14:13:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D938361400 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bitmer.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RdJftEBq5x8tUpy8OwqsnneAlqfXmnYNqbxfmQ0RdIo=; b=HsXoeGj3DB56kddiLRGFnhrLsU w6pvIdf6UWLQEILGZilqbr8XW6c/GTky3h8Y2yrVqJR4XaPwtyl3k1BCsGnmKhv3VhX/JI68LkjC/ qgB2xMjMHQ5/KVfN5I3tuUHDnKWNtUzph5Gbg5dophbBhEWFc89/R3cf9jo/LuTFn4pO9uBPYZyPc zZSFAmuDjarSWKJKkuqLNMvuKLwUXlWSH+6DrIilwWvutIV7dSNQ1sjCAlNQc2M/GLc8PSaX0rUb9 4KkhT+qaghIviB4GW+s6yen23+S46qui4hZ+lz34fAWUGbcIHJSR/5uQu7x4WA6GAp1Lz+DLSxMml BT/oxmoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrhtP-005aV9-8a; Fri, 11 Jun 2021 14:12:15 +0000 Received: from 49-237-179-185.static.tentacle.fi ([185.179.237.49] helo=bitmer.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrhtH-005aTY-Ew for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 14:12:11 +0000 Received: from 88-114-184-142.elisa-laajakaista.fi ([88.114.184.142] helo=[192.168.1.48]) by bitmer.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lrhU2-0005UL-Tt; Fri, 11 Jun 2021 16:46:02 +0300 Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status To: Tony Lindgren , linux-omap@vger.kernel.org Cc: Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Grygorii Strashko , Keerthy , Nishanth Menon , Suman Anna , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210611060224.36769-1-tony@atomide.com> From: Jarkko Nikula Message-ID: <0444bf45-2b6d-5200-6967-736263e75819@bitmer.com> Date: Fri, 11 Jun 2021 16:45:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210611060224.36769-1-tony@atomide.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_071207_680886_C723043B X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.6.2021 9.02, Tony Lindgren wrote: > Jarkko Nikula reported that Beagleboard > revision c2 stopped booting. Jarkko bisected the issue down to > commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend > and resume for am3 and am4"). > > Let's fix the issue by tagging system timers as reserved rather than > ignoring them. And let's not probe any interconnect target module child > devices for reserved modules. > > This allows PM runtime to keep track of clocks and clockdomains for > the interconnect target module, and prevent the system timer from idling > as we already have SYSC_QUIRK_NO_IDLE and SYSC_QUIRK_NO_IDLE_ON_INIT > flags set for system timers. > > Fixes: 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4") > Reported-by: Jarkko Nikula > Signed-off-by: Tony Lindgren > --- > drivers/bus/ti-sysc.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > I tested this on top of 06af8679449d ("coredump: Limit what can interrupt coredumps"). I tested Tony's earlier test diff which does the same that this actual patch also on top of 6cfcd5563b4f. Tested-by: Jarkko Nikula _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel