From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B06C433FE for ; Mon, 27 Sep 2021 16:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B45260FED for ; Mon, 27 Sep 2021 16:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235433AbhI0QUU (ORCPT ); Mon, 27 Sep 2021 12:20:20 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]:30080 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235424AbhI0QUT (ORCPT ); Mon, 27 Sep 2021 12:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1632759506; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=g2indfiR/jZDlYxjjZkEZkE7oAQ92vUodc4qSJ3YJjc=; b=Yln5ZK7ecw/dpFPlXymVcHMiFw1FlovIo14amHEIdHeoDq9fy+5YJhD6PCdN3uyZxo M08iDkxNZE/Sg7kBE/yygTD5XEB6p6IPzOhylmIn+IcWD9APBtpIGjD8YOXFdOyZa06/ +pPuA1v0pidTm+Ic4qAOd7IuE2woqAPQha5aibSmeFktDzebjH4hiCVT7nvKBO0e5N3o m9IwxXLMPjeBrnBPRrkXHlmSxAAq40LRrOuvEbwm8j0KJ3lVb8HdYV2TNEwqA50G+xS/ xs1DxL1BZFIwL9YcGsP5dDXt0sb4EC40X56rb7F38i70APDmwZcRCauQeMzuMKnIepl1 TOLQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7gpw91N5y2S3i8QW3w==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.33.8 DYNA|AUTH) with ESMTPSA id I01f74x8RGIQarb (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Mon, 27 Sep 2021 18:18:26 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders From: "H. Nikolaus Schaller" In-Reply-To: Date: Mon, 27 Sep 2021 18:18:25 +0200 Cc: Paul Boddie , Laurent Pinchart , David Airlie , Daniel Vetter , linux-mips , list@opendingux.net, dri-devel , linux-kernel Content-Transfer-Encoding: quoted-printable Message-Id: <044C92DA-EF88-4738-BF60-885906588408@goldelico.com> References: <20210922205555.496871-1-paul@crapouillou.net> <4366739.KZ8Jxz7LyS@jason> <2094991.ScV2v2meXk@jason> <96585ED9-B707-4AF1-8417-E03DE6414965@goldelico.com> To: Paul Cercueil X-Mailer: Apple Mail (2.3445.104.21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, > Am 25.09.2021 um 21:39 schrieb Paul Cercueil : >=20 >=20 >=20 > Le sam., sept. 25 2021 at 21:26:42 +0200, H. Nikolaus Schaller = a =C3=A9crit : >> Hi Paul, >>> Am 25.09.2021 um 21:08 schrieb Paul Cercueil : >>> Hi Paul & Nikolaus, >>> If you spent some time debugging the issue >> we did ... >=20 > By saying that you didn't debug, We did - but sometimes you don't see the wood for the trees. > (null) means you're printing a NULL pointer. So I could see that = hdmi->next_bridge was NULL. I remember we did find this, but did not understand that it should be = initialized by dw-hdmi. And because we though that dw-hdmi has it its own connector, it is ok = that way. > The place that sets it is dw_hdmi_parse_dt, which will return early = with code 0, before next_bridge is set, if plat_data->output_port =3D=3D = 0, which was your case. Well, we were still at 5.14 when we did these initial attempts to use = hdmi-connector with synopsys. Back then, there was no dw_hdmi_parse_dt and no output_port. IAW: we did not even have a chance to make it work on top of 5.14 the = hdmi-connector way. And were sucessful. I just noticed this when trying to backport the last puzzle piece... Well, it is always difficult to hit a moving target. > Since your hdmi-connector is wired at port #1, then .output_port = should be 1 as well. Anyways it works now for 5.14.8 (our internal test) and 5.15-rc3. And v4 of the jz4780 hdmi stuff will follow. BR and thanks, Nikolaus