From: Milan Broz <gmazyland@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Israel Rukshin <israelr@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
dm-devel <dm-devel@redhat.com>, Nitzan Carmi <nitzanc@nvidia.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [dm-devel] [RFC PATCH 0/1] Add inline encryption support for dm-crypt
Date: Mon, 17 Jan 2022 11:50:59 +0100 [thread overview]
Message-ID: <0461b15e-8ace-5a84-cf9d-504e555b8cab@gmail.com> (raw)
In-Reply-To: <YeUgNpFeg9LmW4Um@infradead.org>
On 17/01/2022 08:52, Christoph Hellwig wrote:
> On Fri, Jan 14, 2022 at 09:51:20PM +0100, Milan Broz wrote:
>> I think dm-crypt should stay as SW crypto only (using kernel crypto API,
>> so HW acceleration is done through crypto drivers there).
>>
>> A cleaner solution is to write a much simpler new dm-crypt-inline target,
>> which will implement only inline encryption.
>> (And userspace can decide which target to use.)
>> Code should be just an extension to the dm-linear target, most
>> of dm-crypt complexity is not needed here.
>
> Why do we even need a dm target for this as well? There should be no
> need to clone or remap bios, so I think hamdling inline crypto should be
> just a small addition to the core block layer.
Well, yes, that was my question too :-)
Maybe there is need to have some new userspace utility to configure that
but otherwise I think that for inline encryption device mapper layer
only increases complexity and reduces IO performance.
Could anyone elaborate what it the reason for such DM extension?
Compatibility with existing encryption/key management tools (like LUKS)?
Easy support in LVM? ...
Milan
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-01-17 10:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 18:09 [dm-devel] [RFC PATCH 0/1] Add inline encryption support for dm-crypt Israel Rukshin
2022-01-13 18:09 ` [dm-devel] [PATCH 1/1] dm crypt: Add inline encryption support Israel Rukshin
2022-01-14 8:06 ` Damien Le Moal
2022-01-14 8:14 ` Damien Le Moal
2022-01-16 10:29 ` Israel Rukshin
2022-01-13 21:22 ` [dm-devel] [RFC PATCH 0/1] Add inline encryption support for dm-crypt Bart Van Assche
2022-01-14 20:51 ` Milan Broz
2022-01-14 22:27 ` Eric Biggers
2022-01-15 9:22 ` Milan Broz
2022-01-18 19:38 ` Eric Biggers
2022-01-19 5:18 ` Christoph Hellwig
2022-01-17 7:52 ` Christoph Hellwig
2022-01-17 10:50 ` Milan Broz [this message]
2022-01-17 14:00 ` Israel Rukshin
2022-01-18 16:45 ` Christoph Hellwig
2022-01-18 20:27 ` Eric Biggers
2022-01-19 5:15 ` Christoph Hellwig
2022-01-14 22:49 ` Eric Biggers
2022-01-16 10:15 ` Israel Rukshin
2022-01-18 20:02 ` Eric Biggers
2022-01-19 15:45 ` Israel Rukshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0461b15e-8ace-5a84-cf9d-504e555b8cab@gmail.com \
--to=gmazyland@gmail.com \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=israelr@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=nitzanc@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.