All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Enze Li <lienze@kylinos.cn>,
	jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, enze.li@gmx.com
Subject: Re: [PATCH] scsi: sr: simplify the sr_open function
Date: Wed, 29 Mar 2023 13:50:37 -0700	[thread overview]
Message-ID: <0461c1c5-19b0-89e7-7ee5-2a1c52907701@acm.org> (raw)
In-Reply-To: <20230327030237.3407253-1-lienze@kylinos.cn>

On 3/26/23 20:02, Enze Li wrote:
> Simplify the sr_open function by removing the goto label as it does only
> return one error code.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
>   drivers/scsi/sr.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
> index 9e51dcd30bfd..12869e6d4ebd 100644
> --- a/drivers/scsi/sr.c
> +++ b/drivers/scsi/sr.c
> @@ -590,20 +590,15 @@ static int sr_open(struct cdrom_device_info *cdi, int purpose)
>   {
>   	struct scsi_cd *cd = cdi->handle;
>   	struct scsi_device *sdev = cd->device;
> -	int retval;
>   
>   	/*
>   	 * If the device is in error recovery, wait until it is done.
>   	 * If the device is offline, then disallow any access to it.
>   	 */
> -	retval = -ENXIO;
>   	if (!scsi_block_when_processing_errors(sdev))
> -		goto error_out;
> +		return -ENXIO;
>   
>   	return 0;
> -
> -error_out:
> -	return retval;	
>   }

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

  reply	other threads:[~2023-03-29 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27  3:02 [PATCH] scsi: sr: simplify the sr_open function Enze Li
2023-03-29 20:50 ` Bart Van Assche [this message]
2023-03-30 14:46 ` Benjamin Block
2023-04-03  1:37 ` Martin K. Petersen
2023-04-12  2:04 ` Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2022-09-16  9:04 Enze Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0461c1c5-19b0-89e7-7ee5-2a1c52907701@acm.org \
    --to=bvanassche@acm.org \
    --cc=enze.li@gmx.com \
    --cc=jejb@linux.ibm.com \
    --cc=lienze@kylinos.cn \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.