From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C7EC83003 for ; Thu, 30 Apr 2020 02:27:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B57520787 for ; Thu, 30 Apr 2020 02:27:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="StXRVF2Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726511AbgD3C11 (ORCPT ); Wed, 29 Apr 2020 22:27:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726180AbgD3C11 (ORCPT ); Wed, 29 Apr 2020 22:27:27 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4BFCC035494 for ; Wed, 29 Apr 2020 19:27:26 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id i136so188013qke.10 for ; Wed, 29 Apr 2020 19:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=n0ueUL4qNH47b8rihpaXCJX1CS3A2QwjcGlCkj6DNLU=; b=StXRVF2Z/oF8mgEHbwGRd4ZgjZsl1Cy/jpVXd7mPocE9mQASuyBOR1afSdGwqz+pLD TLSZZ6hrfL900AHs6UFdkzuJ6T1ZIk+8KDQvcRKfkMf6iqskQGzMHwIcyp0KTBN/B3Jr g3/ic6KlxS4zOurl1rvIPyzp3eTCZukVKBygeVeFutnK0wkK+eLJKsoIADyrDo/uCvih rTNF99Bba52PPEijHtMcy1tXNvF6zHwU2dZvDJkYaxB48lBe5mwH4Ei+O/6Idefys5Rh Cmsk5oB1YL4dIxX9vuDKpKwwnFbv6l0RYfgogeXgN9var+eGCXLr6FRuw71Dv55AOOnH qk5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=n0ueUL4qNH47b8rihpaXCJX1CS3A2QwjcGlCkj6DNLU=; b=hyLYQf4m9krAv/8ktDDvNJUrdxZKgNEA+1tC1dxkmXc8tbSnRLCcFUDf4NMgUxIRNo iUnOs5wS3dVKObeZcJki6GP2SR/0SzuZz10PS7K9p95kAPbg1cc5VVuOVqHJP/V7AZOL 94gVKmEx/3Ik8u87qN/ejpZFruHKdgEVs6Syy8ERuxrskHgQEW2DMAGJsIdLi5Uv0uEB R3VTNRd2usMkJr0XWMt4I/gyy1a+5t02d2DNqK83mftbIdt9KYgiA3tOMWxxvJsj3Ha+ uEQVLfyJF1z0dU8zR9rCzSyCDMo9yXOEJvrWF5Q9qqppbaxfBW8o94Qld8KlAFNIbh5j Z+fA== X-Gm-Message-State: AGi0PuZmEpuX45C/D6RWlSW+PJEZsO6ai2e225YuTEpWSnLsPvsNyFHP 4KmiLmTkP2zY6AWZlmhqNcR7gA== X-Google-Smtp-Source: APiQypJIgieYBZmgtgtmw8KT3AWQ292kizhBLwc90lYViUzaNYyqOUctQH/KIfh3FW1L9bc3b6KCrg== X-Received: by 2002:a37:a312:: with SMTP id m18mr1455117qke.251.1588213645884; Wed, 29 Apr 2020 19:27:25 -0700 (PDT) Received: from bbking.lan ([2804:14c:4a5:36c::cd2]) by smtp.gmail.com with ESMTPSA id o33sm953420qtj.62.2020.04.29.19.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 19:27:25 -0700 (PDT) Message-ID: <0463c90cfbe2036235010c5f8b92af6a96c20f74.camel@massaru.org> Subject: Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings From: Vitor Massaru Iha To: Randy Dunlap , dri-devel@lists.freedesktop.org Cc: sumit.semwal@linaro.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, brendanhiggins@google.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org Date: Wed, 29 Apr 2020 23:27:22 -0300 In-Reply-To: References: <20200430015930.32224-1-vitor@massaru.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > Add missed ":" on kernel-doc function parameter. > > > > This patch fixes this warnings from `make htmldocs`: > > ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or > > member 'importer_ops' not described in 'dma_buf_dynamic_attach' > > ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or > > member 'importer_priv' not described in 'dma_buf_dynamic_attach' > > > > Signed-off-by: Vitor Massaru Iha > > --- > > drivers/dma-buf/dma-buf.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > > index ccc9eda1bc28..0756d2155745 100644 > > --- a/drivers/dma-buf/dma-buf.c > > +++ b/drivers/dma-buf/dma-buf.c > > @@ -655,8 +655,8 @@ EXPORT_SYMBOL_GPL(dma_buf_put); > > * calls attach() of dma_buf_ops to allow device-specific attach > > functionality > > * @dmabuf: [in] buffer to attach device to. > > * @dev: [in] device to be attached. > > - * @importer_ops [in] importer operations for the > > attachment > > - * @importer_priv [in] importer private pointer for the > > attachment > > + * @importer_ops: [in] importer operations for the > > attachment > > + * @importer_priv: [in] importer private pointer for the > > attachment > > * > > * Returns struct dma_buf_attachment pointer for this attachment. > > Attachments > > * must be cleaned up by calling dma_buf_detach(). > > > > Sumit said that he would be applying my patch from April 7: > https://lore.kernel.org/linux-media/7bcbe6fe-0b4b-87da-d003-b68a26eb4cf0@infradead.org/ > > thanks. Sorry. I didn't check if the patch has already been sent. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A868C83009 for ; Thu, 30 Apr 2020 02:27:30 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9BDA208E0 for ; Thu, 30 Apr 2020 02:27:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="StXRVF2Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9BDA208E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=massaru.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C658E87D42; Thu, 30 Apr 2020 02:27:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CMf7uCg8OvCS; Thu, 30 Apr 2020 02:27:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 4490F87CA9; Thu, 30 Apr 2020 02:27:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2D3D8C0865; Thu, 30 Apr 2020 02:27:29 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7FAA6C0172 for ; Thu, 30 Apr 2020 02:27:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6C1EC203DC for ; Thu, 30 Apr 2020 02:27:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tI-Y+aY6Idqu for ; Thu, 30 Apr 2020 02:27:27 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by silver.osuosl.org (Postfix) with ESMTPS id 0F2271FC94 for ; Thu, 30 Apr 2020 02:27:27 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id 23so4324852qkf.0 for ; Wed, 29 Apr 2020 19:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=n0ueUL4qNH47b8rihpaXCJX1CS3A2QwjcGlCkj6DNLU=; b=StXRVF2Z/oF8mgEHbwGRd4ZgjZsl1Cy/jpVXd7mPocE9mQASuyBOR1afSdGwqz+pLD TLSZZ6hrfL900AHs6UFdkzuJ6T1ZIk+8KDQvcRKfkMf6iqskQGzMHwIcyp0KTBN/B3Jr g3/ic6KlxS4zOurl1rvIPyzp3eTCZukVKBygeVeFutnK0wkK+eLJKsoIADyrDo/uCvih rTNF99Bba52PPEijHtMcy1tXNvF6zHwU2dZvDJkYaxB48lBe5mwH4Ei+O/6Idefys5Rh Cmsk5oB1YL4dIxX9vuDKpKwwnFbv6l0RYfgogeXgN9var+eGCXLr6FRuw71Dv55AOOnH qk5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=n0ueUL4qNH47b8rihpaXCJX1CS3A2QwjcGlCkj6DNLU=; b=Lkv+gXm5/EPHPNVAal9XrE/sgkBhL/vLjVxGI7d9TVp3SeVCMhdlMyabfPaN68cuCe /mlPCp5MJxUClACkodeciR4FxZ6+3VLHFMJTWnCTmrul2XnRQhAX+G4cOmvcFDeBxlvE gXbMdYuaz2m1zKXk+tVoXfKPqbbBcGw2fdBFNNlP3GGUs75pq/veOJW4AXAyTr0Gdo8p 2Z+km92ZBbdI0u3hrQ0G3tklWesCHM/DNAII/k3mitoGlDnbW1LiU7VOcZYGmDXRWeRJ hQJpubHiHvlMkG/8sO0E5gLv7PhBta8p2Deg1TIuwa4b0h/qKmH6vaRE5JQnJZy4T+7o VDIQ== X-Gm-Message-State: AGi0PuY0GFmS6yGfL/eiEbvn3naGNGZYfn5QKfs36ZNZxldl2gvkkVfj kBsvyMyB242wacGcg0tobU0dlA== X-Google-Smtp-Source: APiQypJIgieYBZmgtgtmw8KT3AWQ292kizhBLwc90lYViUzaNYyqOUctQH/KIfh3FW1L9bc3b6KCrg== X-Received: by 2002:a37:a312:: with SMTP id m18mr1455117qke.251.1588213645884; Wed, 29 Apr 2020 19:27:25 -0700 (PDT) Received: from bbking.lan ([2804:14c:4a5:36c::cd2]) by smtp.gmail.com with ESMTPSA id o33sm953420qtj.62.2020.04.29.19.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 19:27:25 -0700 (PDT) Message-ID: <0463c90cfbe2036235010c5f8b92af6a96c20f74.camel@massaru.org> From: Vitor Massaru Iha To: Randy Dunlap , dri-devel@lists.freedesktop.org Date: Wed, 29 Apr 2020 23:27:22 -0300 In-Reply-To: References: <20200430015930.32224-1-vitor@massaru.org> User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Cc: brendanhiggins@google.com, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-kernel-mentees@lists.linuxfoundation.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > Add missed ":" on kernel-doc function parameter. > > > > This patch fixes this warnings from `make htmldocs`: > > ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or > > member 'importer_ops' not described in 'dma_buf_dynamic_attach' > > ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or > > member 'importer_priv' not described in 'dma_buf_dynamic_attach' > > > > Signed-off-by: Vitor Massaru Iha > > --- > > drivers/dma-buf/dma-buf.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > > index ccc9eda1bc28..0756d2155745 100644 > > --- a/drivers/dma-buf/dma-buf.c > > +++ b/drivers/dma-buf/dma-buf.c > > @@ -655,8 +655,8 @@ EXPORT_SYMBOL_GPL(dma_buf_put); > > * calls attach() of dma_buf_ops to allow device-specific attach > > functionality > > * @dmabuf: [in] buffer to attach device to. > > * @dev: [in] device to be attached. > > - * @importer_ops [in] importer operations for the > > attachment > > - * @importer_priv [in] importer private pointer for the > > attachment > > + * @importer_ops: [in] importer operations for the > > attachment > > + * @importer_priv: [in] importer private pointer for the > > attachment > > * > > * Returns struct dma_buf_attachment pointer for this attachment. > > Attachments > > * must be cleaned up by calling dma_buf_detach(). > > > > Sumit said that he would be applying my patch from April 7: > https://lore.kernel.org/linux-media/7bcbe6fe-0b4b-87da-d003-b68a26eb4cf0@infradead.org/ > > thanks. Sorry. I didn't check if the patch has already been sent. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7C2C83006 for ; Thu, 30 Apr 2020 02:27:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5ED02083B for ; Thu, 30 Apr 2020 02:27:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="StXRVF2Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5ED02083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=massaru.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DE1B6E432; Thu, 30 Apr 2020 02:27:28 +0000 (UTC) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DB5B6E432 for ; Thu, 30 Apr 2020 02:27:26 +0000 (UTC) Received: by mail-qk1-x741.google.com with SMTP id m67so4262599qke.12 for ; Wed, 29 Apr 2020 19:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=n0ueUL4qNH47b8rihpaXCJX1CS3A2QwjcGlCkj6DNLU=; b=StXRVF2Z/oF8mgEHbwGRd4ZgjZsl1Cy/jpVXd7mPocE9mQASuyBOR1afSdGwqz+pLD TLSZZ6hrfL900AHs6UFdkzuJ6T1ZIk+8KDQvcRKfkMf6iqskQGzMHwIcyp0KTBN/B3Jr g3/ic6KlxS4zOurl1rvIPyzp3eTCZukVKBygeVeFutnK0wkK+eLJKsoIADyrDo/uCvih rTNF99Bba52PPEijHtMcy1tXNvF6zHwU2dZvDJkYaxB48lBe5mwH4Ei+O/6Idefys5Rh Cmsk5oB1YL4dIxX9vuDKpKwwnFbv6l0RYfgogeXgN9var+eGCXLr6FRuw71Dv55AOOnH qk5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=n0ueUL4qNH47b8rihpaXCJX1CS3A2QwjcGlCkj6DNLU=; b=JFyA7Fyjp/R4U57/urW+WX3kbWIskdZnS5yeznGNADO8tqdmm2OuJPyUOzVEj7hFzD 3ba+/4KObchoqfft5HkCgFOYaQmQl3jxZZ1XFD0hw28Qjdk4K+jb5fxVH2HE+cLaUUKN D9i2/QbwL03VS9QzpuWADOwR7Xq7y9QtEmtzdQbHzxIhCCPFgT/iCpeL7zVt5/1mqPow gYLJAyJEjq/iRyO7ZP87w8fFInSkFjpnLZjwnxSfl2oRt//eSzHMcKPCrTdooLRAXZQJ WPcf4ghCjLJmG9l4o7l93I2xz/pQdCNx/0Euf8aRT4fx4fp/Ttqp9j03XFWp1oGfLQ1j dWKQ== X-Gm-Message-State: AGi0PuahsKsuBuqV3g4lPxLlUpR/hrl0RxQEDACXLZ5OKP67+8qndSdg 6gm37XVYC3bBW6kj3CEvK+ju7g== X-Google-Smtp-Source: APiQypJIgieYBZmgtgtmw8KT3AWQ292kizhBLwc90lYViUzaNYyqOUctQH/KIfh3FW1L9bc3b6KCrg== X-Received: by 2002:a37:a312:: with SMTP id m18mr1455117qke.251.1588213645884; Wed, 29 Apr 2020 19:27:25 -0700 (PDT) Received: from bbking.lan ([2804:14c:4a5:36c::cd2]) by smtp.gmail.com with ESMTPSA id o33sm953420qtj.62.2020.04.29.19.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 19:27:25 -0700 (PDT) Message-ID: <0463c90cfbe2036235010c5f8b92af6a96c20f74.camel@massaru.org> Subject: Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings From: Vitor Massaru Iha To: Randy Dunlap , dri-devel@lists.freedesktop.org Date: Wed, 29 Apr 2020 23:27:22 -0300 In-Reply-To: References: <20200430015930.32224-1-vitor@massaru.org> User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: brendanhiggins@google.com, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > Add missed ":" on kernel-doc function parameter. > > > > This patch fixes this warnings from `make htmldocs`: > > ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or > > member 'importer_ops' not described in 'dma_buf_dynamic_attach' > > ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or > > member 'importer_priv' not described in 'dma_buf_dynamic_attach' > > > > Signed-off-by: Vitor Massaru Iha > > --- > > drivers/dma-buf/dma-buf.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > > index ccc9eda1bc28..0756d2155745 100644 > > --- a/drivers/dma-buf/dma-buf.c > > +++ b/drivers/dma-buf/dma-buf.c > > @@ -655,8 +655,8 @@ EXPORT_SYMBOL_GPL(dma_buf_put); > > * calls attach() of dma_buf_ops to allow device-specific attach > > functionality > > * @dmabuf: [in] buffer to attach device to. > > * @dev: [in] device to be attached. > > - * @importer_ops [in] importer operations for the > > attachment > > - * @importer_priv [in] importer private pointer for the > > attachment > > + * @importer_ops: [in] importer operations for the > > attachment > > + * @importer_priv: [in] importer private pointer for the > > attachment > > * > > * Returns struct dma_buf_attachment pointer for this attachment. > > Attachments > > * must be cleaned up by calling dma_buf_detach(). > > > > Sumit said that he would be applying my patch from April 7: > https://lore.kernel.org/linux-media/7bcbe6fe-0b4b-87da-d003-b68a26eb4cf0@infradead.org/ > > thanks. Sorry. I didn't check if the patch has already been sent. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel