From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39319C433DF for ; Wed, 12 Aug 2020 16:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EED5520771 for ; Wed, 12 Aug 2020 16:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbgHLQkJ convert rfc822-to-8bit (ORCPT ); Wed, 12 Aug 2020 12:40:09 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59809 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbgHLQkE (ORCPT ); Wed, 12 Aug 2020 12:40:04 -0400 Received: from mail-pg1-f199.google.com ([209.85.215.199]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k5tnF-0006GB-DC for linux-kernel@vger.kernel.org; Wed, 12 Aug 2020 16:40:01 +0000 Received: by mail-pg1-f199.google.com with SMTP id 36so1981300pgz.18 for ; Wed, 12 Aug 2020 09:40:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6Ji1lqucG/grb2OVN+O0IrjUWDOjIPmMeJi8EGBOR3U=; b=Y4JbbOJK3/oI7lFKWIsUx+kIuTB6m186iEH0W3QajOttOeLQj+w0dJ5aR4lafw5BOE enJ3+jbxRaJa/SBlK9hyeFPdFHeApbNrh+Gxv/XpikBRScnxZ1SVoPdCvVzOTJcLAhnK mURmzvTqrWoE1Gm22vbOOFWqflUSvpAhRxn7W5iHxSp7zg36y1XjXu5eeHnKxz1xpkBW auIkYC7vZo+CgQnqjGwzfq/Le8rpVFT7Zc+5vqPtqUAJn00yZvsj9MkAsrV/sSIIg4iE SS/3l/XuUo4XWCXE3SEWwDbyd8+cNsii7BoN36kGjqveYNueQDY7V+fuy822NHPqSNjF KPbQ== X-Gm-Message-State: AOAM532BKmHN1VXn7gys1p9hZX6jtE5CAZtL1feeHgY1A9fWtJl01FkP ic24WmaAX2tjAHhd2QndVIOZQdVeQULvNZPfZs4GqwEts6qJP3WnLYolL78qYI6kTDc30nHYtuf 0tICWd2NumhDRmZFgIriYc0FFlsdCFWjJPqzfKYdpaw== X-Received: by 2002:a17:90b:817:: with SMTP id bk23mr886008pjb.46.1597250400073; Wed, 12 Aug 2020 09:40:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw53UL6r2FJ490XaYZR/YirtLM+MEb+vxIbXVyQDwdw7BkTzweu8CBj8oB5aCzPKtgJexKnhA== X-Received: by 2002:a17:90b:817:: with SMTP id bk23mr885980pjb.46.1597250399735; Wed, 12 Aug 2020 09:39:59 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id p127sm2835148pfb.17.2020.08.12.09.39.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Aug 2020 09:39:59 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop From: Kai-Heng Feng In-Reply-To: Date: Thu, 13 Aug 2020 00:39:56 +0800 Cc: tiwai@suse.com, Jaroslav Kysela , Kai Vehmanen , Nikhil Mahale , Pierre-Louis Bossart , Aaron Plattner , Harsha Priya , "moderated list:SOUND" , open list Content-Transfer-Encoding: 8BIT Message-Id: <0466883E-8F02-4226-B153-F34558FC3A4A@canonical.com> References: <20200811095336.32396-1-kai.heng.feng@canonical.com> <44573652-9ECF-4EC5-A234-DBB21FC90CC7@canonical.com> To: Takashi Iwai X-Mailer: Apple Mail (2.3608.120.23.2.1) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Aug 12, 2020, at 23:47, Takashi Iwai wrote: > > On Wed, 12 Aug 2020 17:43:27 +0200, > Kai-Heng Feng wrote: >> >> Hi, >> >>> On Aug 11, 2020, at 17:53, Kai-Heng Feng wrote: >>> >>> There's another HP desktop has buggy BIOS which flags the Port >>> Connectivity bit as no connection. >>> >>> Apply force connectivity quirk to enable DP/HDMI audio. >>> >>> Signed-off-by: Kai-Heng Feng >> >> I guess this patch was omitted as well... > > Not omitted but applied to a wrong internal branch, sorry. > Now I rebased to the proper branch and pushed out. Thanks a lot! Kai-Heng > > > thanks, > > Takashi > >> >> Kai-Heng >> >>> --- >>> sound/pci/hda/patch_hdmi.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c >>> index 4bbd12d3b1b5..b8c8490e568b 100644 >>> --- a/sound/pci/hda/patch_hdmi.c >>> +++ b/sound/pci/hda/patch_hdmi.c >>> @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) >>> } >>> >>> static const struct snd_pci_quirk force_connect_list[] = { >>> + SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), >>> SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), >>> {} >>> }; >>> -- >>> 2.17.1 >>> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970D1C433E0 for ; Wed, 12 Aug 2020 16:41:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C72A20771 for ; Wed, 12 Aug 2020 16:41:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="avvjd08K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C72A20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A4E061667; Wed, 12 Aug 2020 18:40:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A4E061667 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597250465; bh=qu/0wH3u3RAimZCQbqL6DgAdbEKz7BJ8/YGq/QLFClY=; h=Subject:From:In-Reply-To:Date:References:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=avvjd08K2qdYZQ4IiLFpFwnVXU+ZWgbKNTOOZtidmydiFDDiVa0LUysREnzsScZRY t/vsRuKhLO4G++k6BnblpDjZe+RfQUntTM9xbB68aclzz/1eb+NqE8yy+EvT/pSl47 Y2xVmxMco3xpkCHL6faBy6ZhUnGT4yrjMqx4AdMU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 19D2DF8022D; Wed, 12 Aug 2020 18:40:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BB012F80245; Wed, 12 Aug 2020 18:40:12 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B5BDAF801DB for ; Wed, 12 Aug 2020 18:40:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B5BDAF801DB Received: from mail-pf1-f200.google.com ([209.85.210.200]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k5tnF-0006GI-Ip for alsa-devel@alsa-project.org; Wed, 12 Aug 2020 16:40:01 +0000 Received: by mail-pf1-f200.google.com with SMTP id 19so2205013pfu.20 for ; Wed, 12 Aug 2020 09:40:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6Ji1lqucG/grb2OVN+O0IrjUWDOjIPmMeJi8EGBOR3U=; b=Ggs4PIaZPOY4s01XLZsZF9rodAlnEPLDYT4LJTO0J6d3Z+a//TyFD5/ZSSm2xC3VTF 38aY1I4GIe30ABQzn8fcctl/MpspoN45giuVoz0nrfJYOVwDk/koLSyiUpWmoARvIN/N fcYXj750sV5U3VTNsKGuO7bPxMnyC/0fEuVVm/jTRoVeLO3fZ/oXBjHoaMWgAAjihe+t 5i9VAyC+ynVZB9P/hf7/YGdrNvQWXErCr4ynDeh0CvAAnV0V/xeh5WaBCrXbUd9NzQ7V anhlLCr4GXUSXcolqHcB3FAGLuqayht/bCmD/hvSMt++6LxBUDZ4CoNZQ9GRrBMF+Y6v QLFw== X-Gm-Message-State: AOAM533pP8rjY6wTJwPIzorISBOmVu517MAacgZoLCeSCeu2Rv4b5CuK u5nslSNIUtSrflM/0RvQr1W2ksxt6Ls9u6wG0KtTDUIanlUwlyIUm1zcwY6q1dbnzjOFrKpQsUn N8G3qI7eqKY42bfoKlXRkAVtICEw5X9KMUNlYOP+0 X-Received: by 2002:a17:90b:817:: with SMTP id bk23mr886024pjb.46.1597250400226; Wed, 12 Aug 2020 09:40:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw53UL6r2FJ490XaYZR/YirtLM+MEb+vxIbXVyQDwdw7BkTzweu8CBj8oB5aCzPKtgJexKnhA== X-Received: by 2002:a17:90b:817:: with SMTP id bk23mr885980pjb.46.1597250399735; Wed, 12 Aug 2020 09:39:59 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id p127sm2835148pfb.17.2020.08.12.09.39.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Aug 2020 09:39:59 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop From: Kai-Heng Feng In-Reply-To: Date: Thu, 13 Aug 2020 00:39:56 +0800 Content-Transfer-Encoding: quoted-printable Message-Id: <0466883E-8F02-4226-B153-F34558FC3A4A@canonical.com> References: <20200811095336.32396-1-kai.heng.feng@canonical.com> <44573652-9ECF-4EC5-A234-DBB21FC90CC7@canonical.com> To: Takashi Iwai X-Mailer: Apple Mail (2.3608.120.23.2.1) Cc: "moderated list:SOUND" , Nikhil Mahale , Kai Vehmanen , Aaron Plattner , Harsha Priya , open list , Pierre-Louis Bossart , tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > On Aug 12, 2020, at 23:47, Takashi Iwai wrote: >=20 > On Wed, 12 Aug 2020 17:43:27 +0200, > Kai-Heng Feng wrote: >>=20 >> Hi, >>=20 >>> On Aug 11, 2020, at 17:53, Kai-Heng Feng = wrote: >>>=20 >>> There's another HP desktop has buggy BIOS which flags the Port >>> Connectivity bit as no connection. >>>=20 >>> Apply force connectivity quirk to enable DP/HDMI audio. >>>=20 >>> Signed-off-by: Kai-Heng Feng >>=20 >> I guess this patch was omitted as well... >=20 > Not omitted but applied to a wrong internal branch, sorry. > Now I rebased to the proper branch and pushed out. Thanks a lot! Kai-Heng >=20 >=20 > thanks, >=20 > Takashi >=20 >>=20 >> Kai-Heng >>=20 >>> --- >>> sound/pci/hda/patch_hdmi.c | 1 + >>> 1 file changed, 1 insertion(+) >>>=20 >>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c >>> index 4bbd12d3b1b5..b8c8490e568b 100644 >>> --- a/sound/pci/hda/patch_hdmi.c >>> +++ b/sound/pci/hda/patch_hdmi.c >>> @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec = *codec, hda_nid_t cvt_nid) >>> } >>>=20 >>> static const struct snd_pci_quirk force_connect_list[] =3D { >>> + SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), >>> SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), >>> {} >>> }; >>> --=20 >>> 2.17.1 >>>=20 >>=20