From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 523B8C2D0E4 for ; Mon, 23 Nov 2020 14:15:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9791E20757 for ; Mon, 23 Nov 2020 14:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BFzvW1MQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388755AbgKWOOn (ORCPT ); Mon, 23 Nov 2020 09:14:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729562AbgKWOOn (ORCPT ); Mon, 23 Nov 2020 09:14:43 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5B90C0613CF; Mon, 23 Nov 2020 06:14:42 -0800 (PST) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B9302A4; Mon, 23 Nov 2020 15:14:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1606140879; bh=cqYcWBxxRdiroukACA2GX9TWCAK8fr3As9+XxoGpe+M=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BFzvW1MQAi7HgaIHuns7KsQnWOMxnzBgzsrmjdc3GuhwM78yuatk8YEvJcmwpmFZt emgt/3AbXYrfQL2bFZ3X8d0KPrWVN/a/mBAWhSPUy3ADEv3FkDsIBKBcuGnc39TGzr ncPYmVsn4aMNV0DZoLDD/CLCsg2GK+6W4amVhtRY= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH 1/2] media: max9271: Fix GPIO enable/disable To: Jacopo Mondi , laurent.pinchart+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201120161529.236447-1-jacopo+renesas@jmondi.org> <20201120161529.236447-2-jacopo+renesas@jmondi.org> From: Kieran Bingham Organization: Ideas on Board Message-ID: <04709485-b438-d169-64b6-beb61d22d562@ideasonboard.com> Date: Mon, 23 Nov 2020 14:14:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201120161529.236447-2-jacopo+renesas@jmondi.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On 20/11/2020 16:15, Jacopo Mondi wrote: > Fix GPIO enable/disable operations which wrongly read the 0x0f register > to obtain the current mask of the enabled lines instead of using > the correct 0x0e register. > > Also fix access to bit 0 of the register which is marked as reserved. > > Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver") > Signed-off-by: Jacopo Mondi Took me a few reads of this and the datasheet to be sure :S But now I am :-D Reviewed-by: Kieran Bingham > --- > drivers/media/i2c/max9271.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c > index 0f6f7a092a46..c247db569bab 100644 > --- a/drivers/media/i2c/max9271.c > +++ b/drivers/media/i2c/max9271.c > @@ -223,12 +223,12 @@ int max9271_enable_gpios(struct max9271_device *dev, u8 gpio_mask) > { > int ret; > > - ret = max9271_read(dev, 0x0f); > + ret = max9271_read(dev, 0x0e); > if (ret < 0) > return 0; > > /* BIT(0) reserved: GPO is always enabled. */ > - ret |= gpio_mask | BIT(0); > + ret |= (gpio_mask & ~BIT(0)); > ret = max9271_write(dev, 0x0e, ret); > if (ret < 0) { > dev_err(&dev->client->dev, "Failed to enable gpio (%d)\n", ret); > @@ -245,12 +245,12 @@ int max9271_disable_gpios(struct max9271_device *dev, u8 gpio_mask) > { > int ret; > > - ret = max9271_read(dev, 0x0f); > + ret = max9271_read(dev, 0x0e); > if (ret < 0) > return 0; > > /* BIT(0) reserved: GPO cannot be disabled */ > - ret &= (~gpio_mask | BIT(0)); > + ret &= ~(gpio_mask | BIT(0)); > ret = max9271_write(dev, 0x0e, ret); > if (ret < 0) { > dev_err(&dev->client->dev, "Failed to disable gpio (%d)\n", ret); >