Thank you for quick reply . Shall I send it with v2 with adding commit log 
information?




On Wednesday, September 14, 2016 at 2:34:07 PM UTC+5:30, Vaishali Thakkar 
wrote:
>
> Hi, 
>
> On Wed, Sep 14, 2016 at 2:28 PM, Sandhya Bankar 
> <bankarsa...@gmail.com <javascript:>> wrote: 
> > Use x instead of x != NULL. 
>
> Commit log should contain the information about why doing this change is 
> good 
> instead of what you are doing. Also, if you have used any tool for 
> detecting or 
> solving the issue then probably writing something like 'Issue found using 
> x' 
> would be useful. :) 
>
> Thanks 
>
> > Signed-off-by: Sandhya Bankar <bankarsa...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/speakup/fakekey.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> > 
> > diff --git a/drivers/staging/speakup/fakekey.c 
> b/drivers/staging/speakup/fakekey.c 
> > index 8f058b4..032b936 100644 
> > --- a/drivers/staging/speakup/fakekey.c 
> > +++ b/drivers/staging/speakup/fakekey.c 
> > @@ -56,7 +56,7 @@ int speakup_add_virtual_keyboard(void) 
> > 
> >  void speakup_remove_virtual_keyboard(void) 
> >  { 
> > -       if (virt_keyboard != NULL) { 
> > +       if (virt_keyboard) { 
> >                 input_unregister_device(virt_keyboard); 
> >                 virt_keyboard = NULL; 
> >         } 
> > -- 
> > 1.8.2.3 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20160914085822.GA2558%40sandhya. 
>
> > For more options, visit https://groups.google.com/d/optout. 
>
>
>
> -- 
> Vaishali 
> http://vaishalithakkar.in/ 
>