From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH] f2fs: avoid unnecessary fg_gc Date: Fri, 24 Feb 2017 18:28:18 +0800 Message-ID: <0486c0d4-541c-ee21-c598-6656a291a274@huawei.com> References: <20170224100135.70000-1-houpengyang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1chD7O-0003E2-Fy for linux-f2fs-devel@lists.sourceforge.net; Fri, 24 Feb 2017 10:28:54 +0000 Received: from [45.249.212.187] (helo=dggrg01-dlp.huawei.com) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1chD7M-0007Wt-FU for linux-f2fs-devel@lists.sourceforge.net; Fri, 24 Feb 2017 10:28:54 +0000 In-Reply-To: <20170224100135.70000-1-houpengyang@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Hou Pengyang , jaegeuk@kernel.org Cc: guoweichao@huawei.com, linux-f2fs-devel@lists.sourceforge.net On 2017/2/24 18:01, Hou Pengyang wrote: > Under scenerio with large number of dirty nodes, and these nodes are flushed > in SSR mode during cp. enough free segemts now, no need to do fggc. We'd better break out of GC flow once we encounter cp error, so additional condition judgment is not needed. Thanks, > > Signed-off-by: Hou Pengyang > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 6c996e3..41bdfb7 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -959,7 +959,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background) > * garbage collections. > */ > ret = write_checkpoint(sbi, &cpc); > - if (ret) > + if (ret || !has_not_enough_free_secs(sbi, sec_freed, 0)) > goto stop; > } else if (gc_type == BG_GC && !background) { > /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */ > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot