From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCA6C4332F for ; Tue, 12 Oct 2021 09:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0636C6054F for ; Tue, 12 Oct 2021 09:31:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235746AbhJLJdc convert rfc822-to-8bit (ORCPT ); Tue, 12 Oct 2021 05:33:32 -0400 Received: from marcansoft.com ([212.63.210.85]:49154 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232657AbhJLJda (ORCPT ); Tue, 12 Oct 2021 05:33:30 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 429AA425CB; Tue, 12 Oct 2021 09:31:25 +0000 (UTC) Date: Tue, 12 Oct 2021 18:31:18 +0900 From: "Hector Martin \"marcan\"" To: Viresh Kumar CC: Sibi Sankar , Saravana Kannan , linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig , Sven Peter , Marc Zyngier , Mark Kettenis , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Catalin Marinas , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BRFC_PATCH_4/9=5D_opp=3A_core=3A_Don=27t_wa?= =?US-ASCII?Q?rn_if_required_OPP_device_does_not_exist?= User-Agent: K-9 Mail for Android In-Reply-To: <20211012092603.lkmhhjoo5v67wh44@vireshk-i7> References: <20211011165707.138157-1-marcan@marcan.st> <20211011165707.138157-5-marcan@marcan.st> <20211012032144.2ltlpat7orrsyr6k@vireshk-i7> <20211012055143.xmkbvhbnolspgjin@vireshk-i7> <20211012092603.lkmhhjoo5v67wh44@vireshk-i7> Message-ID: <049FC437-EC38-4FE5-891E-5E25960892CF@marcan.st> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021年10月12日 18:26:03 JST, Viresh Kumar wrote: >On 12-10-21, 14:57, Hector Martin wrote: >> >> This is arguably not entirely representative of how the hardware works, >> since technically the cluster switching couldn't care less what the memory >> controller is doing; it's a soft dependency, states that should be switched >> together but are not interdependent (in fact, the clock code does this >> unconditionally after the CPU p-state change, regardless of whether we're >> shifting up or down; this is, FWIW, the same order macOS uses, and it >> clearly doesn't matter which way you do it). > >Yeah, I understand what you are doing. But the current patch is >incorrect in the sense that it can cause a bug on other platforms. To >make this work, you should rather set this genpd as parent of CPU >devices (which are doing anyway since you are updating them with CPU's >DVFS). With that the clk driver won't be required to do the magic >behind the scene. > That doesn't work, though, because the CPUs aren't normal devices with runtime-pm. That was the first thing I tried :). If you think this *should* be made to work instead then I can try that. -- Hector Martin "marcan" (marcan@marcan.st) Public key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC41C433EF for ; Tue, 12 Oct 2021 09:33:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EB6861076 for ; Tue, 12 Oct 2021 09:33:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3EB6861076 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:References: In-Reply-To:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=14B1JvHtP3xQduqIyYnKbaYi/dnpt0aJ6ROofqGOvKE=; b=LCvJEUofTsRZX1 zYemJnnG2VF3EwHRpr7nMpmBw+Ugjys9puXnsgwsNzSUq0W6F7MiuXtcQQtwipNPm240OKrA0QfUZ yvDtTVl/VwKtiXVitDR3lXGu00TIvd5I+T9muDWpQNxJvzYKLAcFD+VgfWlQJwZrMVGjdNBwdf5So oonzKRvgYoqTcSZWPVOXIgpDWQ8icacSVehKV4VLRMMlAO8DWA9wDkqKEMT49w1522HpWfTxIU2tY mRtBAP0A1j3R/EhgSTCHILQQatAB6WLC3btEVeVM8Z0jUxqHNhaHfvgc61rlTL6fnWdkTO70I6I3D wBQVkNBhfMLoaQWgJXLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maE8G-00CGBv-C7; Tue, 12 Oct 2021 09:31:36 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maE8B-00CG9h-3m for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 09:31:33 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 429AA425CB; Tue, 12 Oct 2021 09:31:25 +0000 (UTC) Date: Tue, 12 Oct 2021 18:31:18 +0900 From: "Hector Martin \"marcan\"" To: Viresh Kumar CC: Sibi Sankar , Saravana Kannan , linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig , Sven Peter , Marc Zyngier , Mark Kettenis , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Catalin Marinas , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BRFC_PATCH_4/9=5D_opp=3A_core=3A_Don=27t_wa?= =?US-ASCII?Q?rn_if_required_OPP_device_does_not_exist?= User-Agent: K-9 Mail for Android In-Reply-To: <20211012092603.lkmhhjoo5v67wh44@vireshk-i7> References: <20211011165707.138157-1-marcan@marcan.st> <20211011165707.138157-5-marcan@marcan.st> <20211012032144.2ltlpat7orrsyr6k@vireshk-i7> <20211012055143.xmkbvhbnolspgjin@vireshk-i7> <20211012092603.lkmhhjoo5v67wh44@vireshk-i7> Message-ID: <049FC437-EC38-4FE5-891E-5E25960892CF@marcan.st> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_023131_352207_758A9B37 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIx5bm0MTDmnIgxMuaXpSAxODoyNjowMyBKU1QsIFZpcmVzaCBLdW1hciA8dmlyZXNo Lmt1bWFyQGxpbmFyby5vcmc+IHdyb3RlOgo+T24gMTItMTAtMjEsIDE0OjU3LCBIZWN0b3IgTWFy dGluIHdyb3RlOgo+PiAKPj4gVGhpcyBpcyBhcmd1YWJseSBub3QgZW50aXJlbHkgcmVwcmVzZW50 YXRpdmUgb2YgaG93IHRoZSBoYXJkd2FyZSB3b3JrcywKPj4gc2luY2UgdGVjaG5pY2FsbHkgdGhl IGNsdXN0ZXIgc3dpdGNoaW5nIGNvdWxkbid0IGNhcmUgbGVzcyB3aGF0IHRoZSBtZW1vcnkKPj4g Y29udHJvbGxlciBpcyBkb2luZzsgaXQncyBhIHNvZnQgZGVwZW5kZW5jeSwgc3RhdGVzIHRoYXQg c2hvdWxkIGJlIHN3aXRjaGVkCj4+IHRvZ2V0aGVyIGJ1dCBhcmUgbm90IGludGVyZGVwZW5kZW50 IChpbiBmYWN0LCB0aGUgY2xvY2sgY29kZSBkb2VzIHRoaXMKPj4gdW5jb25kaXRpb25hbGx5IGFm dGVyIHRoZSBDUFUgcC1zdGF0ZSBjaGFuZ2UsIHJlZ2FyZGxlc3Mgb2Ygd2hldGhlciB3ZSdyZQo+ PiBzaGlmdGluZyB1cCBvciBkb3duOyB0aGlzIGlzLCBGV0lXLCB0aGUgc2FtZSBvcmRlciBtYWNP UyB1c2VzLCBhbmQgaXQKPj4gY2xlYXJseSBkb2Vzbid0IG1hdHRlciB3aGljaCB3YXkgeW91IGRv IGl0KS4KPgo+WWVhaCwgSSB1bmRlcnN0YW5kIHdoYXQgeW91IGFyZSBkb2luZy4gQnV0IHRoZSBj dXJyZW50IHBhdGNoIGlzCj5pbmNvcnJlY3QgaW4gdGhlIHNlbnNlIHRoYXQgaXQgY2FuIGNhdXNl IGEgYnVnIG9uIG90aGVyIHBsYXRmb3Jtcy4gVG8KPm1ha2UgdGhpcyB3b3JrLCB5b3Ugc2hvdWxk IHJhdGhlciBzZXQgdGhpcyBnZW5wZCBhcyBwYXJlbnQgb2YgQ1BVCj5kZXZpY2VzICh3aGljaCBh cmUgZG9pbmcgYW55d2F5IHNpbmNlIHlvdSBhcmUgdXBkYXRpbmcgdGhlbSB3aXRoIENQVSdzCj5E VkZTKS4gV2l0aCB0aGF0IHRoZSBjbGsgZHJpdmVyIHdvbid0IGJlIHJlcXVpcmVkIHRvIGRvIHRo ZSBtYWdpYwo+YmVoaW5kIHRoZSBzY2VuZS4KPgoKVGhhdCBkb2Vzbid0IHdvcmssIHRob3VnaCwg YmVjYXVzZSB0aGUgQ1BVcyBhcmVuJ3Qgbm9ybWFsIGRldmljZXMgd2l0aCBydW50aW1lLXBtLiBU aGF0IHdhcyB0aGUgZmlyc3QgdGhpbmcgSSB0cmllZCA6KS4KCklmIHlvdSB0aGluayB0aGlzICpz aG91bGQqIGJlIG1hZGUgdG8gd29yayBpbnN0ZWFkIHRoZW4gSSBjYW4gdHJ5IHRoYXQuCgoKLS0g CkhlY3RvciBNYXJ0aW4gIm1hcmNhbiIgKG1hcmNhbkBtYXJjYW4uc3QpClB1YmxpYyBrZXk6IGh0 dHBzOi8vbXJjbi5zdC9wdWIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK