From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liran Alon Subject: Re: [PATCH V4 4/4] target-i386: add i440fx 0xcf8 port as coalesced_pio Date: Sun, 26 Aug 2018 02:29:35 +0300 Message-ID: <04A4CBE9-18A2-45FA-8530-F2EB658DE2F0@oracle.com> References: <1535199590-68475-1-git-send-email-peng.hao2@zte.com.cn> <1535199590-68475-5-git-send-email-peng.hao2@zte.com.cn> Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Cc: zhong.weidong@zte.com.cn, ehabkost@redhat.com, kvm@vger.kernel.org, rkrcmar@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, Paolo Bonzini To: Peng Hao Return-path: In-Reply-To: <1535199590-68475-5-git-send-email-peng.hao2@zte.com.cn> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org > On 25 Aug 2018, at 15:19, Peng Hao wrote: >=20 > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c > index 0e60834..da73743 100644 > --- a/hw/pci-host/piix.c > +++ b/hw/pci-host/piix.c > @@ -327,6 +327,10 @@ static void i440fx_pcihost_realize(DeviceState = *dev, Error **errp) >=20 > sysbus_add_io(sbd, 0xcfc, &s->data_mem); > sysbus_init_ioports(sbd, 0xcfc, 4); > + > + /* register i440fx 0xcf8 port as coalesced pio */ > + memory_region_set_flush_coalesced(&s->data_mem); > + memory_region_add_coalescing(&s->conf_mem, 0, 4); > } >=20 Is there a reason to not register this port as coalesced PIO also for = Q35? In q35_host_realize()? If not, I would do that as an extra patch as part of this series. -Liran From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fti05-00011h-Pw for qemu-devel@nongnu.org; Sat, 25 Aug 2018 19:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fti00-0003Hy-Rb for qemu-devel@nongnu.org; Sat, 25 Aug 2018 19:29:49 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:40040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fti00-0003GM-Es for qemu-devel@nongnu.org; Sat, 25 Aug 2018 19:29:44 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) From: Liran Alon In-Reply-To: <1535199590-68475-5-git-send-email-peng.hao2@zte.com.cn> Date: Sun, 26 Aug 2018 02:29:35 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <04A4CBE9-18A2-45FA-8530-F2EB658DE2F0@oracle.com> References: <1535199590-68475-1-git-send-email-peng.hao2@zte.com.cn> <1535199590-68475-5-git-send-email-peng.hao2@zte.com.cn> Subject: Re: [Qemu-devel] [PATCH V4 4/4] target-i386: add i440fx 0xcf8 port as coalesced_pio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peng Hao Cc: Paolo Bonzini , mst@redhat.com, ehabkost@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, zhong.weidong@zte.com.cn > On 25 Aug 2018, at 15:19, Peng Hao wrote: >=20 > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c > index 0e60834..da73743 100644 > --- a/hw/pci-host/piix.c > +++ b/hw/pci-host/piix.c > @@ -327,6 +327,10 @@ static void i440fx_pcihost_realize(DeviceState = *dev, Error **errp) >=20 > sysbus_add_io(sbd, 0xcfc, &s->data_mem); > sysbus_init_ioports(sbd, 0xcfc, 4); > + > + /* register i440fx 0xcf8 port as coalesced pio */ > + memory_region_set_flush_coalesced(&s->data_mem); > + memory_region_add_coalescing(&s->conf_mem, 0, 4); > } >=20 Is there a reason to not register this port as coalesced PIO also for = Q35? In q35_host_realize()? If not, I would do that as an extra patch as part of this series. -Liran