From: Phillip Wood <phillip.wood123@gmail.com>
To: Alexander Veit <alexander.veit@gmx.net>, git@vger.kernel.org
Cc: thomas.wolf@paranor.ch, "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: Re: Update to Git 2.34.0 breaks application
Date: Mon, 22 Nov 2021 21:43:51 +0000 [thread overview]
Message-ID: <04ab7301-ea34-476c-eae4-4044fef74b91@gmail.com> (raw)
In-Reply-To: <ee302c98-da27-da43-e684-c7ec8b225360@gmx.net>
Hi Alex
Thanks for the report
On 22/11/2021 08:42, Alexander Veit wrote:
> After an update from Git 2.25.1 to 2.34.0 the Java application that uses
> the Eclipse JGit library freezes.
>
> Strace suggests that the JVM receives a SIGTTOU from the child process
> "git config --system --edit" created with java.lang.ProcessBuilder.
>
> Upstream[1] has identified 3d411afa[2] as the possible commit that
> introduced the problem.
>
> The problem does not occur on all Linux systems.
I think the problem is possibly that git is calling tcsetattr() from a
background process group[1]. A possible fix would be to call tcgetpgrp()
after opening /dev/tty to see if git is in the foreground process group.
Best Wishes
Phillip
[1] https://www.man7.org/linux/man-pages/man3/tcsetattr.3p.html
> -Alex
>
> Environment:
> OS: Linux Mint 20
> Kernel: 5.4.0-90-generic
> Git 2.34.0 from http://ppa.launchpad.net/git-core/ppa/ubuntu
> Java: OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.10+9, mixed mode)
>
>
> Ref.:
> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=577358
> [2]
> https://github.com/git/git/commit/3d411afabc9a96f41d47c07d6af6edda3d29ec92#diff-01b59b6a71e42b9c1251ffbf76a1119b965be087a78538e80e01f9239c8e5880
>
next prev parent reply other threads:[~2021-11-22 21:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 8:42 Update to Git 2.34.0 breaks application Alexander Veit
2021-11-22 21:43 ` Phillip Wood [this message]
2021-11-22 22:28 ` [PATCH] editor: only save (and restore) the terminal if using a tty Carlo Marcelo Arenas Belón
2021-11-22 22:47 ` Junio C Hamano
2021-11-22 23:03 ` Junio C Hamano
2021-11-22 23:08 ` Junio C Hamano
2021-11-23 8:52 ` Alexander Veit
2021-11-23 9:08 ` Carlo Arenas
2021-11-22 23:39 ` Carlo Arenas
2021-11-23 17:35 ` Junio C Hamano
2021-11-24 13:29 ` Johannes Schindelin
2021-11-24 18:25 ` Carlo Arenas
2021-11-24 19:34 ` Junio C Hamano
2021-11-24 20:04 ` Carlo Arenas
2021-11-24 20:51 ` Junio C Hamano
2021-11-29 21:12 ` Johannes Schindelin
2021-11-23 11:05 ` Phillip Wood
2021-11-23 17:27 ` Junio C Hamano
2021-11-23 17:31 ` Carlo Arenas
2021-11-30 11:07 ` Phillip Wood
2021-12-01 5:12 ` Chris Torek
2021-12-01 19:33 ` Junio C Hamano
2021-12-02 0:38 ` Junio C Hamano
2021-12-02 1:51 ` Carlo Arenas
2021-12-02 14:48 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04ab7301-ea34-476c-eae4-4044fef74b91@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=alexander.veit@gmx.net \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=thomas.wolf@paranor.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.