From: Randy Dunlap <rdunlap@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: max3355: include mod_devicetable.h
Date: Wed, 11 Jul 2018 19:26:23 -0700 [thread overview]
Message-ID: <04b7a06c-5f85-2ac7-6b32-3a87c9b65f75@infradead.org> (raw)
In-Reply-To: <20180711155039.3600663-1-arnd@arndb.de>
On 07/11/2018 08:50 AM, Arnd Bergmann wrote:
> Another driver turned up that is missing linux/mod_devicetable.h after
> the device IDs are split out from linux/platform_device.h:
>
> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
> static const struct of_device_id max3355_match_table[] = {
>
> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sorry for the delay. I've been traveling.
And Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Greg, please add that to the char-misc tree that already has
> other related patches.
> ---
> drivers/extcon/extcon-max3355.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
> index 0aa410836f4e..1335a476bfec 100644
> --- a/drivers/extcon/extcon-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -14,6 +14,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
>
> struct max3355_data {
>
--
~Randy
prev parent reply other threads:[~2018-07-12 2:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180711155116epcas3p1d50af5ed86f7f55f607657d195492582@epcas3p1.samsung.com>
2018-07-11 15:50 ` [PATCH] extcon: max3355: include mod_devicetable.h Arnd Bergmann
2018-07-12 1:30 ` Chanwoo Choi
2018-07-12 1:31 ` Chanwoo Choi
2018-07-12 6:11 ` Greg Kroah-Hartman
2018-07-12 2:26 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b7a06c-5f85-2ac7-6b32-3a87c9b65f75@infradead.org \
--to=rdunlap@infradead.org \
--cc=arnd@arndb.de \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.