From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8409CC6FD1F for ; Tue, 14 Mar 2023 03:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229548AbjCNDva (ORCPT ); Mon, 13 Mar 2023 23:51:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjCNDv3 (ORCPT ); Mon, 13 Mar 2023 23:51:29 -0400 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08C52738AF; Mon, 13 Mar 2023 20:51:27 -0700 (PDT) Received: from 30.221.133.100(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VdqWb7B_1678765884) by smtp.aliyun-inc.com; Tue, 14 Mar 2023 11:51:25 +0800 Message-ID: <04cc510b-6d66-99b5-4fe8-f51729299574@linux.alibaba.com> Date: Tue, 14 Mar 2023 11:51:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 5/5] dmaengine: sprd: Don't set chancnt To: Jisheng Zhang , Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20230313170250.815-1-jszhang@kernel.org> <20230313170250.815-6-jszhang@kernel.org> From: Baolin Wang In-Reply-To: <20230313170250.815-6-jszhang@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 3/14/2023 1:02 AM, Jisheng Zhang wrote: > The dma framework will calculate the dma channels chancnt, setting it > outself is wrong. > > Signed-off-by: Jisheng Zhang LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/dma/sprd-dma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > index 474d3ba8ec9f..2b639adb48ba 100644 > --- a/drivers/dma/sprd-dma.c > +++ b/drivers/dma/sprd-dma.c > @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev) > > dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask); > sdev->total_chns = chn_count; > - sdev->dma_dev.chancnt = chn_count; > INIT_LIST_HEAD(&sdev->dma_dev.channels); > INIT_LIST_HEAD(&sdev->dma_dev.global_node); > sdev->dma_dev.dev = &pdev->dev; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1590C74A44 for ; Tue, 14 Mar 2023 03:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4eRfkDB5doEJe66jxCRNTrHk3O5bFr3MSJM9uzmujvI=; b=1PvRmhjOn24pIE iYkA2M3JlHKGO7z0LRT2qjBqXhbsPoWrqut3cWjtAMcQhA21VnVYTgTN61w1SaL1xyzhOge9S3bKW s7JW47rHGX9hOSoqmk4BXFekZzvjISHMRIJStzz++jd1WaNaahpGjMM8XR9BHxW3pgu2pLo56bYKB JAcY0jlEdUTpkTeMPw+5ezcrYNG9rLxh0y38lGvC10p+y0b5ZlkbiQbRuTU4A3SE1XFqiLWi69n5C YuJlHaVe1HLD+M5powMZV65Sy8oi8rVBzrYESP7aLetXh2Jc5GnAUB7t/JWEhmzoGE1r4vGzg/ZEw uM3MKuaVy0aNUummSAAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbvhZ-008uD3-Ml; Tue, 14 Mar 2023 03:51:53 +0000 Received: from out30-100.freemail.mail.aliyun.com ([115.124.30.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbvhG-008uAT-9L for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 03:51:50 +0000 Received: from 30.221.133.100(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VdqWb7B_1678765884) by smtp.aliyun-inc.com; Tue, 14 Mar 2023 11:51:25 +0800 Message-ID: <04cc510b-6d66-99b5-4fe8-f51729299574@linux.alibaba.com> Date: Tue, 14 Mar 2023 11:51:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 5/5] dmaengine: sprd: Don't set chancnt To: Jisheng Zhang , Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20230313170250.815-1-jszhang@kernel.org> <20230313170250.815-6-jszhang@kernel.org> From: Baolin Wang In-Reply-To: <20230313170250.815-6-jszhang@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_205148_498727_E0701CAE X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/14/2023 1:02 AM, Jisheng Zhang wrote: > The dma framework will calculate the dma channels chancnt, setting it > outself is wrong. > > Signed-off-by: Jisheng Zhang LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/dma/sprd-dma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > index 474d3ba8ec9f..2b639adb48ba 100644 > --- a/drivers/dma/sprd-dma.c > +++ b/drivers/dma/sprd-dma.c > @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev) > > dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask); > sdev->total_chns = chn_count; > - sdev->dma_dev.chancnt = chn_count; > INIT_LIST_HEAD(&sdev->dma_dev.channels); > INIT_LIST_HEAD(&sdev->dma_dev.global_node); > sdev->dma_dev.dev = &pdev->dev; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel