From: Andreas Naumann <dev@andin.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency
Date: Wed, 23 Jun 2021 12:00:25 +0200 [thread overview]
Message-ID: <04d2fb31-bc6c-4811-b8dc-6f9bf992fa95@andin.de> (raw)
In-Reply-To: <87lf7053fw.fsf@dell.be.48ers.dk>
Hi,
On 23.06.21 11:35, Peter Korsgaard wrote:
>>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
>
> > Hi Andreas,
> > On Wed, Jun 23 2021, Andreas Naumann wrote:
> >> gesftpserver needs python for the configure step.
> >>
> >> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
> >> ---
> >> package/gesftpserver/gesftpserver.mk | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/package/gesftpserver/gesftpserver.mk b/package/gesftpserver/gesftpserver.mk
> >> index 85511a3c97..c67fdb3f79 100644
> >> --- a/package/gesftpserver/gesftpserver.mk
> >> +++ b/package/gesftpserver/gesftpserver.mk
> >> @@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
> >> GESFTPSERVER_CONF_ENV = LIBS=-lpthread
> >>
> >> # overwrite openssh version if enabled
> >> -GESFTPSERVER_DEPENDENCIES += \
> >> +GESFTPSERVER_DEPENDENCIES += host-python \
>
> > Does host-python3 also work? We would probably drop python2 in the near
> > future.
So I just tried and yes, host-python3 does the job.
>
> Exactly. Looking at it, python also only seems to be used for the tests
> that we do not need to run, so it is a bit silly to have to pull in
> host-python3.
Ok, i didnt look why Python is needed. Also, I never saw the problem
until using per-package build. So buildtime-wise it's not a problem in
my case because we pull in host-python for some other package anyway.
I will check if I can get rid of the tests though.
regards,
Andreas
>
next prev parent reply other threads:[~2021-06-23 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 8:36 [Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency Andreas Naumann
2021-06-23 9:05 ` Baruch Siach
2021-06-23 9:35 ` Peter Korsgaard
2021-06-23 10:00 ` Andreas Naumann [this message]
2021-06-23 10:30 ` Andreas Naumann
2021-06-23 11:45 ` Peter Korsgaard
2021-06-24 12:34 ` Andreas Naumann
2021-07-03 20:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04d2fb31-bc6c-4811-b8dc-6f9bf992fa95@andin.de \
--to=dev@andin.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.