All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	kunit-dev@googlegroups.com, linux-media@vger.kernel.org,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Waiman Long <longman@redhat.com>,
	Boqun Feng <boqun.feng@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	jic23@kernel.org, linux@rasmusvillemoes.dk,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH v4 6/7] plist: Replace kernel.h with the necessary inclusions
Date: Thu, 07 Oct 2021 10:26:05 -0700	[thread overview]
Message-ID: <04ebb29ccb707bc37df2d3ddd684781114a1a62e.camel@perches.com> (raw)
In-Reply-To: <YV8sPjLn1jqLOm2H@smile.fi.intel.com>

On Thu, 2021-10-07 at 20:19 +0300, Andy Shevchenko wrote:
> On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote:
> > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote:
> > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > especially when there are circular dependencies are involved.
> > > 
> > > Replace kernel.h inclusion with the list of what is really being used.
> > []
> > > diff --git a/include/linux/plist.h b/include/linux/plist.h
> > []
> > > @@ -73,8 +73,11 @@
> > []
> > > +#include <asm/bug.h>
> > 
> > why asm/bug.h and not linux/bug.h ?
> 
> The direct inclusion is from that one. Why linux/bug?

A general guideline is to avoid asm includes.



  reply	other threads:[~2021-10-07 17:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 15:44 [PATCH v4 0/7] kernel.h further split Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 1/7] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 2/7] kernel.h: Split out container_of() and typeof_member() macros Andy Shevchenko
2021-10-07 15:54   ` Miguel Ojeda
2021-10-07 16:08     ` Andy Shevchenko
2021-10-07 16:27   ` Joe Perches
2021-10-07 16:47     ` Andy Shevchenko
2021-10-11  9:07     ` David Laight
2021-10-07 15:44 ` [PATCH v4 3/7] kunit: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 4/7] list.h: " Andy Shevchenko
2021-10-07 16:16   ` Jonathan Cameron
2021-10-07 16:21     ` Andy Shevchenko
2021-10-07 16:22       ` Andy Shevchenko
2021-10-07 17:29     ` Laurent Pinchart
2021-10-09  0:59       ` Joe Perches
2021-10-09  1:21         ` Laurent Pinchart
2021-10-07 15:44 ` [PATCH v4 5/7] llist: " Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 6/7] plist: " Andy Shevchenko
2021-10-07 17:12   ` Joe Perches
2021-10-07 17:19     ` Andy Shevchenko
2021-10-07 17:26       ` Joe Perches [this message]
2021-10-07 17:32         ` Andy Shevchenko
2021-10-07 17:46           ` Joe Perches
2021-10-07 15:44 ` [PATCH v4 7/7] media: entity: " Andy Shevchenko
2021-10-07 16:50   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04ebb29ccb707bc37df2d3ddd684781114a1a62e.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=boqun.feng@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=jic23@kernel.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=longman@redhat.com \
    --cc=mchehab@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=regressions@leemhuis.info \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.