From: Harry Wentland <harry.wentland@amd.com>
To: Fangzhi Zuo <Jerry.Zuo@amd.com>,
intel-gfx@lists.freedesktop.org, jani.nikula@intel.com
Cc: Nicholas.Kazlauskas@amd.com, wayne.lin@amd.com
Subject: Re: [Intel-gfx] [PATCH] drm/dp: Add Additional DP2 Headers
Date: Mon, 27 Sep 2021 11:12:10 -0400 [thread overview]
Message-ID: <05088c79-1c1d-c583-69d8-c9434c1622ac@amd.com> (raw)
In-Reply-To: <20210927143856.2214981-1-Jerry.Zuo@amd.com>
On 2021-09-27 10:38, Fangzhi Zuo wrote:
> Include FEC, DSC, Link Training related headers.
>
> Signed-off-by: Fangzhi Zuo <Jerry.Zuo@amd.com>
Please send this to dri-devel and amd-gfx as well.
> ---
The section after the '---' is not part of the commit
description. Please mention here that this patch is based
on top of the other DP2.0 header patches from Intel and
leave a link here, for context.
> include/drm/drm_dp_helper.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 1d5b3dbb6e56..bfd8e3e0171d 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -453,6 +453,7 @@ struct drm_panel;
> # define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
> # define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
> # define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
> +#define DP_FEC_CAPABILITY_1 0x091 /* 2.0 */
>
> /* DP-HDMI2.1 PCON DSC ENCODER SUPPORT */
> #define DP_PCON_DSC_ENCODER_CAP_SIZE 0xC /* 0x9E - 0x92 */
> @@ -537,6 +538,9 @@ struct drm_panel;
> #define DP_DSC_BRANCH_OVERALL_THROUGHPUT_1 0x0a1
> #define DP_DSC_BRANCH_MAX_LINE_WIDTH 0x0a2
>
> +/* DFP Capability Extension */
> +#define DP_DFP_CAPABILITY_EXTENSION_SUPPORT 0x0a3 /* 2.0 */
> +
> /* Link Configuration */
> #define DP_LINK_BW_SET 0x100
> # define DP_LINK_RATE_TABLE 0x00 /* eDP 1.4 */
> @@ -688,6 +692,7 @@ struct drm_panel;
>
> #define DP_DSC_ENABLE 0x160 /* DP 1.4 */
> # define DP_DECOMPRESSION_EN (1 << 0)
> +#define DP_DSC_CONFIGURATION 0x161 /* DP 2.0 */
>
> #define DP_PSR_EN_CFG 0x170 /* XXX 1.2? */
> # define DP_PSR_ENABLE BIT(0)
> @@ -743,6 +748,7 @@ struct drm_panel;
> # define DP_RECEIVE_PORT_0_STATUS (1 << 0)
> # define DP_RECEIVE_PORT_1_STATUS (1 << 1)
> # define DP_STREAM_REGENERATION_STATUS (1 << 2) /* 2.0 */
> +# define DP_INTRA_HOP_AUX_REPLY_INDICATION (1 << 3) /* 2.0 */
Are you sure this is DP 2.0? The DP2.0 spec has 'RESERVED'
bits after the STREAM_REGENERATION_STATUS.
>
> #define DP_ADJUST_REQUEST_LANE0_1 0x206
> #define DP_ADJUST_REQUEST_LANE2_3 0x207
> @@ -865,6 +871,8 @@ struct drm_panel;
> # define DP_PHY_TEST_PATTERN_80BIT_CUSTOM 0x4
> # define DP_PHY_TEST_PATTERN_CP2520 0x5
>
> +#define DP_PHY_SQUARE_PATTERN 0x249
> +
> #define DP_TEST_HBR2_SCRAMBLER_RESET 0x24A
> #define DP_TEST_80BIT_CUSTOM_PATTERN_7_0 0x250
> #define DP_TEST_80BIT_CUSTOM_PATTERN_15_8 0x251
> @@ -1109,6 +1117,18 @@ struct drm_panel;
> #define DP_128B132B_TRAINING_AUX_RD_INTERVAL 0x2216 /* 2.0 */
> # define DP_128B132B_TRAINING_AUX_RD_INTERVAL_MASK 0x7f
>
> +#define DP_TEST_264BIT_CUSTOM_PATTERN_7_0 0x2230
> +#define DP_TEST_264BIT_CUSTOM_PATTERN_263_256 0x2250
> +
> +/* DSC Extended Capability Branch Total DSC Resources */
> +#define DP_DSC_SUPPORT_AND_DECODER_COUNT 0x2260 /* 2.0 */
To align with the spec and make it easier to search this should be:
DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT
> +#define DP_DSC_MAX_SLICE_COUNT_AND_AGGREGATION_0 0x2270 /* 2.0 */
> +# define DP_DSC_DECODER_0_MAXIMUM_SLICE_COUNT_MASK (1 << 0)
> +# define DP_DSC_DECODER_0_AGGREGATION_SUPPORT_MASK (0b111 << 1)
> +# define DP_DSC_DECODER_0_AGGREGATION_SUPPORT_SHIFT 1
> +# define DP_DSC_DECODER_COUNT_MASK (0b111 << 5)
> +# define DP_DSC_DECODER_COUNT_SHIFT 5
> +
The spec seems to call these "DSC Decoder 1 Aggregation Support" and also
has a definition for "DSC Decoder 1 Maximum Slice Count"
Harry
> /* Protocol Converter Extension */
> /* HDMI CEC tunneling over AUX DP 1.3 section 5.3.3.3.1 DPCD 1.4+ */
> #define DP_CEC_TUNNELING_CAPABILITY 0x3000
>
prev parent reply other threads:[~2021-09-27 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 14:38 [Intel-gfx] [PATCH] drm/dp: Add Additional DP2 Headers Fangzhi Zuo
2021-09-27 15:12 ` Harry Wentland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05088c79-1c1d-c583-69d8-c9434c1622ac@amd.com \
--to=harry.wentland@amd.com \
--cc=Jerry.Zuo@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=wayne.lin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.