From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A366C433B4 for ; Sat, 15 May 2021 16:26:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE7A7600CD for ; Sat, 15 May 2021 16:26:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE7A7600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhx7W-0000tu-1h for qemu-devel@archiver.kernel.org; Sat, 15 May 2021 12:26:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhx6l-0008NF-QF for qemu-devel@nongnu.org; Sat, 15 May 2021 12:25:43 -0400 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:40942) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhx6k-0006jv-2I for qemu-devel@nongnu.org; Sat, 15 May 2021 12:25:43 -0400 Received: by mail-qk1-x72f.google.com with SMTP id f18so1930760qko.7 for ; Sat, 15 May 2021 09:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5YnQ3YIifzuU0VS0Vo8dZJ9XTMwwcIAepO0Y/B4psgo=; b=uLpV4m8QOTAv/aI74U5j7NPNXo4NKMV2KQp8F0sIokmxM7xscb9BynAvo3lD3yIziy xiOlOKZw61AlH/g6blQ12RMg+vUr3glCG4VhJxKT2hmMMXs49jqFn7z+cEkUVO6kvnJa JxdZ7/qX04MNr6TkpkRGbpvngM0+ipC2DTG08QMkFIdvRYBWFurO8WB7qENenAVANd6s WDm1vWlBtH8F0nm5QG4Tp3z5NVyyWyStJbbSGwrFW8bTApdLg8kwtlXQJzzg7NTxi/SI F9AGyI+tUzWidI9EBIdAfhIz7ctrYnvw1Wc6miTtXZs4/V3V2PPAdIVyGx/D60tbfYZ/ albw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5YnQ3YIifzuU0VS0Vo8dZJ9XTMwwcIAepO0Y/B4psgo=; b=DUvFgkOQgbK/G+W4eAWq98XB76HjkhExFWNeSecCzACTDAPSMFfTUYbQ7d9LfNWgZ+ 5pBpM48+TBxUj0FDalHDvWz1UDE5c60i0MCEQlH+YVgPwE7mL54mevWr/sQbOc+4M3X/ 2caSV1AIuupyaZ6A9RBeyLjX/CLo3JE6INH5TE35gDbWItiJNnxGNhTDGx2CJHBpn/tM pkR+1JyOWHN3ksnNkC+Zr2b+0uAPkFjSU0cShdJfN/OIa/76Y4crJAZn4lxiTFPoTlWZ ZwY+UmCK9R0AkV608XN/vPRkK1yD7KORX8BiBclVpz1Udqm1HaO2z4+h+zNvotV+IHGB MpUg== X-Gm-Message-State: AOAM5330/PIt5sgJUaoNccaJyXyaUe8NR7JIWTK9qF7U+z03rGPgaVCF hBCHk6t9RNohgk0sulVHrDzsEQ== X-Google-Smtp-Source: ABdhPJwX1zOFJyeK3FYUAH+98tZCFCHMv089ItLB/3fPXPGUXabFKUpRLp5lMbO2K0XWQeKoSpWWXA== X-Received: by 2002:a37:a8c6:: with SMTP id r189mr48996251qke.446.1621095940973; Sat, 15 May 2021 09:25:40 -0700 (PDT) Received: from [192.168.183.51] (163.189-204-200.bestelclientes.com.mx. [189.204.200.163]) by smtp.gmail.com with ESMTPSA id p190sm7286613qke.13.2021.05.15.09.25.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 May 2021 09:25:40 -0700 (PDT) Subject: Re: [PATCH v6 69/82] target/arm: Share table of sve load functions To: Peter Maydell References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-70-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <050cb717-1277-0edb-0f49-29a4f488d8c7@linaro.org> Date: Sat, 15 May 2021 11:25:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::72f; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x72f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/13/21 9:25 AM, Peter Maydell wrote: >> @@ -5551,7 +5547,9 @@ static void do_ldrq(DisasContext *s, int zt, int pg, TCGv_i64 addr, int msz) >> t_pg = tcg_temp_new_ptr(); >> tcg_gen_addi_ptr(t_pg, cpu_env, poff); >> >> - fns[s->be_data == MO_BE][msz](cpu_env, t_pg, addr, t_desc); >> + gen_helper_gvec_mem *fn >> + = ldr_fns[s->mte_active[0]][s->be_data == MO_BE][dtype][0]; >> + fn(cpu_env, t_pg, addr, t_desc); > > Previously we didn't take account of MTE state, and now we do. > Is this an intentional behaviour change? Amusing that I didn't even notice. > If it's fixing a bug, the commit message should say so. Yes, this is fixing a bug in LDRQ. r~