All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caz Yokoyama <Caz.Yokoyama@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain
Date: Thu, 21 Mar 2019 11:57:52 -0700	[thread overview]
Message-ID: <0510486c232067a8e95b7fb4049ca149794b07c3.camel@intel.com> (raw)
In-Reply-To: <155319373541.26447.10680934161260721211@skylake-alporthouse-com>

Reviewed-by: Yokoyama, Caz <caz.yokoyama@intel.com>
-caz

On Thu, 2019-03-21 at 18:42 +0000, Chris Wilson wrote:
> Quoting Chris Wilson (2019-03-21 18:38:53)
> > Quoting Caz Yokoyama (2019-03-21 18:41:10)
> > > inline
> > > -caz
> > > On Thu, 2019-03-21 at 07:37 +0000, Chris Wilson wrote:
> > > > 32 is too many for the likes of kbl, and in order to insert
> > > > that many
> > > 
> > > Not only kbl. ring_size is 25 on my cfl.
> > > 
> > > > requests into the ring requires us to declare the first few
> > > > hung --
> > > 
> > > The hung is not caused by 32. It is caused by accumulation of
> > > requests
> > > for all prime numbers.
> > 
> > Sure, but the design of the test is that we don't care for more
> > than
> > ring_size.
> 
> And you can't have more than ring_size requests without hanging on
> the
> spinner. If we pick the maximum that allows for a prime number larger
> than ring_size, it hangs irrespective of whether or not you remember
> to
> flush the lo.ctx in between.
> -Chris

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-03-21 18:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  7:37 [PATCH 1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain Chris Wilson
2019-03-21  7:37 ` [PATCH 2/2] drm/i915/selftests: Mark up preemption tests for hang detection Chris Wilson
2019-03-21  8:41 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain Patchwork
2019-03-21 17:07 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-21 18:41 ` [PATCH 1/2] " Caz Yokoyama
2019-03-21 18:38   ` Chris Wilson
2019-03-21 18:42     ` Chris Wilson
2019-03-21 18:57       ` Caz Yokoyama [this message]
2019-03-21 18:58     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0510486c232067a8e95b7fb4049ca149794b07c3.camel@intel.com \
    --to=caz.yokoyama@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.