All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] ubi: Add "skipcheck" command to set/clear this bit in the UBI volume hdr
Date: Tue, 17 Sep 2019 07:45:40 +0200	[thread overview]
Message-ID: <051048cf-bcf3-a46b-bf33-2574fdc9e786@denx.de> (raw)
In-Reply-To: <20190912144103.17261-3-sr@denx.de>

Hello Stefan,

Am 12.09.2019 um 16:41 schrieb Stefan Roese:
> U-Boot now supports the "skip_check" flag to optionally skip the CRC
> check at open time. Currently its only possible to set this bit upon
> UBI volume creation. But it might be very useful to also set this bit
> on already installed systems (e.g. field upgrade) to make also use of
> the boot-time decrease on those systems.
> 
> This patch now adds a new "ubi" command "ubi skipcheck" to set or clear
> this bit in the UBI volume header:
> 
> => ubi skipcheck rootfs0 on
> Setting skip_check on volume rootfs0
> 
> BTW: This saves approx. 10 seconds Linux bootup time on a MT7688 based
> target with 128MiB of SPI NAND.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Quentin Schulz <quentin.schulz@bootlin.com>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
>   cmd/ubi.c | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)

Reviewed-by: Heiko Schocher <hs@denx.de>

Could you please send a v2 with the suggestion from Andreas to add
some infos into doc/README.ubi?

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

  parent reply	other threads:[~2019-09-17  5:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 14:41 [U-Boot] [PATCH 1/3] ubi: provide a way to skip CRC checks Stefan Roese
2019-09-12 14:41 ` [U-Boot] [PATCH 2/3] ubi: Print skip_check in ubi_dump_vol_info() Stefan Roese
2019-09-17  5:39   ` Heiko Schocher
2019-10-16  8:59     ` Heiko Schocher
2019-09-12 14:41 ` [U-Boot] [PATCH 3/3] ubi: Add "skipcheck" command to set/clear this bit in the UBI volume hdr Stefan Roese
2019-09-13 21:11   ` Andreas Dannenberg
2019-09-17  5:45   ` Heiko Schocher [this message]
2019-09-17  5:54     ` Stefan Roese
2019-09-17  5:37 ` [U-Boot] [PATCH 1/3] ubi: provide a way to skip CRC checks Heiko Schocher
2019-10-16  8:59 ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=051048cf-bcf3-a46b-bf33-2574fdc9e786@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.