From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD7CC433E0 for ; Thu, 28 May 2020 18:32:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD6AD206A1 for ; Thu, 28 May 2020 18:32:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eDk2jA4X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD6AD206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeNKX-0007VZ-VV for qemu-devel@archiver.kernel.org; Thu, 28 May 2020 14:32:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeNJg-0006wg-UD for qemu-devel@nongnu.org; Thu, 28 May 2020 14:31:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22973 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jeNJe-0003az-Qj for qemu-devel@nongnu.org; Thu, 28 May 2020 14:31:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590690701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dz3M7Didl0d4WfPT86vsWMUqNGG7zNURfZUspMQXyjQ=; b=eDk2jA4XPQQ5UvY5zEVb6fJS8mBBshlgt6jGmeBtto8N2o5nEN+iU9jFXgqNgt59792maz zpwXj7o4mGV7mnVO02ax/SviNnvY61lIw24ZTzEVaME+ATNBGcyyflohXnLJVgX635cL6i pKefn5utDjnlIoT+DnzS2fMFfMaHQp8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-txKcrrpqMAOcxmNaXIhRNg-1; Thu, 28 May 2020 14:31:38 -0400 X-MC-Unique: txKcrrpqMAOcxmNaXIhRNg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 50CFE8005AA; Thu, 28 May 2020 18:31:37 +0000 (UTC) Received: from [10.3.112.88] (ovpn-112-88.phx2.redhat.com [10.3.112.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE4F6768C7; Thu, 28 May 2020 18:31:36 +0000 (UTC) Subject: Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon To: Kevin Wolf , qemu-block@nongnu.org References: <20200528153742.274164-1-kwolf@redhat.com> <20200528153742.274164-3-kwolf@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <051c6abe-9e82-1999-f050-23c973408b1e@redhat.com> Date: Thu, 28 May 2020 13:31:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200528153742.274164-3-kwolf@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 01:51:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/28/20 10:37 AM, Kevin Wolf wrote: > cur_mon really needs to be coroutine-local as soon as we move monitor > command handlers to coroutines and let them yield. As a first step, just > remove all direct accesses to cur_mon so that we can implement this in > the getter function later. > > Signed-off-by: Kevin Wolf > --- > +++ b/audio/wavcapture.c > @@ -1,5 +1,5 @@ > #include "qemu/osdep.h" > -#include "monitor/monitor.h" > +#include "qemu/qemu-print.h" > #include "qapi/error.h" > #include "qemu/error-report.h" > #include "audio.h" > @@ -94,9 +94,9 @@ static void wav_capture_info (void *opaque) > WAVState *wav = opaque; > char *path = wav->path; > > - monitor_printf (cur_mon, "Capturing audio(%d,%d,%d) to %s: %d bytes\n", > - wav->freq, wav->bits, wav->nchannels, > - path ? path : "", wav->bytes); > + qemu_printf("Capturing audio(%d,%d,%d) to %s: %d bytes\n", > + wav->freq, wav->bits, wav->nchannels, > + path ? path : "", wav->bytes); Why the change to qemu_printf() here instead of a call to monitor_cur() as is done in the rest of the patch? > +++ b/stubs/monitor-core.c > @@ -3,7 +3,10 @@ > #include "qemu-common.h" > #include "qapi/qapi-emit-events.h" > > -__thread Monitor *cur_mon; > +Monitor *monitor_cur(void) > +{ > + return NULL; > +} > monitor_set_cur() didn't need a stub? Odd, but I guess it's okay. Otherwise the patch looks fine to me. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org