Re: [GSoC] [PATCH v2 1/2] submodule--helper: introduce add-clone subcommand

From: Atharva Raykar <raykar.ath@gmail.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git <git@vger.kernel.org>,
	Christian Couder <christian.couder@gmail.com>,
	Shourya Shukla <shouryashukla.oo@gmail.com>,
	Prathamesh Chavan <pc44800@gmail.com>
Subject: Re: [GSoC] [PATCH v2 1/2] submodule--helper: introduce add-clone subcommand
Date: Wed, 9 Jun 2021 18:40:48 +0530	[thread overview]
Message-ID: <05339721-1CD6-4866-8A5E-368C9B379679@gmail.com> (raw)
In-Reply-To: <YMC8upoajZm0QQ5G@danh.dev>

On 09-Jun-2021, at 18:36, Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:
>>> 
>>> Overral I would replace the block inside capture_command with:
>>> 
>>> -----8<-----
>>> 	char *nextline;
>>> 	char *line = sb_remote_out.buf;
>>> 	while ((nextline = strchr(line, '\n')) != NULL) {
>>> 		size_t len = nextline - line;
>>> 		if (strip_suffix_mem(line, &len, "(fetch)"))
>>> 			fprintf(output, "  %.*s\n", (int)len, line);
> 
> Fix-up for my suggestion:
> 
> To be bug-for-bug with shell implementation, it should be:
> 
> 		if (strip_suffix_mem(line, &len, " (fetch)"))

That is very subtle, and I would have definitely missed it.
Thanks.