All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helen Koike <helen.koike@collabora.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] vimc: fill in bus_info in media_device_info
Date: Thu, 7 Feb 2019 13:15:27 -0200	[thread overview]
Message-ID: <0534435c-f999-f078-b274-988fe87ba14a@collabora.com> (raw)
In-Reply-To: <37987a95-dc03-aee7-57d3-d7a85cc2fc59@xs4all.nl>



On 1/30/19 11:43 AM, Hans Verkuil wrote:
> It is good practice to fill in bus_info.
> 
> Also just use 'platform:vimc' when filling in the bus_info in querycap:
> the bus_info has nothing to do with the video device name.
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Acked-by: Helen Koike <helen.koike@collabora.com>

Thanks
Helen

> ---
> diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c
> index aaeddf24b042..550aa426ae5e 100644
> --- a/drivers/media/platform/vimc/vimc-capture.c
> +++ b/drivers/media/platform/vimc/vimc-capture.c
> @@ -69,12 +69,10 @@ struct vimc_cap_buffer {
>  static int vimc_cap_querycap(struct file *file, void *priv,
>  			     struct v4l2_capability *cap)
>  {
> -	struct vimc_cap_device *vcap = video_drvdata(file);
> -
>  	strscpy(cap->driver, VIMC_PDEV_NAME, sizeof(cap->driver));
>  	strscpy(cap->card, KBUILD_MODNAME, sizeof(cap->card));
>  	snprintf(cap->bus_info, sizeof(cap->bus_info),
> -		 "platform:%s", vcap->vdev.v4l2_dev->name);
> +		 "platform:%s", VIMC_PDEV_NAME);
> 
>  	return 0;
>  }
> diff --git a/drivers/media/platform/vimc/vimc-core.c b/drivers/media/platform/vimc/vimc-core.c
> index bf19f1f9795e..c2fdf3ea67ed 100644
> --- a/drivers/media/platform/vimc/vimc-core.c
> +++ b/drivers/media/platform/vimc/vimc-core.c
> @@ -318,6 +318,8 @@ static int vimc_probe(struct platform_device *pdev)
>  	/* Initialize media device */
>  	strscpy(vimc->mdev.model, VIMC_MDEV_MODEL_NAME,
>  		sizeof(vimc->mdev.model));
> +	snprintf(vimc->mdev.bus_info, sizeof(vimc->mdev.bus_info),
> +		 "platform:%s", VIMC_PDEV_NAME);
>  	vimc->mdev.dev = &pdev->dev;
>  	media_device_init(&vimc->mdev);
> 

      reply	other threads:[~2019-02-07 15:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30 13:43 [PATCH] vimc: fill in bus_info in media_device_info Hans Verkuil
2019-02-07 15:15 ` Helen Koike [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0534435c-f999-f078-b274-988fe87ba14a@collabora.com \
    --to=helen.koike@collabora.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.