All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH u-boot] eth/r8152: update the firmware
Date: Thu, 4 Jun 2020 22:12:17 +0200	[thread overview]
Message-ID: <05394e4b-9994-aadd-bf68-ea8bb855a5c9@denx.de> (raw)
In-Reply-To: <ef8d554612ac4741a795fdbdc654195c@realtek.com>

On 6/4/20 5:45 AM, Hayes Wang wrote:
> Marek Vasut [mailto:marex at denx.de]
>> Sent: Tuesday, June 02, 2020 7:59 PM
> [...]
>>>>>> Can you be more specific about the problem you are fixing here ?
>>>>>> What is the problem ?
>>>>>
>>>>> There is low probability that the device may be lost when rebooting.
>>>>> Should I submit v2 to reword the commit message?
>>>>
>>>> Lost how ?
>>>
>>> USB enumeration may fail. The device would be at wrong state.
>>> I don't know detail about the hardware behavior.
>>
>> Is there any chance you can ask someone ? It would be real helpful to
>> know the details of the problem, in case someone runs into it, they
>> would know what is going on.
> 
> I get the following information.
> 
> 1.
> Our device has auto-installed driver feature - via switch CD-ROM/NIC
> mode. But in some corner cases, it would switch to CD-ROM unexpected.
> This issue results in Lan Function Disabled.
> 
> 2.
> While USB PHY transits to P3 from P0 due to the absent of transmitter
> control, it would issues undefined signal to its? link partner.
> Some Down Stream Port misidentify the undefined signal as wakeup
> signal. So the link state will not keep in suspend even the system
> is idle.

OK, then please add this into the commit message and send a V2, I'll
pick it then. Thanks!

      reply	other threads:[~2020-06-04 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  8:42 [PATCH u-boot] eth/r8152: update the firmware Hayes Wang
2020-06-01 16:45 ` Marek Vasut
2020-06-02  3:17   ` Hayes Wang
2020-06-02 11:02     ` Marek Vasut
2020-06-02 11:48       ` Hayes Wang
2020-06-02 11:58         ` Marek Vasut
2020-06-04  3:45           ` Hayes Wang
2020-06-04 20:12             ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05394e4b-9994-aadd-bf68-ea8bb855a5c9@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.