From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E8BC433FE for ; Wed, 10 Nov 2021 03:11:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A607611BF for ; Wed, 10 Nov 2021 03:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbhKJDOb (ORCPT ); Tue, 9 Nov 2021 22:14:31 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:54052 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229445AbhKJDOa (ORCPT ); Tue, 9 Nov 2021 22:14:30 -0500 X-UUID: 9a8cd1a9d9264a3b941f29590b6feedd-20211110 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FW4lI1nxmNtd/IT/tY+A90HGfKmb4Gx1XGsdWrcaA6c=; b=R0acouXnqanx4lKCd/5tPLPqmFPnxQB14944XAlVsSYbjs9A4eLEgPZH6qOEQNnS0UccZ8zAZA/SL4Ndg4e+gkRz8bF/H+9uzdL9LKp+nBgbYx/qg218yQN0d3k4D7FiDInCLaZumslNQPlgt2+9kSSYIfAMOYkjv+VpG7qcICU=; X-UUID: 9a8cd1a9d9264a3b941f29590b6feedd-20211110 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1232866730; Wed, 10 Nov 2021 11:11:41 +0800 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Wed, 10 Nov 2021 11:11:31 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Wed, 10 Nov 2021 11:11:31 +0800 Message-ID: <054260428d9d7718f630ecc1b2bdec34ecf1f799.camel@mediatek.com> Subject: Re: [PATCH v4] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer From: Irui Wang To: Dafna Hirschfeld , houlong wei , Alexandre Courbot , "Hans Verkuil" CC: Linux Media Mailing List , "moderated list:ARM/Mediatek SoC support" , LKML , "kernel@collabora.com" , Dafna Hirschfeld , Tiffany Lin =?UTF-8?Q?=28=E6=9E=97=E6=85=A7=E7=8F=8A=29?= , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , Mauro Carvalho Chehab , Matthias Brugger Date: Wed, 10 Nov 2021 11:11:30 +0800 In-Reply-To: <428f216d-cdff-e22d-b96e-f9dd9cc158e3@collabora.com> References: <20210920170408.1561-1-dafna.hirschfeld@collabora.com> <9475ac5b-79fe-da0e-ed1c-a91275cad46e@collabora.com> <8dfc07306b853126e8109fc953fd6388b63c65d2.camel@mediatek.com> <4e7ff420-f67d-5d4a-8733-f4b83d80af13@collabora.com> <428f216d-cdff-e22d-b96e-f9dd9cc158e3@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIERhZm5hLA0KDQpUaGFua3MgZm9yIHRoZSBwYXRjaC4NCk9uIFR1ZSwgMjAyMS0xMS0wOSBh dCAxMDo0NiArMDIwMCwgRGFmbmEgSGlyc2NoZmVsZCB3cm90ZToNCj4gDQo+IE9uIDAzLjExLjIx IDEzOjA0LCBEYWZuYSBIaXJzY2hmZWxkIHdyb3RlOg0KPiA+IA0KPiA+IA0KPiA+IE9uIDAzLjEx LjIxIDEwOjE5LCBJcnVpIFdhbmcgd3JvdGU6DQo+ID4gPiBIaSwNCj4gPiA+IA0KPiA+ID4gVGhl ICJsZW4iIG9mIHNoYXJlX2J1ZiBjb3BpZWQgc2hvdWxkIGJlIGFsd2F5cyA4IGFsaWdubWVudDsN Cj4gPiA+IGRvIHlvdSBoYXZlIG90aGVyIGxvZ3MgdG8gcHJvdmUgdGhlIGxlbiBpcyBub3QgOCBh bGlnbm1lbnQgd2hlbg0KPiA+ID4gZXJyb3JzDQo+ID4gPiBhcHBlYXI/DQo+ID4gDQo+ID4gSGks IEkgZm91bmQgb3V0IHRoYXQgInNpemVvZihtZHBfaXBpX2NvbW0pID0gMjAiDQo+ID4gdGhpcyBp cyBkdWUgdG8gdGhlIG1hY3JvICNwcmFnbWEgcGFjayhwdXNoLCA0KSBpbiBtdGtfbWRwX2lwaS5o DQo+ID4gDQo+ID4gc2VlIFsxXQ0KPiA+IA0KPiA+IFsxXSBodHRwOi8vbGttbC5pdS5lZHUvaHlw ZXJtYWlsL2xpbnV4L2tlcm5lbC8yMTA5LjIvMDQ5NzguaHRtbA0KPiA+IA0KPiANCj4gSGkgSXJ1 aSBXYW5nLA0KPiBBbnkgdXBkYXRlIHJlZ2FyZGluZyB0aGF0IHBhdGNoPw0KPiBDYW4geW91IGdp dmUgbW9yZSBleHBsYW5hdGlvbiBmb3IgdGhhdCBlcnJvcnMgdGhhdCB3ZSBzZWUNCj4gd2hlbiB0 aGUgYnVmZmVyIHNpemUgaXMgbm90IGEgbXVsdGlwbGUgb2YgOD8NCj4gDQo+IFRoYW5rcywNCj4g RGFmbmENCg0Kc2hhcmVfYnVmIGlzIGEgbWFwcGVkIG1lbW9yeSBieSBpb3JlbWFwLCBpdCBzaG91 bGQgYmUgYmV0dGVyIHVzZQ0KbWVtY3B5X3RvL2Zyb21pbyBpbnN0ZWFkIG9mIG1lbWNweSBiZWNh dXNlIG9mIGFsaWdubWVudC4NCg0KQXMgZm9yIG1lbWNweV90b2lvLCBpdCBtYXkgYWxzbyBoYXZl IHJlcXVpcmVtZW50cyBmb3IgYWxpZ25tZW50LCB3ZSBjYW4NCmFsc28gZ2V0IHN1Y2ggaW5mb3Jt YXRpb24gZnJvbToNCg0KaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvdjUuMTUvc291 cmNlL2RyaXZlcnMvbXRkL3NwaS1ub3IvY29udHJvbGxlcnMvYXNwZWVkLXNtYy5jI0wyMDcNCi4N Cg0KU28sIGl0J3Mgbm90IFZQVSBIVyBidWcgb3IgbGltaXRhdGlvbiwgaXQncyBtZW1jcHlfdG9p byByZXF1aXJlbWVudHMsDQptYXliZSB3ZSBjYW4gbW9kaWZ5IElQSSBtZXNzYWdlIHRvIGRvIGFs aWdubWVudCwgYnV0IGl0IG5lZWQgbW9kaWZ5DQpib3RoIGtlcm5lbCBhbmQgdnB1IGZpcm13YXJl LCB3aGljaCB3aWxsIGJyZWFrIHVwc3RyZWFtIGJhY2t3YXJkDQpjb21wYXRpYmxlLCB3ZSB0aGlu ayBpdCdzIHVuYWNjZXB0YWxlLg0KDQpJZiB0aGlzIHBhdGNoIGNhbiBzb2x2ZSB0aGUgaXNzdWUs IHdlIHRoaW5rIGl0J3MgT0suDQoNClRoYW5rcw0KPiANCj4gPiBUaGFua3MsDQo+ID4gRGFmbmEN Cj4gPiANCj4gPiA+ID4gPiBbNTguMzUwODQxXSBtdGstbWRwIDE0MDAxMDAwLnJkbWE6IHByb2Nl c3NpbmcgZmFpbGVkOiAtMjINCj4gPiA+IA0KPiA+ID4gT24gV2VkLCAyMDIxLTExLTAzIGF0IDE2 OjAzICswODAwLCBob3Vsb25nIHdlaSB3cm90ZToNCj4gPiA+ID4gQWRkIG10ay12cHUgZHJpdmVy IGV4cGVydCBpcnVpLndhbmcgaW4gdGhlIGxvb3AuDQo+ID4gPiA+IA0KPiA+ID4gPiBPbiBNb24s IDIwMjEtMTAtMTggYXQgMTU6MDcgKzA4MDAsIERhZm5hIEhpcnNjaGZlbGQgd3JvdGU6DQo+ID4g PiA+ID4gDQo+ID4gPiA+ID4gT24gMTguMTAuMjEgMDM6MTYsIEFsZXhhbmRyZSBDb3VyYm90IHdy b3RlOg0KPiA+ID4gPiA+ID4gSGkgSGFucyENCj4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gT24g TW9uLCBPY3QgNCwgMjAyMSBhdCA2OjM3IFBNIEhhbnMgVmVya3VpbCA8DQo+ID4gPiA+ID4gPiBo dmVya3VpbEB4czRhbGwubmw+DQo+ID4gPiA+ID4gPiB3cm90ZToNCj4gPiA+ID4gPiA+ID4gDQo+ ID4gPiA+ID4gPiA+IE9uIDIwLzA5LzIwMjEgMTk6MDQsIERhZm5hIEhpcnNjaGZlbGQgd3JvdGU6 DQo+ID4gPiA+ID4gPiA+ID4gRnJvbTogQWxleGFuZHJlIENvdXJib3QgPGFjb3VyYm90QGNocm9t aXVtLm9yZz4NCj4gPiA+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ID4gPiBXaGVuIHJ1bm5pbmcg bWVtY3B5X3RvaW86DQo+ID4gPiA+ID4gPiA+ID4gbWVtY3B5X3RvaW8oc2VuZF9vYmotPnNoYXJl X2J1ZiwgYnVmLCBsZW4pOw0KPiA+ID4gPiA+ID4gPiA+IGl0IHdhcyBmb3VuZCB0aGF0IGVycm9y cyBhcHBlYXIgaWYgbGVuIGlzIG5vdCBhDQo+ID4gPiA+ID4gPiA+ID4gbXVsdGlwbGUgb2YNCj4g PiA+ID4gPiA+ID4gPiA4Og0KPiA+ID4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gPiA+IFs1OC4z NTA4NDFdIG10ay1tZHAgMTQwMDEwMDAucmRtYTogcHJvY2Vzc2luZyBmYWlsZWQ6DQo+ID4gPiA+ ID4gPiA+ID4gLTIyDQo+ID4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gPiBXaHkgZG8gZXJyb3Jz IGFwcGVhcj8gSXMgdGhhdCBkdWUgdG8gYSBIVyBidWc/IFNvbWUgb3RoZXINCj4gPiA+ID4gPiA+ ID4gcmVhc29uPw0KPiA+ID4gPiA+ID4gDQo+ID4gPiA+ID4gPiBNVEsgZm9sa3Mgd291bGQgYmUg dGhlIGJlc3QgcGxhY2VkIHRvIGFuc3dlciB0aGlzLCBidXQNCj4gPiA+ID4gPiA+IHNpbmNlIHRo ZQ0KPiA+ID4gPiA+ID4gZmFpbHVyZSBpcyByZXBvcnRlZCBieSB0aGUgZmlybXdhcmUgSSdkIHN1 c3BlY3QgZWl0aGVyIGENCj4gPiA+ID4gPiA+IGZpcm13YXJlDQo+ID4gPiA+ID4gPiBvcg0KPiA+ ID4gPiA+ID4gaGFyZHdhcmUgbGltaXRhdGlvbi4NCj4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4g PiANCj4gPiA+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ID4gPiBUaGlzIHBhdGNoIGVuc3VyZXMg dGhlIGNvcHkgb2YgYSBtdWx0aXBsZSBvZiA4IHNpemUgYnkNCj4gPiA+ID4gPiA+ID4gPiBjYWxs aW5nDQo+ID4gPiA+ID4gPiA+ID4gcm91bmRfdXAobGVuLCA4KSB3aGVuIGNvcHlpbmcNCj4gPiA+ ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ID4gPiBGaXhlczogZTY1OTlhZGZhZDMwICgibWVkaWE6 IG10ay12cHU6IGF2b2lkIHVuYWxpZ25lZA0KPiA+ID4gPiA+ID4gPiA+IGFjY2Vzcw0KPiA+ID4g PiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ID4gRFRDTSBidWZmZXIuIikNCj4gPiA+ID4gPiA+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBBbGV4YW5kcmUgQ291cmJvdCA8YWNvdXJib3RAY2hyb21pdW0u b3JnDQo+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEVu cmljIEJhbGxldGJvIGkgU2VycmEgPA0KPiA+ID4gPiA+ID4gPiA+IGVucmljLmJhbGxldGJvQGNv bGxhYm9yYS5jb20+DQo+ID4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRGFmbmEgSGlyc2No ZmVsZCA8DQo+ID4gPiA+ID4gPiA+ID4gZGFmbmEuaGlyc2NoZmVsZEBjb2xsYWJvcmEuY29tDQo+ ID4gPiA+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ID4gPiBSZXZp ZXdlZC1ieTogSG91bG9uZyBXZWkgPGhvdWxvbmcud2VpQG1lZGlhdGVrLmNvbT4NCj4gPiA+ID4g PiA+ID4gPiAtLS0NCj4gPiA+ID4gPiA+ID4gPiBjaGFuZ2VzIHNpbmNlIHYzOg0KPiA+ID4gPiA+ ID4gPiA+IDEuIG11bHRpbGUgLT4gbXVsdGlwbGUNCj4gPiA+ID4gPiA+ID4gPiAyLiBhZGQgaW5s aW5lIGRvYw0KPiA+ID4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gPiA+IGNoYW5nZXMgc2luY2Ug djI6DQo+ID4gPiA+ID4gPiA+ID4gMS4gZG8gdGhlIGV4dHJhIGNvcHkgb25seSBpZiBsZW4gaXMg bm90IG11bHRpcGxlIG9mIDgNCj4gPiA+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ID4gPiBjaGFu Z2VzIHNpbmNlIHYxOg0KPiA+ID4gPiA+ID4gPiA+IDEuIGNoYW5nZSBzaWduLW9mZi1ieSB0YWdz DQo+ID4gPiA+ID4gPiA+ID4gMi4gY2hhbmdlIHZhbHVlcyB0byBtZW1zZXQNCj4gPiA+ID4gPiA+ ID4gPiANCj4gPiA+ID4gPiA+ID4gPiAgICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay12cHUv bXRrX3ZwdS5jIHwgMTUNCj4gPiA+ID4gPiA+ID4gPiArKysrKysrKysrKysrKy0NCj4gPiA+ID4g PiA+ID4gPiAgICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQ0KPiA+ID4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L21lZGlhL3BsYXRmb3JtL210ay12cHUvbXRrX3ZwdS5jDQo+ID4gPiA+ID4gPiA+ID4gYi9kcml2 ZXJzL21lZGlhL3BsYXRmb3JtL210ay12cHUvbXRrX3ZwdS5jDQo+ID4gPiA+ID4gPiA+ID4gaW5k ZXggZWMyOTBkZGU1OWNmLi4xZGYwMzE3MTZjOGYgMTAwNjQ0DQo+ID4gPiA+ID4gPiA+ID4gLS0t IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdnB1L210a192cHUuYw0KPiA+ID4gPiA+ID4g PiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZwdS9tdGtfdnB1LmMNCj4gPiA+ ID4gPiA+ID4gPiBAQCAtMzQ5LDcgKzM0OSwyMCBAQCBpbnQgdnB1X2lwaV9zZW5kKHN0cnVjdA0K PiA+ID4gPiA+ID4gPiA+IHBsYXRmb3JtX2RldmljZQ0KPiA+ID4gPiA+ID4gPiA+ICpwZGV2LA0K PiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgICB9DQo+ID4gPiA+ID4gPiA+ID4gICAgICAg ICB9IHdoaWxlICh2cHVfY2ZnX3JlYWRsKHZwdSwgSE9TVF9UT19WUFUpKTsNCj4gPiA+ID4gPiA+ ID4gPiANCj4gPiA+ID4gPiA+ID4gPiAtICAgICBtZW1jcHlfdG9pbyhzZW5kX29iai0+c2hhcmVf YnVmLCBidWYsIGxlbik7DQo+ID4gPiA+ID4gPiA+ID4gKyAgICAgLyoNCj4gPiA+ID4gPiA+ID4g PiArICAgICAgKiB3aGVuIGNvcHlpbmcgZGF0YSB0byB0aGUgdnB1IGhhcmR3YXJlLCB0aGUNCj4g PiA+ID4gPiA+ID4gPiBtZW1jcHlfdG9pbw0KPiA+ID4gPiA+ID4gPiA+IG9wZXJhdGlvbiBtdXN0 IGNvcHkNCj4gPiA+ID4gPiA+ID4gPiArICAgICAgKiBhIG11bHRpcGxlIG9mIDguIE90aGVyd2lz ZSB0aGUgcHJvY2Vzc2luZw0KPiA+ID4gPiA+ID4gPiA+IGZhaWxzDQo+ID4gPiA+ID4gPiA+IA0K PiA+ID4gPiA+ID4gPiBTYW1lIGhlcmU6IGl0IG5lZWRzIHRvIGV4cGxhaW4gd2h5IHRoZSBwcm9j ZXNzaW5nIGZhaWxzLg0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IElzIHdyaXRpbmcgJ2R1ZSB0byBo YXJkd2FyZSBvciBmaXJtd2FyZSBsaW1pdGF0aW9uJyBlbm91Z2g/DQo+ID4gPiA+ID4gSWYgbm90 LCB0aGVuIHdlIHNob3VsZCB3YWl0IGZvciBtZWRpYXRlayBwZW9wbGUncyByZXNwb25zZSB0bw0K PiA+ID4gPiA+IGV4cGxhaW4NCj4gPiA+ID4gPiBpZiB0aGV5IGtub3cgbW9yZQ0KPiA+ID4gPiA+ IA0KPiA+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ID4gPiArICAgICAgKi8NCj4gPiA+ID4gPiA+ ID4gPiArICAgICBpZiAobGVuICUgOCAhPSAwKSB7DQo+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAg ICAgICB1bnNpZ25lZCBjaGFyIGRhdGFbU0hBUkVfQlVGX1NJWkVdOw0KPiA+ID4gPiA+ID4gPiAN Cj4gPiA+ID4gPiA+ID4gV291bGRuJ3QgaXQgYmUgbW9yZSByb2J1c3QgaWYgeW91IHNheToNCj4g PiA+ID4gPiA+ID4gDQo+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGNo YXIgZGF0YVtzaXplb2Yoc2VuZF9vYmotDQo+ID4gPiA+ID4gPiA+ID4gc2hhcmVfYnVmKV07DQo+ ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+IERlZmluaXRlbHkgeWVzLg0KPiA+ID4gPiA+IA0KPiA+ ID4gPiA+IEknbGwgc2VuZCB2NSBmaXhpbmcgdGhpcw0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4g DQo+ID4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gPiBJIGFsc28gdGhpbmsgdGhhdCB0aGUgU0hB UkVfQlVGX1NJWkUgZGVmaW5lIG5lZWRzIGENCj4gPiA+ID4gPiA+ID4gY29tbWVudA0KPiA+ID4g PiA+ID4gPiBzdGF0aW5nIHRoYXQgaXQgbXVzdCBiZSBhDQo+ID4gPiA+ID4gPiA+IG11bHRpcGxl IG9mIDgsIG90aGVyd2lzZSB1bmV4cGVjdGVkIHRoaW5ncyBjYW4gaGFwcGVuLg0KPiA+ID4gPiA+ ID4gPiANCj4gPiA+ID4gPiA+ID4gWW91IGFsc28gbm90aWNlZCB0aGF0IHRoZSBjdXJyZW50IFNI QVJFX0JVRl9TSVpFIGRlZmluZQ0KPiA+ID4gPiA+ID4gPiBpcyB0b28NCj4gPiA+ID4gPiA+ID4g bG93LCBidXQgSSBzYXcNCj4gPiA+ID4gPiA+ID4gbm8gcGF0Y2ggY29ycmVjdGluZyB0aGlzLiBT aG91bGRuJ3QgdGhhdCBiZSBmaXhlZCBhcw0KPiA+ID4gPiA+ID4gPiB3ZWxsPw0KPiA+ID4gPiA+ ID4gDQo+ID4gPiA+ID4gPiBBRkFJQ1QgdGhlIGZpcm13YXJlIGV4cGVjdHMgdGhpcyBleGFjdCBz aXplIG9uIGl0cyBlbmQsIHNvDQo+ID4gPiA+ID4gPiBJDQo+ID4gPiA+ID4gPiBkb24ndA0KPiA+ ID4gPiA+ID4gYmVsaWV2ZSBpdCBjYW4gYmUgY2hhbmdlZCB0aGF0IGVhc2lseS4gQnV0IG1heWJl IHNvbWVvbmUNCj4gPiA+ID4gPiA+IGZyb20gTVRLDQo+ID4gPiA+ID4gPiBjYW4NCj4gPiA+ID4g PiA+IHByb3ZlIG1lIHdyb25nLg0KPiA+ID4gPiA+ID4gDQo+ID4gPiA+ID4gDQo+ID4gPiA+ID4g SSBsb29rZWQgZnVydGhlciBhbmQgbm90ZWQgdGhhdCB0aGUgc3RydWN0cyB0aGF0IGFyZSBsYXJn ZXINCj4gPiA+ID4gPiB0aGFuDQo+ID4gPiA+ID4gJ1NIQVJFX0JVRl9TSVpFJw0KPiA+ID4gPiA+ ICh2ZW5jX2FwX2lwaV9tc2dfZW5jX2V4dCB2ZW5jX2FwX2lwaV9tc2dfc2V0X3BhcmFtX2V4dCkN Cj4gPiA+ID4gPiBhcmUgdXNlZCBieSBkcml2ZXJzIHRoYXQgZG9uJ3QgdXNlIHRoaXMgdnB1IGFw aSwgc28gYWN0dWFsbHkNCj4gPiA+ID4gPiBTSEFSRV9CVUZfU0laRSBpcw0KPiA+ID4gPiA+IG5v dCB0b28gbG93IGFuZCBhcyBDb3J1cmJvdCB3b3J0ZSBwcm9iYWJseSBub3QgY2hhbmdlYWJsZS4N Cj4gPiA+ID4gPiANCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBUaGFua3MsDQo+ID4gPiA+ID4gRGFm bmENCj4gPiA+ID4gPiANCj4gPiA+ID4gPiA+IENoZWVycywNCj4gPiA+ID4gPiA+IEFsZXguDQo+ ID4gPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IA0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31064C433EF for ; Wed, 10 Nov 2021 03:22:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E66A061105 for ; Wed, 10 Nov 2021 03:22:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E66A061105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ic6pkhdG0AI+XLHjxHpeurqrSKz93Y27FN6m3gBV7rQ=; b=f+FHcECalx0dYN aUsm2yvj00bWYN0p/hIzsNSr8A9bGY8uqH2TbotVdm8r0UDs8pHPRc7MXLUhfRc5PLKzvrFRkzPHd sj/zPez35ccj/EZLul5TL0Z/WillAntCB7HqeJdDkoxQ5AMdQLkzrvJB1rHHpaeCffyPDDGje74Be UgGWotrjnge8Of44GoE0+dXZydRtt/MMsDRd5MFZ58f0lfEybrc8vComKbGDEBgBblsmCVnZbokIm 2DagtH74Q0wZ45kCbh76y7/PNVAmvrlO9sGeu5usYWW2Z7A1URF5iwbqmy/VC+N1quBwUEmUf+B+V ubs5lTP8YzTDL/lgl/Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkeBM-004Nnr-Ot; Wed, 10 Nov 2021 03:21:52 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkeBI-004NnC-Vs for linux-mediatek@lists.infradead.org; Wed, 10 Nov 2021 03:21:51 +0000 X-UUID: 24001f84447049bb821f2ad1d7ed236c-20211109 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FW4lI1nxmNtd/IT/tY+A90HGfKmb4Gx1XGsdWrcaA6c=; b=R0acouXnqanx4lKCd/5tPLPqmFPnxQB14944XAlVsSYbjs9A4eLEgPZH6qOEQNnS0UccZ8zAZA/SL4Ndg4e+gkRz8bF/H+9uzdL9LKp+nBgbYx/qg218yQN0d3k4D7FiDInCLaZumslNQPlgt2+9kSSYIfAMOYkjv+VpG7qcICU=; X-UUID: 24001f84447049bb821f2ad1d7ed236c-20211109 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 679033251; Tue, 09 Nov 2021 20:21:44 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Nov 2021 19:11:41 -0800 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Wed, 10 Nov 2021 11:11:31 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Wed, 10 Nov 2021 11:11:31 +0800 Message-ID: <054260428d9d7718f630ecc1b2bdec34ecf1f799.camel@mediatek.com> Subject: Re: [PATCH v4] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer From: Irui Wang To: Dafna Hirschfeld , houlong wei , Alexandre Courbot , "Hans Verkuil" CC: Linux Media Mailing List , "moderated list:ARM/Mediatek SoC support" , LKML , "kernel@collabora.com" , Dafna Hirschfeld , Tiffany Lin =?UTF-8?Q?=28=E6=9E=97=E6=85=A7=E7=8F=8A=29?= , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , Mauro Carvalho Chehab , Matthias Brugger Date: Wed, 10 Nov 2021 11:11:30 +0800 In-Reply-To: <428f216d-cdff-e22d-b96e-f9dd9cc158e3@collabora.com> References: <20210920170408.1561-1-dafna.hirschfeld@collabora.com> <9475ac5b-79fe-da0e-ed1c-a91275cad46e@collabora.com> <8dfc07306b853126e8109fc953fd6388b63c65d2.camel@mediatek.com> <4e7ff420-f67d-5d4a-8733-f4b83d80af13@collabora.com> <428f216d-cdff-e22d-b96e-f9dd9cc158e3@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_192149_048335_C2F9C578 X-CRM114-Status: GOOD ( 56.16 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Dafna, Thanks for the patch. On Tue, 2021-11-09 at 10:46 +0200, Dafna Hirschfeld wrote: > > On 03.11.21 13:04, Dafna Hirschfeld wrote: > > > > > > On 03.11.21 10:19, Irui Wang wrote: > > > Hi, > > > > > > The "len" of share_buf copied should be always 8 alignment; > > > do you have other logs to prove the len is not 8 alignment when > > > errors > > > appear? > > > > Hi, I found out that "sizeof(mdp_ipi_comm) = 20" > > this is due to the macro #pragma pack(push, 4) in mtk_mdp_ipi.h > > > > see [1] > > > > [1] http://lkml.iu.edu/hypermail/linux/kernel/2109.2/04978.html > > > > Hi Irui Wang, > Any update regarding that patch? > Can you give more explanation for that errors that we see > when the buffer size is not a multiple of 8? > > Thanks, > Dafna share_buf is a mapped memory by ioremap, it should be better use memcpy_to/fromio instead of memcpy because of alignment. As for memcpy_toio, it may also have requirements for alignment, we can also get such information from: https://elixir.bootlin.com/linux/v5.15/source/drivers/mtd/spi-nor/controllers/aspeed-smc.c#L207 . So, it's not VPU HW bug or limitation, it's memcpy_toio requirements, maybe we can modify IPI message to do alignment, but it need modify both kernel and vpu firmware, which will break upstream backward compatible, we think it's unacceptale. If this patch can solve the issue, we think it's OK. Thanks > > > Thanks, > > Dafna > > > > > > > [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 > > > > > > On Wed, 2021-11-03 at 16:03 +0800, houlong wei wrote: > > > > Add mtk-vpu driver expert irui.wang in the loop. > > > > > > > > On Mon, 2021-10-18 at 15:07 +0800, Dafna Hirschfeld wrote: > > > > > > > > > > On 18.10.21 03:16, Alexandre Courbot wrote: > > > > > > Hi Hans! > > > > > > > > > > > > On Mon, Oct 4, 2021 at 6:37 PM Hans Verkuil < > > > > > > hverkuil@xs4all.nl> > > > > > > wrote: > > > > > > > > > > > > > > On 20/09/2021 19:04, Dafna Hirschfeld wrote: > > > > > > > > From: Alexandre Courbot > > > > > > > > > > > > > > > > When running memcpy_toio: > > > > > > > > memcpy_toio(send_obj->share_buf, buf, len); > > > > > > > > it was found that errors appear if len is not a > > > > > > > > multiple of > > > > > > > > 8: > > > > > > > > > > > > > > > > [58.350841] mtk-mdp 14001000.rdma: processing failed: > > > > > > > > -22 > > > > > > > > > > > > > > Why do errors appear? Is that due to a HW bug? Some other > > > > > > > reason? > > > > > > > > > > > > MTK folks would be the best placed to answer this, but > > > > > > since the > > > > > > failure is reported by the firmware I'd suspect either a > > > > > > firmware > > > > > > or > > > > > > hardware limitation. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This patch ensures the copy of a multiple of 8 size by > > > > > > > > calling > > > > > > > > round_up(len, 8) when copying > > > > > > > > > > > > > > > > Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned > > > > > > > > access > > > > > > > > to > > > > > > > > DTCM buffer.") > > > > > > > > Signed-off-by: Alexandre Courbot > > > > > > > > > > > > > > > > Signed-off-by: Enric Balletbo i Serra < > > > > > > > > enric.balletbo@collabora.com> > > > > > > > > Signed-off-by: Dafna Hirschfeld < > > > > > > > > dafna.hirschfeld@collabora.com > > > > > > > > > > > > > > > > > > > > > > > > > Reviewed-by: Houlong Wei > > > > > > > > --- > > > > > > > > changes since v3: > > > > > > > > 1. multile -> multiple > > > > > > > > 2. add inline doc > > > > > > > > > > > > > > > > changes since v2: > > > > > > > > 1. do the extra copy only if len is not multiple of 8 > > > > > > > > > > > > > > > > changes since v1: > > > > > > > > 1. change sign-off-by tags > > > > > > > > 2. change values to memset > > > > > > > > > > > > > > > > drivers/media/platform/mtk-vpu/mtk_vpu.c | 15 > > > > > > > > ++++++++++++++- > > > > > > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > > > > b/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > > > > index ec290dde59cf..1df031716c8f 100644 > > > > > > > > --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > > > > +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > > > > @@ -349,7 +349,20 @@ int vpu_ipi_send(struct > > > > > > > > platform_device > > > > > > > > *pdev, > > > > > > > > } > > > > > > > > } while (vpu_cfg_readl(vpu, HOST_TO_VPU)); > > > > > > > > > > > > > > > > - memcpy_toio(send_obj->share_buf, buf, len); > > > > > > > > + /* > > > > > > > > + * when copying data to the vpu hardware, the > > > > > > > > memcpy_toio > > > > > > > > operation must copy > > > > > > > > + * a multiple of 8. Otherwise the processing > > > > > > > > fails > > > > > > > > > > > > > > Same here: it needs to explain why the processing fails. > > > > > > > > > > Is writing 'due to hardware or firmware limitation' enough? > > > > > If not, then we should wait for mediatek people's response to > > > > > explain > > > > > if they know more > > > > > > > > > > > > > > > > > > > > + */ > > > > > > > > + if (len % 8 != 0) { > > > > > > > > + unsigned char data[SHARE_BUF_SIZE]; > > > > > > > > > > > > > > Wouldn't it be more robust if you say: > > > > > > > > > > > > > > unsigned char data[sizeof(send_obj- > > > > > > > > share_buf)]; > > > > > > > > > > > > Definitely yes. > > > > > > > > > > I'll send v5 fixing this > > > > > > > > > > > > > > > > > > > > > > > > > I also think that the SHARE_BUF_SIZE define needs a > > > > > > > comment > > > > > > > stating that it must be a > > > > > > > multiple of 8, otherwise unexpected things can happen. > > > > > > > > > > > > > > You also noticed that the current SHARE_BUF_SIZE define > > > > > > > is too > > > > > > > low, but I saw > > > > > > > no patch correcting this. Shouldn't that be fixed as > > > > > > > well? > > > > > > > > > > > > AFAICT the firmware expects this exact size on its end, so > > > > > > I > > > > > > don't > > > > > > believe it can be changed that easily. But maybe someone > > > > > > from MTK > > > > > > can > > > > > > prove me wrong. > > > > > > > > > > > > > > > > I looked further and noted that the structs that are larger > > > > > than > > > > > 'SHARE_BUF_SIZE' > > > > > (venc_ap_ipi_msg_enc_ext venc_ap_ipi_msg_set_param_ext) > > > > > are used by drivers that don't use this vpu api, so actually > > > > > SHARE_BUF_SIZE is > > > > > not too low and as Corurbot worte probably not changeable. > > > > > > > > > > > > > > > Thanks, > > > > > Dafna > > > > > > > > > > > Cheers, > > > > > > Alex. > > > > > > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek