All of
 help / color / mirror / Atom feed
From: Anand Jain <>
To: Josef Bacik <>,
Subject: Re: [PATCH] btrfs: device stat, log when zeroed assist audit
Date: Sat, 11 Jan 2020 16:50:18 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 1/10/20 11:07 PM, Josef Bacik wrote:
> On 1/9/20 11:26 PM, Anand Jain wrote:
>> We had a report indicating that some read errors aren't reported by
>> the device stats in the userland. It is important to have the errors
>> reported in the device stat as user land scripts might depend on it to
>> take the reasonable corrective actions. But to debug these issue we need
>> to be really sure that request to reset the device stat did not come
>> from the userland itself. So log an info message when device error reset
>> happens.
>> For example:
>>   BTRFS info (device sdc): device stats zeroed by btrfs (9223)
>> Reported-by:
>> Link:
>> Signed-off-by: Anand Jain <>
>> ---
>>   BTRFS info (device sdc): device stats zeroed by btrfs (9223)
>> The last words are name and pid of the process, unfortunately it came out
>> as 'by btrfs'. At some point if there is a python and lib to reset it
>> would change, otherwise its going to be 'by btrfs', I am ok with it,
>> if otherwise please suggest the alternative.
> I think name(pid) makes sense, similar to what drop_caches does
> pr_info("%s (%d): drop_caches: %d\n",
>      current->comm, task_pid_nr(current),

There is a small deviation to what we already have in
device_list_add(), name (pid) is at the end the log message..

         "BTRFS: device label %s devid %llu transid %llu %s scanned by 
%s (%d)\n",
                                 disk_super->label, devid, 
found_transid, path,
                                 current->comm, task_pid_nr(current));

I am not sure. Can David can tweak during merge ?

Thanks, Anand

> Thanks,
> Josef

  reply	other threads:[~2020-01-11  8:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  4:26 [PATCH] btrfs: device stat, log when zeroed assist audit Anand Jain
2020-01-10 15:07 ` Josef Bacik
2020-01-11  8:50   ` Anand Jain [this message]
2020-01-13 16:59     ` David Sterba
2020-01-10 19:47 ` Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.