From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH v10 09/28] qmp: add query-sev command Date: Thu, 1 Mar 2018 14:09:09 -0600 Message-ID: <056098e9-43a8-222b-f265-e746c3ae00c5@redhat.com> References: <20180228211028.83970-1-brijesh.singh@amd.com> <20180228211028.83970-10-brijesh.singh@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "Edgar E. Iglesias" , Peter Maydell , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , Peter Crosthwaite , Richard Henderson , "Dr. David Alan Gilbert" , Alistair Francis , Christian Borntraeger , Alexander Graf , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Thomas Lendacky , Borislav Petkov , Bruce Rogers To: Brijesh Singh , qemu-devel@nongnu.org Return-path: In-Reply-To: <20180228211028.83970-10-brijesh.singh@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On 02/28/2018 03:10 PM, Brijesh Singh wrote: > The QMP query command can used to retrieve the SEV information when > memory encryption is enabled on AMD platform. >=20 > Cc: Eric Blake > Cc: "Daniel P. Berrang=C3=A9" > Cc: "Dr. David Alan Gilbert" > Cc: Markus Armbruster > Signed-off-by: Brijesh Singh > --- > monitor.c | 7 ++++++ > qapi-schema.json | 61 ++++++++++++++++++++++++++++++++++++++++++= +++++++++ Based on the pull request I just sent: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00394.html you will have to rebase this to stick things in qapi/misc.json instead. > target/i386/monitor.c | 8 +++++++ > 3 files changed, 76 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -3189,3 +3189,64 @@ > # Since: 2.11 > ## > { 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogActi= on'} } > + > +## > +# @SevState: > +# > +# An enumeration of SEV state information used during @query-sev. > +# > +# Since: 2.12 > +## > +{ 'enum': 'SevState', > + 'data': ['uninit', 'lupdate', 'lsecret', 'running', 'supdate', 'rupd= ate' ] } Could perhaps give more details about the meaning of each state. But=20 I'm not seeing anything blatantly wrong with the UI changes. Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erUWG-00070k-Je for qemu-devel@nongnu.org; Thu, 01 Mar 2018 15:09:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erUWC-0001V0-Gu for qemu-devel@nongnu.org; Thu, 01 Mar 2018 15:09:36 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44496 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erUWC-0001TZ-CM for qemu-devel@nongnu.org; Thu, 01 Mar 2018 15:09:32 -0500 References: <20180228211028.83970-1-brijesh.singh@amd.com> <20180228211028.83970-10-brijesh.singh@amd.com> From: Eric Blake Message-ID: <056098e9-43a8-222b-f265-e746c3ae00c5@redhat.com> Date: Thu, 1 Mar 2018 14:09:09 -0600 MIME-Version: 1.0 In-Reply-To: <20180228211028.83970-10-brijesh.singh@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v10 09/28] qmp: add query-sev command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh , qemu-devel@nongnu.org Cc: Alistair Francis , Christian Borntraeger , Cornelia Huck , "Daniel P . Berrange" , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , "Edgar E. Iglesias" , Eduardo Habkost , kvm@vger.kernel.org, Marcel Apfelbaum , Markus Armbruster , Paolo Bonzini , Peter Crosthwaite , Peter Maydell , Richard Henderson , Stefan Hajnoczi , Thomas Lendacky , Borislav Petkov , Alexander Graf , Bruce Rogers On 02/28/2018 03:10 PM, Brijesh Singh wrote: > The QMP query command can used to retrieve the SEV information when > memory encryption is enabled on AMD platform. >=20 > Cc: Eric Blake > Cc: "Daniel P. Berrang=C3=A9" > Cc: "Dr. David Alan Gilbert" > Cc: Markus Armbruster > Signed-off-by: Brijesh Singh > --- > monitor.c | 7 ++++++ > qapi-schema.json | 61 ++++++++++++++++++++++++++++++++++++++++++= +++++++++ Based on the pull request I just sent: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00394.html you will have to rebase this to stick things in qapi/misc.json instead. > target/i386/monitor.c | 8 +++++++ > 3 files changed, 76 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -3189,3 +3189,64 @@ > # Since: 2.11 > ## > { 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogActi= on'} } > + > +## > +# @SevState: > +# > +# An enumeration of SEV state information used during @query-sev. > +# > +# Since: 2.12 > +## > +{ 'enum': 'SevState', > + 'data': ['uninit', 'lupdate', 'lsecret', 'running', 'supdate', 'rupd= ate' ] } Could perhaps give more details about the meaning of each state. But=20 I'm not seeing anything blatantly wrong with the UI changes. Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org