From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D2AAC5519F for ; Fri, 20 Nov 2020 08:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B703A22249 for ; Fri, 20 Nov 2020 08:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727133AbgKTI37 (ORCPT ); Fri, 20 Nov 2020 03:29:59 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7709 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbgKTI37 (ORCPT ); Fri, 20 Nov 2020 03:29:59 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CcqTq21P7zkc9s; Fri, 20 Nov 2020 16:29:35 +0800 (CST) Received: from [10.174.179.81] (10.174.179.81) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Fri, 20 Nov 2020 16:29:53 +0800 Subject: Re: [PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init To: Julian Anastasov CC: , , , , , , , , , , , , References: <20201119104102.67427-1-wanghai38@huawei.com> From: "wanghai (M)" Message-ID: <0574c34c-60a8-8d8d-38b1-962898e55801@huawei.com> Date: Fri, 20 Nov 2020 16:29:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.81] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2020/11/20 2:22, Julian Anastasov дµÀ: > Hello, > > On Thu, 19 Nov 2020, Wang Hai wrote: > >> kmemleak report a memory leak as follows: >> >> BUG: memory leak >> unreferenced object 0xffff8880759ea000 (size 256): >> comm "syz-executor.3", pid 6484, jiffies 4297476946 (age 48.546s) >> hex dump (first 32 bytes): >> 00 00 00 00 01 00 00 00 08 a0 9e 75 80 88 ff ff ...........u.... [...] >> Reported-by: Hulk Robot >> Signed-off-by: Wang Hai >> --- >> net/netfilter/ipvs/ip_vs_ctl.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c >> index e279ded4e306..d99bb89e7c25 100644 >> --- a/net/netfilter/ipvs/ip_vs_ctl.c >> +++ b/net/netfilter/ipvs/ip_vs_ctl.c >> @@ -4180,6 +4180,9 @@ int __net_init ip_vs_control_net_init(struct netns_ipvs *ipvs) >> return 0; > May be we should add some #ifdef CONFIG_PROC_FS because > proc_create_net* return NULL when PROC is not used. For example: > > #ifdef CONFIG_PROC_FS > if (!proc_create_net... > goto err_vs; > if (!proc_create_net... > goto err_stats; > ... > #endif > ... > >> err: > #ifdef CONFIG_PROC_FS >> + remove_proc_entry("ip_vs_stats_percpu", ipvs->net->proc_net); > err_percpu: >> + remove_proc_entry("ip_vs_stats", ipvs->net->proc_net); > err_stats: >> + remove_proc_entry("ip_vs", ipvs->net->proc_net); > err_vs: > #endif > >> free_percpu(ipvs->tot_stats.cpustats); >> return -ENOMEM; >> } >> -- > Regards > > -- > Julian Anastasov > > . Thanks for your advice, I just sent v2 ¡°[PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_init¡± > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "wanghai (M)" Subject: Re: [PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init Date: Fri, 20 Nov 2020 16:29:52 +0800 Message-ID: <0574c34c-60a8-8d8d-38b1-962898e55801@huawei.com> References: <20201119104102.67427-1-wanghai38@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-ID: Content-Type: text/plain; charset="iso-8859-1"; format="flowed" To: Julian Anastasov Cc: horms@verge.net.au, pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, christian@brauner.io, hans.schillstrom@ericsson.com, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org =D4=DA 2020/11/20 2:22, Julian Anastasov =D0=B4=B5=C0: > Hello, > > On Thu, 19 Nov 2020, Wang Hai wrote: > >> kmemleak report a memory leak as follows: >> >> BUG: memory leak >> unreferenced object 0xffff8880759ea000 (size 256): >> comm "syz-executor.3", pid 6484, jiffies 4297476946 (age 48.546s) >> hex dump (first 32 bytes): >> 00 00 00 00 01 00 00 00 08 a0 9e 75 80 88 ff ff ...........u.... [...] >> Reported-by: Hulk Robot >> Signed-off-by: Wang Hai >> --- >> net/netfilter/ipvs/ip_vs_ctl.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_c= tl.c >> index e279ded4e306..d99bb89e7c25 100644 >> --- a/net/netfilter/ipvs/ip_vs_ctl.c >> +++ b/net/netfilter/ipvs/ip_vs_ctl.c >> @@ -4180,6 +4180,9 @@ int __net_init ip_vs_control_net_init(struct netns= _ipvs *ipvs) >> return 0; > May be we should add some #ifdef CONFIG_PROC_FS because > proc_create_net* return NULL when PROC is not used. For example: > > #ifdef CONFIG_PROC_FS > if (!proc_create_net... > goto err_vs; > if (!proc_create_net... > goto err_stats; > ... > #endif > ... > >> err: > #ifdef CONFIG_PROC_FS >> + remove_proc_entry("ip_vs_stats_percpu", ipvs->net->proc_net); > err_percpu: >> + remove_proc_entry("ip_vs_stats", ipvs->net->proc_net); > err_stats: >> + remove_proc_entry("ip_vs", ipvs->net->proc_net); > err_vs: > #endif > >> free_percpu(ipvs->tot_stats.cpustats); >> return -ENOMEM; >> } >> --=20 > Regards > > -- > Julian Anastasov > > . Thanks for your advice, I just sent v2 =A1=B0[PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_in= it=A1=B1 >