From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Steve Wise" To: "'Sagi Grimberg'" , "'Christoph Hellwig'" , , Cc: , , , "'Armen Baloyan'" , "'Jay Freyensee'" , "'Ming Lin'" , References: <1465248215-18186-1-git-send-email-hch@lst.de> <1465248215-18186-5-git-send-email-hch@lst.de> <5756B75C.9000409@lightbits.io> In-Reply-To: <5756B75C.9000409@lightbits.io> Subject: RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver Date: Thu, 9 Jun 2016 18:03:51 -0500 Message-ID: <057a01d1c2a3$3082eec0$9188cc40$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-ID: > > + > > +static int nvmet_rdma_cm_handler(struct rdma_cm_id *cm_id, > > + struct rdma_cm_event *event) > > +{ > > + struct nvmet_rdma_queue *queue = NULL; > > + int ret = 0; > > + > > + if (cm_id->qp) > > + queue = cm_id->qp->qp_context; > > + > > + pr_debug("%s (%d): status %d id %p\n", > > + rdma_event_msg(event->event), event->event, > > + event->status, cm_id); > > + > > + switch (event->event) { > > + case RDMA_CM_EVENT_CONNECT_REQUEST: > > + ret = nvmet_rdma_queue_connect(cm_id, event); The above nvmet cm event handler, nvmet_rdma_cm_handler(), calls nvmet_rdma_queue_connect() for CONNECT_REQUEST events, which calls nvmet_rdma_alloc_queue (), which, if it encounters a failure (like creating the qp), calls nvmet_rdma_cm_reject () which calls rdma_reject(). The non-zero error, however, gets returned back here and this function returns the error to the RDMA_CM which will also reject the connection as well as destroy the cm_id. So there are two rejects happening, I think. Either nvmet should reject and destroy the cm_id, or it should do neither and return non-zero to the RDMA_CM to reject/destroy. Steve. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver Date: Thu, 9 Jun 2016 18:03:51 -0500 Message-ID: <057a01d1c2a3$3082eec0$9188cc40$@opengridcomputing.com> References: <1465248215-18186-1-git-send-email-hch@lst.de> <1465248215-18186-5-git-send-email-hch@lst.de> <5756B75C.9000409@lightbits.io> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5756B75C.9000409-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Sagi Grimberg' , 'Christoph Hellwig' , axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Armen Baloyan' , 'Jay Freyensee' , 'Ming Lin' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > + > > +static int nvmet_rdma_cm_handler(struct rdma_cm_id *cm_id, > > + struct rdma_cm_event *event) > > +{ > > + struct nvmet_rdma_queue *queue = NULL; > > + int ret = 0; > > + > > + if (cm_id->qp) > > + queue = cm_id->qp->qp_context; > > + > > + pr_debug("%s (%d): status %d id %p\n", > > + rdma_event_msg(event->event), event->event, > > + event->status, cm_id); > > + > > + switch (event->event) { > > + case RDMA_CM_EVENT_CONNECT_REQUEST: > > + ret = nvmet_rdma_queue_connect(cm_id, event); The above nvmet cm event handler, nvmet_rdma_cm_handler(), calls nvmet_rdma_queue_connect() for CONNECT_REQUEST events, which calls nvmet_rdma_alloc_queue (), which, if it encounters a failure (like creating the qp), calls nvmet_rdma_cm_reject () which calls rdma_reject(). The non-zero error, however, gets returned back here and this function returns the error to the RDMA_CM which will also reject the connection as well as destroy the cm_id. So there are two rejects happening, I think. Either nvmet should reject and destroy the cm_id, or it should do neither and return non-zero to the RDMA_CM to reject/destroy. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: swise@opengridcomputing.com (Steve Wise) Date: Thu, 9 Jun 2016 18:03:51 -0500 Subject: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver In-Reply-To: <5756B75C.9000409@lightbits.io> References: <1465248215-18186-1-git-send-email-hch@lst.de> <1465248215-18186-5-git-send-email-hch@lst.de> <5756B75C.9000409@lightbits.io> Message-ID: <057a01d1c2a3$3082eec0$9188cc40$@opengridcomputing.com> > > + > > +static int nvmet_rdma_cm_handler(struct rdma_cm_id *cm_id, > > + struct rdma_cm_event *event) > > +{ > > + struct nvmet_rdma_queue *queue = NULL; > > + int ret = 0; > > + > > + if (cm_id->qp) > > + queue = cm_id->qp->qp_context; > > + > > + pr_debug("%s (%d): status %d id %p\n", > > + rdma_event_msg(event->event), event->event, > > + event->status, cm_id); > > + > > + switch (event->event) { > > + case RDMA_CM_EVENT_CONNECT_REQUEST: > > + ret = nvmet_rdma_queue_connect(cm_id, event); The above nvmet cm event handler, nvmet_rdma_cm_handler(), calls nvmet_rdma_queue_connect() for CONNECT_REQUEST events, which calls nvmet_rdma_alloc_queue (), which, if it encounters a failure (like creating the qp), calls nvmet_rdma_cm_reject () which calls rdma_reject(). The non-zero error, however, gets returned back here and this function returns the error to the RDMA_CM which will also reject the connection as well as destroy the cm_id. So there are two rejects happening, I think. Either nvmet should reject and destroy the cm_id, or it should do neither and return non-zero to the RDMA_CM to reject/destroy. Steve.