From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04920C04AA8 for ; Wed, 1 May 2019 20:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1394205F4 for ; Wed, 1 May 2019 20:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbfEAUUr (ORCPT ); Wed, 1 May 2019 16:20:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:48656 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726266AbfEAUUr (ORCPT ); Wed, 1 May 2019 16:20:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9EB1BAD12; Wed, 1 May 2019 20:20:45 +0000 (UTC) Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier To: Nishad Kamdar Cc: Manivannan Sadhasivam , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Joe Perches , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org References: <20190501070707.GA5619@nishad> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> Date: Wed, 1 May 2019 22:20:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190501070707.GA5619@nishad> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + linux-actions Am 01.05.19 um 09:07 schrieb Nishad Kamdar: > This patch corrects the SPDX License Identifier style > in header files related to Clock Drivers for Actions Semi Socs. > For C header files Documentation/process/license-rules.rst > mandates C-like comments (opposed to C source files where > C++ style should be used) [...] > drivers/clk/actions/owl-common.h | 2 +- > drivers/clk/actions/owl-composite.h | 2 +- > drivers/clk/actions/owl-divider.h | 2 +- > drivers/clk/actions/owl-factor.h | 2 +- > drivers/clk/actions/owl-fixed-factor.h | 2 +- > drivers/clk/actions/owl-gate.h | 2 +- > drivers/clk/actions/owl-mux.h | 2 +- > drivers/clk/actions/owl-pll.h | 2 +- > drivers/clk/actions/owl-reset.h | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) Where's the practical benefit of this patch? These are all private headers used from C files, so they can handle C++ comments just fine, otherwise we would've seen build failures. I could understand if you were patching files in include/ but not here. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE74C43219 for ; Wed, 1 May 2019 20:20:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78129205F4 for ; Wed, 1 May 2019 20:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QIWl7wQ5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78129205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1nVUObyPNobM25AS+UvaBkR74Qw8u3Hdy9OBdonYZAA=; b=QIWl7wQ5gIq1fl yGFRZjgB9rVUT6LB5V62y/BGe2RTnpySFmsdI5iUU2nK65mLZifESqqkDRxA3Oi8Bif0h3W5fNuMV +XljuYxzuGknpheigmvFsb9CfcpG+4RM0bKGz2ouXMStP+h9kMcPJdUecTPIX8RfUJVzRscWrP8GD t4EjmiCqqjUg9bxnG0BN3Nl3ptzkuMLhhpsnMg6Oce/Cyqu1NMtMKM8+71SAxiCqttwjeqLenqwlv R9Od1JJekuV43h6Rtf952yv0OeCXDxDO5MNqAmDMU+6X03ueFBdJFAtTdEecRAWEdSaHihlksp7yp TMVw/RH9RRXGACz4Kqqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLvin-0000us-SC; Wed, 01 May 2019 20:20:53 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLvij-0000to-IW; Wed, 01 May 2019 20:20:51 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9EB1BAD12; Wed, 1 May 2019 20:20:45 +0000 (UTC) Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier To: Nishad Kamdar References: <20190501070707.GA5619@nishad> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> Date: Wed, 1 May 2019 22:20:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190501070707.GA5619@nishad> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190501_132049_762064_6814D9BD X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Manivannan Sadhasivam , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Joe Perches , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org KyBsaW51eC1hY3Rpb25zCgpBbSAwMS4wNS4xOSB1bSAwOTowNyBzY2hyaWViIE5pc2hhZCBLYW1k YXI6Cj4gVGhpcyBwYXRjaCBjb3JyZWN0cyB0aGUgU1BEWCBMaWNlbnNlIElkZW50aWZpZXIgc3R5 bGUKPiBpbiBoZWFkZXIgZmlsZXMgcmVsYXRlZCB0byBDbG9jayBEcml2ZXJzIGZvciBBY3Rpb25z IFNlbWkgU29jcy4KPiBGb3IgQyBoZWFkZXIgZmlsZXMgRG9jdW1lbnRhdGlvbi9wcm9jZXNzL2xp Y2Vuc2UtcnVsZXMucnN0Cj4gbWFuZGF0ZXMgQy1saWtlIGNvbW1lbnRzIChvcHBvc2VkIHRvIEMg c291cmNlIGZpbGVzIHdoZXJlCj4gQysrIHN0eWxlIHNob3VsZCBiZSB1c2VkKQpbLi4uXQo+ICBk cml2ZXJzL2Nsay9hY3Rpb25zL293bC1jb21tb24uaCAgICAgICB8IDIgKy0KPiAgZHJpdmVycy9j bGsvYWN0aW9ucy9vd2wtY29tcG9zaXRlLmggICAgfCAyICstCj4gIGRyaXZlcnMvY2xrL2FjdGlv bnMvb3dsLWRpdmlkZXIuaCAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2Nsay9hY3Rpb25zL293bC1m YWN0b3IuaCAgICAgICB8IDIgKy0KPiAgZHJpdmVycy9jbGsvYWN0aW9ucy9vd2wtZml4ZWQtZmFj dG9yLmggfCAyICstCj4gIGRyaXZlcnMvY2xrL2FjdGlvbnMvb3dsLWdhdGUuaCAgICAgICAgIHwg MiArLQo+ICBkcml2ZXJzL2Nsay9hY3Rpb25zL293bC1tdXguaCAgICAgICAgICB8IDIgKy0KPiAg ZHJpdmVycy9jbGsvYWN0aW9ucy9vd2wtcGxsLmggICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMv Y2xrL2FjdGlvbnMvb3dsLXJlc2V0LmggICAgICAgIHwgMiArLQo+ICA5IGZpbGVzIGNoYW5nZWQs IDkgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCldoZXJlJ3MgdGhlIHByYWN0aWNhbCBi ZW5lZml0IG9mIHRoaXMgcGF0Y2g/IFRoZXNlIGFyZSBhbGwgcHJpdmF0ZQpoZWFkZXJzIHVzZWQg ZnJvbSBDIGZpbGVzLCBzbyB0aGV5IGNhbiBoYW5kbGUgQysrIGNvbW1lbnRzIGp1c3QgZmluZSwK b3RoZXJ3aXNlIHdlIHdvdWxkJ3ZlIHNlZW4gYnVpbGQgZmFpbHVyZXMuCgpJIGNvdWxkIHVuZGVy c3RhbmQgaWYgeW91IHdlcmUgcGF0Y2hpbmcgZmlsZXMgaW4gaW5jbHVkZS8gYnV0IG5vdCBoZXJl LgoKUmVnYXJkcywKQW5kcmVhcwoKLS0gClNVU0UgTGludXggR21iSCwgTWF4ZmVsZHN0ci4gNSwg OTA0MDkgTsO8cm5iZXJnLCBHZXJtYW55CkdGOiBGZWxpeCBJbWVuZMO2cmZmZXIsIE1hcnkgSGln Z2lucywgU3JpIFJhc2lhaApIUkIgMjEyODQgKEFHIE7DvHJuYmVyZykKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK