From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mahesh Kumar Subject: Re: [PATCH 02/11] drm/i915: Add more wrapper for fixed_point_16_16 operations Date: Fri, 12 May 2017 14:25:24 +0530 Message-ID: <058f5878-bb49-7fc5-4c3a-07a0b839b354@intel.com> References: <20170508114902.18965-1-mahesh1.kumar@intel.com> <20170508114902.18965-3-mahesh1.kumar@intel.com> <20170512002201.GN15015@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F27B6E67E for ; Fri, 12 May 2017 08:51:50 +0000 (UTC) In-Reply-To: <20170512002201.GN15015@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org SGksCgoKT24gRnJpZGF5IDEyIE1heSAyMDE3IDA1OjUyIEFNLCBNYXR0IFJvcGVyIHdyb3RlOgo+ IE9uIE1vbiwgTWF5IDA4LCAyMDE3IGF0IDA1OjE4OjUzUE0gKzA1MzAsIE1haGVzaCBLdW1hciB3 cm90ZToKPj4gVGhpcyBwYXRjaCBhZGRzIGZldyB3cmFwcGVyIHRvIHBlcmZvcm0gZml4ZWRfcG9p bnRfMTZfMTYgb3BlcmF0aW9ucwo+PiBtdWxfdTMyX2ZpeGVkXzE2XzE2X3JvdW5kX3VwIDogTXVs dGlwbGllcyB1MzIgYW5kIGZpeGVkXzE2XzE2X3QKPj4gCQkJCXZhcmlhYmxlcyAmIHJldHVybnMg dTMyIHJlc3VsdCB3aXRoCj4+IAkJCQlyb3VuZGluZy1vZmYuCj4+IG11bF9maXhlZF8xNl8xNiA6 IE11bHRpcGxpZXMgdHdvIGZpeGVkXzE2XzE2X3QgdmFyaWFibGUgJiByZXR1cm5zCj4+IAkJCQlm aXhlZF8xNl8xNgo+PiBkaXZfcm91bmRfdXBfZml4ZWRfMTZfMTYgOiBQZXJmb3JtIGRpdmlzaW9u IG9wZXJhdGlvbiBvbiBmaXhlZF8xNl8xNl90Cj4+IAkJCQl2YXJpYWJsZXMgJiByZXR1cm4gdTMy IHJlc3VsdCB3aXRoIHJvdW5kLW9mZgo+PiBmaXhlZF8xNl8xNl9kaXZfcm91bmRfdXBfdTY0IDog ZGV2aWRlIHVpbnQzMl90IHZhcmlhYmxlIGJ5IGZpeGVkXzE2XzE2Cj4+IAkJCQl2YXJpYWJsZSBh bmQgcm91bmRfdXAgdGhlIHJlc3VsdCB0byB1aW50MzJfdC4KPiBNaW5vciBuaXRwaWNrLCBidXQg SSdkIHNheSAicm91bmRpbmctdXAiIHJhdGhlciB0aGFuICJyb3VuZGluZy1vZmYiIGluCj4geW91 ciBkZXNjcmlwdGlvbnMgaGVyZS4KV2lsbCB1cGRhdGUuCj4KPj4gVGhlc2Ugd3JhcHBlcnMgd2ls bCBiZSB1c2VkIGJ5IGxhdGVyIHBhdGNoZXMgaW4gdGhlIHNlcmllcy4KPiBUaGUgbmFtZSBvbiB0 aGlzIGxhc3Qgb25lIChmaXhlZF8xNl8xNl9kaXZfcm91bmRfdXBfdTY0KSBkb2Vzbid0IHNlZW0g dG8KPiBtYXRjaCB3aGF0IGl0IGRvZXMuICBZb3UncmUgdXNpbmcgdTY0IGludGVybmFsbHksIGJ1 dCB0aGUgYWN0dWFsCj4gb3BlcmFuZHMgYXJlIGEgdTMyIGFuZCBhIGZpeGVkIHBvaW50IHZhbHVl LiAgV291bGRuJ3QgaXQgbWFrZSBtb3JlIHNlbnNlCj4gdG8gY2FsbCBpdCBkaXZfcm91bmRfdXBf dTMyX2ZpeGVkXzE2XzE2ICh0aGF0IGFsc28ga2VlcHMgdGhlIGRpdmlkZW5kCj4gZmlyc3QgYW5k IHRoZSBkaXZpc29yIHNlY29uZCwgd2hpY2ggc2VlbXMgbW9yZSBuYXR1cmFsIHRvIG1lKS4KPgo+ IEFjdHVhbGx5IHRoZSBuYW1pbmcgb2YgYWxsIHRoZSBmaXhlZCBwb2ludCBtYXRoIGZ1bmN0aW9u cyBpcyBhIGJpdAo+IGNvbmZ1c2luZy9pbmNvbnNpc3RlbnQuICBTb21lIG9mIHRoZW0gYXJlICJv cF90eXBlW190eXBlXVtfcm91bmRfdXBdLCIKPiBzb21lIG9mIHRoZW0gYXJlICJvcFtfcm91bmRf dXBdX3R5cGUsIiBzb21lIG9mIHRoZW0gYXJlCj4gInR5cGVfb3BbX3JvdW5kX3VwXSwiIGFuZCBz b21lIG9mIHRoZW0gYXJlICJ0eXBlX29wW19yb3VuZF91cF1fdHlwZS4iCj4gQWxzbywgbm9uZSBv ZiB0aGVtIHNwZWNpZnkgdGhlIHJldHVybiB2YWx1ZSB0eXBlLCBidXQgSSBndWVzcyB0aGF0J3Mg bm90Cj4gdG9vIG11Y2ggb2YgYSBwcm9ibGVtIHNpbmNlIHRoZSB1c2Ugb2YgYSBmaXhlZCBwb2lu dCBzdHJ1Y3R1cmUgd2lsbAo+IGVuc3VyZSB0aGUgY29tcGlsZXIgd2FybnMgaWYgc29tZW9uZSB0 cmllcyB0byB1c2UgdGhlbSBhc3N1bWluZyB0aGUKPiB3cm9uZyBraW5kIG9mIHJlc3VsdC4KPgo+ IE1heWJlIHdlIGNvdWxkIHN0YW5kYXJkaXplIHRoZSBuYW1lcyBhIGJpdCB0byBoZWxwIGF2b2lk IGNvbmZ1c2lvbj8gIEknZAo+IHN1Z2dlc3QgIm9wW19yb3VuZF91cF1fdHlwZTFfdHlwZTIuIiAg SWYgYm90aCB0eXBlcyBhcmUgdGhlIHNhbWUsIHdlJ2QKPiBzdGlsbCByZXBlYXQgdGhlIHR5cGUg Zm9yIGNsYXJpdHksIGJ1dCBtYXliZSB3ZSBjb3VsZCBqdXN0IHVzZSAiZml4ZWQxNiIKPiBvciAi Zml4MTYiIHRvIGtlZXAgdGhlIG92ZXJhbGwgbmFtZXMgZnJvbSBnZXR0aW5nIHRvbyBsb25nLiAg QW5kIGZvcgo+IGRpdmlzaW9uIHdlJ2QgYWx3YXlzIGtlZXAgdGhlIGRpdmlkZW5kIGFzIHRoZSBm aXJzdCB0eXBlLCBkaXZpc29yIGFzCj4gc2Vjb25kLgo+Cj4gRS5nLiwKPiAgICAgICAgICBtdWxf cm91bmRfdXBfdTMyX2ZpeGVkMTYoKQo+ICAgICAgICAgIGRpdl9yb3VuZF91cF91MzJfZml4ZWQx NigpCj4gICAgICAgICAgbXVsX2ZpeGVkMTZfZml4ZWQxNigpCj4gZGl2X3JvdW5kX3VwX2ZpeGVk MTZfZml4ZWQxNigpCndpbGwgdXNlIG5hbWUgIm11bF9maXhlZDE2IC8gZGl2X3JvdW5kX3VwX2Zp eGVkMTYiIChhc3N1bWluZyBzYW1lIHR5cGUgCmZvciBib3RoIHRoZSBvcGVyYW5kIGlmIG9ubHkg b25lIHR5cGUgaXMgdGhlcmUgaW4gZnVuY3Rpb24gbmFtZSksIGhvcGUgCnRoYXQgaXMgZmluZSB3 aXRoIHlvdS4KPiBBbmQgcHJlc3VtYWJseSB0aGUgZXhpc3RpbmcgZml4ZWQgcG9pbnQgb3BlcmF0 aW9ucyBjb3VsZCBiZSByZW5hbWVkIGluCj4gdGhlIHNhbWUgbWFubmVyLgp0aGFua3MgZm9yIHN1 Z2dlc3Rpb24vcmV2aWV3LCBJdCBzb3VuZHMgbG9naWNhbCAmIG1vcmUgY29uc2lzdGVudCwgd2ls bCAKZml4IGl0LApJbiB0aGlzIHBhdGNoIHdpbGwgdXBkYXRlIG9ubHkgdGhlc2UgNCB3cmFwcGVy cywgd2lsbCBjcmVhdGUgYSBuZXcgcGF0Y2ggCmF0IGVuZCBvZiB0aGUgc2VyaWVzIHRvIGFkZHJl c3MgbmFtaW5nIGZvciBvdGhlciB3cmFwcGVycy4KCnRoYW5rcywKLU1haGVzaAoKPgo+IE1hdHQK Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYWhlc2ggS3VtYXIgPG1haGVzaDEua3VtYXJAaW50ZWwuY29t Pgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIHwgNDMgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4gICAxIGZpbGUgY2hhbmdlZCwg NDMgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5kZXggNTgw NDczNGQzMGEzLi41ZmYwMDkxNzA3YzAgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ PiBAQCAtMTUyLDYgKzE1MiwzOCBAQCBzdGF0aWMgaW5saW5lIHVpbnRfZml4ZWRfMTZfMTZfdCBt YXhfZml4ZWRfMTZfMTYodWludF9maXhlZF8xNl8xNl90IG1heDEsCj4+ICAgCXJldHVybiBtYXg7 Cj4+ICAgfQo+PiAgIAo+PiArc3RhdGljIGlubGluZSB1aW50MzJfdCBkaXZfcm91bmRfdXBfZml4 ZWRfMTZfMTYodWludF9maXhlZF8xNl8xNl90IHZhbCwKPj4gKwkJCQkJCXVpbnRfZml4ZWRfMTZf MTZfdCBkKQo+PiArewo+PiArCXJldHVybiBESVZfUk9VTkRfVVAodmFsLnZhbCwgZC52YWwpOwo+ PiArfQo+PiArCj4+ICtzdGF0aWMgaW5saW5lIHVpbnQzMl90IG11bF91MzJfZml4ZWRfMTZfMTZf cm91bmRfdXAodWludDMyX3QgdmFsLAo+PiArCQkJCQkJICAgIHVpbnRfZml4ZWRfMTZfMTZfdCBt dWwpCj4+ICt7Cj4+ICsgICAgICAgdWludDY0X3QgaW50ZXJtZWRpYXRlX3ZhbDsKPj4gKyAgICAg ICB1aW50MzJfdCByZXN1bHQ7Cj4+ICsKPj4gKyAgICAgICBpbnRlcm1lZGlhdGVfdmFsID0gKHVp bnQ2NF90KSB2YWwgKiBtdWwudmFsOwo+PiArICAgICAgIGludGVybWVkaWF0ZV92YWwgPSBESVZf Uk9VTkRfVVBfVUxMKGludGVybWVkaWF0ZV92YWwsIDEgPDwgMTYpOwo+PiArICAgICAgIFdBUk5f T04oaW50ZXJtZWRpYXRlX3ZhbCA+PiAzMik7Cj4+ICsgICAgICAgcmVzdWx0ID0gY2xhbXBfdCh1 aW50MzJfdCwgaW50ZXJtZWRpYXRlX3ZhbCwgMCwgfjApOwo+PiArICAgICAgIHJldHVybiByZXN1 bHQ7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBpbmxpbmUgdWludF9maXhlZF8xNl8xNl90IG11bF9m aXhlZF8xNl8xNih1aW50X2ZpeGVkXzE2XzE2X3QgdmFsLAo+PiArCQkJCQkJIHVpbnRfZml4ZWRf MTZfMTZfdCBtdWwpCj4+ICt7Cj4+ICsJdWludDY0X3QgaW50ZXJtZWRpYXRlX3ZhbDsKPj4gKwl1 aW50X2ZpeGVkXzE2XzE2X3QgZnA7Cj4+ICsKPj4gKwlpbnRlcm1lZGlhdGVfdmFsID0gKHVpbnQ2 NF90KSB2YWwudmFsICogbXVsLnZhbDsKPj4gKwlpbnRlcm1lZGlhdGVfdmFsID0gaW50ZXJtZWRp YXRlX3ZhbCA+PiAxNjsKPj4gKwlXQVJOX09OKGludGVybWVkaWF0ZV92YWwgPj4gMzIpOwo+PiAr CWZwLnZhbCA9IGNsYW1wX3QodWludDMyX3QsIGludGVybWVkaWF0ZV92YWwsIDAsIH4wKTsKPj4g KwlyZXR1cm4gZnA7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgaW5saW5lIHVpbnRfZml4ZWRfMTZf MTZfdCBmaXhlZF8xNl8xNl9kaXYodWludDMyX3QgdmFsLCB1aW50MzJfdCBkKQo+PiAgIHsKPj4g ICAJdWludF9maXhlZF8xNl8xNl90IGZwLCByZXM7Cj4+IEBAIC0xNzQsNiArMjA2LDE3IEBAIHN0 YXRpYyBpbmxpbmUgdWludF9maXhlZF8xNl8xNl90IGZpeGVkXzE2XzE2X2Rpdl91NjQodWludDMy X3QgdmFsLCB1aW50MzJfdCBkKQo+PiAgIAlyZXR1cm4gcmVzOwo+PiAgIH0KPj4gICAKPj4gK3N0 YXRpYyBpbmxpbmUgdWludDMyX3QgZml4ZWRfMTZfMTZfZGl2X3JvdW5kX3VwX3U2NCh1aW50MzJf dCB2YWwsCj4+ICsJCQkJCQkgICAgdWludF9maXhlZF8xNl8xNl90IGQpCj4+ICt7Cj4+ICsJdWlu dDY0X3QgaW50ZXJtX3ZhbDsKPj4gKwo+PiArCWludGVybV92YWwgPSAodWludDY0X3QpdmFsIDw8 IDE2Owo+PiArCWludGVybV92YWwgPSBESVZfUk9VTkRfVVBfVUxMKGludGVybV92YWwsIGQudmFs KTsKPj4gKwlXQVJOX09OKGludGVybV92YWwgPj4gMzIpOwo+PiArCXJldHVybiBjbGFtcF90KHVp bnQzMl90LCBpbnRlcm1fdmFsLCAwLCB+MCk7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgaW5saW5l IHVpbnRfZml4ZWRfMTZfMTZfdCBtdWxfdTMyX2ZpeGVkXzE2XzE2KHVpbnQzMl90IHZhbCwKPj4g ICAJCQkJCQkgICAgIHVpbnRfZml4ZWRfMTZfMTZfdCBtdWwpCj4+ICAgewo+PiAtLSAKPj4gMi4x MS4wCj4+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK