All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tal Gilboa <talgi@mellanox.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	netdev@vger.kernel.org
Cc: mchan@broadcom.com, ogerlitz@mellanox.com,
	Andy Gospodarek <gospo@broadcom.com>
Subject: Re: [PATCH net-next v4 00/10] net: create dynamic software irq moderation library
Date: Wed, 10 Jan 2018 00:49:53 +0200	[thread overview]
Message-ID: <0591534f-4477-3a9d-8c79-797e9700295b@mellanox.com> (raw)
In-Reply-To: <d7cfb332-49fd-a8a1-8943-f59f5a5678a8@gmail.com>

On 1/10/2018 12:46 AM, Florian Fainelli wrote:
> Hey Andy,
> 
> On 01/09/2018 01:06 PM, Andy Gospodarek wrote:
>> From: Andy Gospodarek <gospo@broadcom.com>
>>
>> This converts the dynamic interrupt moderation library from the mlx5e
>> driver into a library so it can be used by any driver.  The penultimate
>> patch in this set adds support for this new dynamic interrupt moderation
>> library in the bnxt_en driver and the last patch creates an entry in the
>> MAINTAINERS file for this library.
>>
>> The main purpose of this code is to allow an administrator to make sure
>> that default coalesce settings are optimized for low latency, but
>> quickly adapt to handle high throughput/bulk traffic by altering how
>> much time passes before popping an interrupt.
>>
>> For any new driver the following changes would be needed to use this
>> library:
>>
>> - add elements in ring struct to track items needed by this library
>> - create function that can be called to actually set coalesce settings
>>    for the driver
>>
>> Credit to Rob Rice and Lee Reed for doing some of the initial proof of
>> concept and testing for this patch and Tal Gilboa and Or Gerlitz for
>> their comments, etc on this set.
>>
>> v4: Fix build breakage for VF representers noticed by kbuild test robot.
>> Thanks for being so courteous, kbuild test robot!
>>
>> v3: bnxt_en fix from Michael Chan, comment suggestion from Vasundhara
>> Volam, and small mlx5e header file fix from Tal Gilboa.
>>
>> v2: Spelling fixes from Stephen Hemminger, bnxt_en suggestions from
>> Michael Chan, spelling and formatting fixes from Or Gerlitz, and
>> spelling and mlx5e changes suggested by Tal Gilboa.
> 
> Certainly not a blocking item for this patch series, but can you
> consider a follow up patch adding a small bit of documentation entry
> covering how the implementation works as well as possible
> limitations/considerations depending on what the networking HW supports
> in terms of interrupt moderation capabilities? (e.g: is it necessary to
> support generating an interrupt on ring empty, a micro-second resolution
> RX/TX timeout etc. etc.).
> 
> Thanks for doing this!
> 

Hi Florian, I plan to do so right after these patches would be accepted.

  reply	other threads:[~2018-01-09 22:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 21:06 [PATCH net-next v4 00/10] net: create dynamic software irq moderation library Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 01/10] net/mlx5e: Move interrupt moderation structs to new file Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 02/10] net/mlx5e: Move interrupt moderation forward declarations Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 04/10] net/mlx5e: Move AM logic enums Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 05/10] net/mlx5e: Move generic functions to new file Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 06/10] net/mlx5e: Change Mellanox references in DIM code Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 08/10] net/dim: use struct net_dim_sample as arg to net_dim Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 09/10] bnxt_en: add support for software dynamic interrupt moderation Andy Gospodarek
2018-01-09 21:06 ` [PATCH net-next v4 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation Andy Gospodarek
2018-01-09 21:55 ` [PATCH net-next v4 00/10] net: create dynamic software irq moderation library Tal Gilboa
2018-01-09 22:46 ` Florian Fainelli
2018-01-09 22:49   ` Tal Gilboa [this message]
2018-01-09 22:55     ` Andy Gospodarek
2018-01-10 20:28 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0591534f-4477-3a9d-8c79-797e9700295b@mellanox.com \
    --to=talgi@mellanox.com \
    --cc=andy@greyhouse.net \
    --cc=f.fainelli@gmail.com \
    --cc=gospo@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.