Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target AS from address_space_translate_internal

From: Eric Blake <eblake@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target AS from address_space_translate_internal
Date: Mon, 18 Sep 2017 09:28:12 -0500	[thread overview]
Message-ID: <05940475-2563-87fc-bdc5-5acb1bba4932@redhat.com> (raw)
In-Reply-To: <20170918101709.30421-3-aik@ozlabs.ru>

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On 09/18/2017 05:16 AM, Alexey Kardashevskiy wrote:

Subject line: s/Explicitely/Explicitly/

> This is not so mechanical change in order to move to shared FlatViews
> so make it a separate patch.

Hard to understand; it's unclear whether this is the mechanical addition
of a parameter before the next patch does shared FlatViews, or whether
the next patch is mechanical by virtue of this patch doing the
non-mechanical changes.  Maybe:

Mechanical change to add a parameter to make it easier for the next
patch to share FlatViews.

> The first argument of
> address_space_do_translate() will become a FlatView, however since
> address_space_get_iotlb_entry() still wants AS, hence this change.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  exec.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]