All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
	loic.poulain@linaro.org, rfried@codeaurora.org,
	bjorn.andersson@linaro.org
Subject: Re: [PATCH 5/5] wcn36xx: pass information elements in scan requests
Date: Mon, 16 Apr 2018 16:06:49 +0200	[thread overview]
Message-ID: <0595a559-8220-bc22-0c33-4580119c774d@zonque.org> (raw)
In-Reply-To: <87lgdnp7sy.fsf@kamboji.qca.qualcomm.com>

On Monday, April 16, 2018 04:03 PM, Kalle Valo wrote:
> Daniel Mack <daniel@zonque.org> writes:
> 
>> When the ieee8022 core passes IE elements in the scan request, append
> 
> You mean mac80211?
> 
> And yeah, the ieee80211_ prefix is confusing. Many many years I
> started to change that to mac80211_ but gave up :(

Ah, yeah. I was just referring to the wifi core driver stack.

>> them to the firmware message. The driver currently tells the core that
>> it is capable of attaching up to WCN36XX_MAX_SCAN_IE_LEN octets, but
>> doesn't actually pass them to the the hardware.
>>
>> Some defines were moved around to avoid cyclic include dependencies.
> 
> Does this fix anything or change functionality somehow? You should
> document that also in the commit log.

I don't have a test case for this, no. But as the change was pretty much
straight forward, I sent it anyway.

I can resend with some more information on this if you like.


Thanks,
Daniel

  reply	other threads:[~2018-04-16 14:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 13:16 [PATCH 0/5] wcn36xx: scan related patches Daniel Mack
2018-04-16 13:16 ` [PATCH 1/5] wcn36xx: abort scan request when 'dequeued' indicator is sent Daniel Mack
2018-04-16 13:16 ` [PATCH 2/5] wcn36xx: cancel pending scan request when interface goes down Daniel Mack
2018-04-16 13:16 ` [PATCH 3/5] wcn36xx: handle scan cancellation when firmware support is missing Daniel Mack
2018-04-16 13:16 ` [PATCH 4/5] wcn36xx: send bss_type in scan requests Daniel Mack
2018-04-16 13:16 ` [PATCH 5/5] wcn36xx: pass information elements " Daniel Mack
2018-04-16 14:03   ` Kalle Valo
2018-04-16 14:06     ` Daniel Mack [this message]
2018-04-16 14:13       ` Kalle Valo
2018-04-16 14:29         ` Daniel Mack
2018-04-16 14:41           ` Kalle Valo
2018-04-16 15:03             ` Daniel Mack
2018-04-23 14:14               ` Kalle Valo
2018-04-16 22:24 ` [PATCH 0/5] wcn36xx: scan related patches Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0595a559-8220-bc22-0c33-4580119c774d@zonque.org \
    --to=daniel@zonque.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=rfried@codeaurora.org \
    --cc=wcn36xx@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.